From patchwork Mon Aug 26 13:46:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng-Hao Yang X-Patchwork-Id: 21009 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6C2C0BDE17 for ; Mon, 26 Aug 2024 13:46:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 46E72633CF; Mon, 26 Aug 2024 15:46:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="bI+i5Qzq"; dkim-atps=neutral Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 968646190C for ; Mon, 26 Aug 2024 15:46:43 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-42817bee9e8so37360555e9.3 for ; Mon, 26 Aug 2024 06:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724680003; x=1725284803; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Qy1/syJBMQAhbeQO/SmX18QglTgwN6qIX+kHeKaQKlM=; b=bI+i5QzqErd7n7Q/bOt6iDZh98smSYBRduhT5UqZHizl9k/Xwg8KSMRCtkFyBk4KVG LNJjJRdAHy/XGeLBQAPDNb4W0IJQia1BhvrMsB17h/uJX+Ijy4N45TZIOE7a2duGzOuy MrXshsul9GUO94KI4rZBNAXkkaZP/TFHAnSeY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724680003; x=1725284803; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qy1/syJBMQAhbeQO/SmX18QglTgwN6qIX+kHeKaQKlM=; b=h5UW2cHWVlphl8AXBKKi+P3O/GBEuY9JSmJYtRORoYJkBLv6i1nL/ihBAZcPXq7Bhd PEqofbBN7ycGopJbA4Tf+ZVY0mxY+KM1QzW6RP24q7J7pSs0Ue94OQPI2iSQcsrqrps5 Tz/1Rs726dAegRU0l600h3Uvz+3zxzKq2XOyyqUHpLViDtEGEU1LgS5B6d8PQrffK/MM eJrVcr+Bk8OjSYoeC1VaYFyx3hn3MQ54zTRB+xkdHH+WQdo+fpuVq9UHCqjskMR7Bwpp EaTgM/D6nVEwhaheTjK8BZ4jgOPtO2UTQsAwe7NyPlp28zcTygvypGpx5lNiYdr0c3Lm J5Sw== X-Gm-Message-State: AOJu0Yx7RYeT1VnBW6+nS4y8/uY0ll5KLZPAKOWO6aDZOonvRRw3zcRh n6vX3M7zz57EzKFrvb1VZ1k1s5BVv932ivfcA/knLGSFpzUnriE9cBoDwSDXUnQrB7Cx8mdZI4/ /hWdU X-Google-Smtp-Source: AGHT+IHg9NTpnbyx4alVuEX2rRiS7YX8QqRXYmnklgijZLUchLQpmi1mzdtU7MztuwxBBxHkK2zEhA== X-Received: by 2002:a05:600c:3b94:b0:429:e6bb:a436 with SMTP id 5b1f17b1804b1-42acd55654fmr74824305e9.9.1724680002679; Mon, 26 Aug 2024 06:46:42 -0700 (PDT) Received: from chenghaoyang-germany.c.googlers.com.com (161.126.77.34.bc.googleusercontent.com. [34.77.126.161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37311dca113sm8275039f8f.16.2024.08.26.06.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 06:46:42 -0700 (PDT) From: Harvey Yang X-Google-Original-From: Harvey Yang To: libcamera-devel@lists.libcamera.org Cc: Han-Lin Chen Subject: [PATCH] libcamera: Make FrameBuffer status default to FrameSuccess Date: Mon, 26 Aug 2024 13:46:30 +0000 Message-ID: <20240826134639.1398830-1-chenghaoyang@google.com> X-Mailer: git-send-email 2.46.0.295.g3b9ea8a38a-goog MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Han-Lin Chen There seems to be an assumption that a FrameBuffer is success unless the pipeline handler canceled the frame, or there is a failure processing the FrameBuffer. Make the assumption specific. Signed-off-by: Han-Lin Chen --- include/libcamera/framebuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h index 5ae2270b3..71202a1d2 100644 --- a/include/libcamera/framebuffer.h +++ b/include/libcamera/framebuffer.h @@ -33,7 +33,7 @@ struct FrameMetadata { unsigned int bytesused; }; - Status status; + Status status = FrameSuccess; unsigned int sequence; uint64_t timestamp;