From patchwork Tue Jul 23 14:56:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Semkowicz X-Patchwork-Id: 20698 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 57B7DC323E for ; Tue, 23 Jul 2024 14:57:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 56AD66336F; Tue, 23 Jul 2024 16:57:49 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=thaumatec-com.20230601.gappssmtp.com header.i=@thaumatec-com.20230601.gappssmtp.com header.b="KkTgxRqk"; dkim-atps=neutral Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BEB2619A1 for ; Tue, 23 Jul 2024 16:57:48 +0200 (CEST) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a7a47e2179dso116167366b.3 for ; Tue, 23 Jul 2024 07:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thaumatec-com.20230601.gappssmtp.com; s=20230601; t=1721746668; x=1722351468; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+SYu0mM/EE1bMPonVnwYsdoQ69mbTmYNe89fWbxySgU=; b=KkTgxRqk5+1BCWtgJeM9IdaaUQ8SWtHhJAfp87Dm1sdr96u2jJ76z1FIXN5YG32E/6 mQkENjK4Jh/aae28aCpb5gPOREOjxiMrq44MAKXeVsI33wqmi7yngpQtBnxOec5pZWht I3HgFbS6G+QtN1hqiKSWZEZ+3/ACstPAIvvw9hzNjk+QLy149Osi4UGZ+Dn0G2NHUGQ+ 0ZnUxnswJ09KugKsZq6KHphCJcPowAERL/0AEocFcTRSBrsRm6SONevh3cmqiz6Y6h9i v2tkG9Rpvg3keRvXmW1WgRqUYOTGh0EBalBZaq3aCc/t/tHh5Dl75B/YpuJdluGyh09C QCRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721746668; x=1722351468; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+SYu0mM/EE1bMPonVnwYsdoQ69mbTmYNe89fWbxySgU=; b=Sjo6P1XJ6ItPo+7RSfJa24pk0Aas0M+NS3Xn02spRBbKEoR9vwBYsAuM656UXQji1z 6c55fi/JK3alQ3w2l8ms7EjusILEq1cq9hrEjVO8ZfYfAbRP7fvdxhbbHkKvOZMOEotN KPFmCQ8VbTbvreim6XlfRXzPTUZVPzhE1vLfCzqVIl1MMb0gkXvFgtV91mnic72ZzFbM sIWce7/BtO+TBJEVvR23I7wz4SRho31cVW9Xma6/4jrEyvXX/yKRc+f+8IffxJVb7aD6 qXvK6iQMYAlIkgjgBGkKuggRTDRlbm4UWDDJ8RgR4c3uo1aYnTDMfO2oodIMhHZab66s hH6g== X-Gm-Message-State: AOJu0YwrN8C2EaCMbxaL8PIHVnQ41qwXqfQNqe5fvvbi+6j8xVWxHUZU CdMu6khzB+pJC1mb2j64hQ0GNWXC5UisE9nZaKyr67zdlKXs0K2bmtdgz19vilYB1Bj24lykaBK O X-Google-Smtp-Source: AGHT+IHNYcjaZ3y0Y5uYJkanm9hHAinxklbiiZAVwauqsp/R1VAfxvpaIKFUQb2T1jxJuDFoNamFJw== X-Received: by 2002:a17:906:7955:b0:a72:7245:ec0a with SMTP id a640c23a62f3a-a7a8861ab92mr248906766b.58.1721746667613; Tue, 23 Jul 2024 07:57:47 -0700 (PDT) Received: from localhost.localdomain ([91.90.172.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a3c8bebe5sm545435066b.119.2024.07.23.07.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jul 2024 07:57:47 -0700 (PDT) From: Daniel Semkowicz To: libcamera-devel@lists.libcamera.org Cc: Daniel Semkowicz Subject: [PATCH v2] libipa: camera_sensor_helper: Add OV5675 black level Date: Tue, 23 Jul 2024 16:56:25 +0200 Message-ID: <20240723145736.81241-1-dse@thaumatec.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add black level value for OV5675 camera sensor. According to datasheet, default value is 0x10, 10 bits width. However, Linux kernel driver initializes black level target value to 0x40. Set the value to the same as in kernel driver, but scaled to 16 bits. Signed-off-by: Daniel Semkowicz Reviewed-by: Quentin Schulz Reviewed-by: Kieran Bingham --- src/ipa/libipa/camera_sensor_helper.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index a1339c83..29a00d7f 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -601,6 +601,8 @@ class CameraSensorHelperOv5675 : public CameraSensorHelper public: CameraSensorHelperOv5675() { + /* From Linux kernel driver: 0x40 at 10bits. */ + blackLevel_ = 4096; gainType_ = AnalogueGainLinear; gainConstants_.linear = { 1, 0, 0, 128 }; }