From patchwork Tue Jun 11 21:20:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20265 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C6B6DC3237 for ; Tue, 11 Jun 2024 21:21:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E34E66546A; Tue, 11 Jun 2024 23:21:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nOkYMqNs"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BC8061A26 for ; Tue, 11 Jun 2024 23:21:22 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 72786A9A; Tue, 11 Jun 2024 23:21:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718140869; bh=Qlx/ro7vGVh832Dvby6lQaoJDsrvKu6KQnztNbCPIkc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nOkYMqNsL31bdRpaN+DyvyYC/EuiaJj7fLQwzmhDA9M0c/m5N+PW+HiSVQSP9iC64 8NJFSIE1Vb2Oo2VDueW8/9T+Or5EZu5dekrHkBVCFOt0yMDmN0m4o9Pcz94lfoEl85 NdBaqymS6u9Isi6xbULEF8DM9g7R4kE/4kmbfGWo= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 1/6] ipa: rkisp1: goc: Fix typographical issues in documentation. Date: Wed, 12 Jun 2024 00:20:56 +0300 Message-ID: <20240611212101.14313-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> References: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fix a few assorted typographical issues: - Sentences should end with a period. - Paragraphs should be separated by a blank line, and there should be no line break within a paragraph. - Doxygen lists need a list marker ('-' or '*', use '-' here). Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/rkisp1/algorithms/goc.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp index 0201a59deba3..fc5ad9f9177e 100644 --- a/src/ipa/rkisp1/algorithms/goc.cpp +++ b/src/ipa/rkisp1/algorithms/goc.cpp @@ -29,15 +29,16 @@ namespace ipa::rkisp1::algorithms { * \class GammaOutCorrection * \brief RkISP1 Gamma out correction * - * This algorithm implements the gamma out curve for the RkISP1. - * It defaults to a gamma value of 2.2 + * This algorithm implements the gamma out curve for the RkISP1. It defaults to + * a gamma value of 2.2. + * * As gamma is internally represented as a piecewise linear function with only * 17 knots, the difference between gamma=2.2 and sRGB gamma is minimal. * Therefore sRGB gamma was not implemented as special case. * * Useful links: - * https://www.cambridgeincolour.com/tutorials/gamma-correction.htm - * https://en.wikipedia.org/wiki/SRGB + * - https://www.cambridgeincolour.com/tutorials/gamma-correction.htm + * - https://en.wikipedia.org/wiki/SRGB */ LOG_DEFINE_CATEGORY(RkISP1Gamma) From patchwork Tue Jun 11 21:20:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20266 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C0353C3293 for ; Tue, 11 Jun 2024 21:21:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AB8926546D; Tue, 11 Jun 2024 23:21:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="t853/Tsz"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BD72561A26 for ; Tue, 11 Jun 2024 23:21:23 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C587EA9A; Tue, 11 Jun 2024 23:21:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718140871; bh=BY1KvL2omlGgZG8+YS/cug+bFLeSdBplKzmoA0SinE4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t853/TszN8QmyM8IlCpKtFHLZPqNuB4aLFcAGyr13u8d5AKVaLAVV4tzB1diUMqlX yfE0XA4y7EAa15NO6qzC8orMFLt55Zu+MlxzPBBmuRbkDqIIwBtq/wrkCIbdJBFttK fiPn/YTeXhJ4OxFd/hxye3GFHgjpxeVG1NPGwH2w= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 2/6] ipa: rkisp1: goc: Drop incorrect [[maybe_unused]] Date: Wed, 12 Jun 2024 00:20:57 +0300 Message-ID: <20240611212101.14313-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> References: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A few function parameters are marked with [[maybe_unused]] but are actually used. Drop the attribute. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/rkisp1/algorithms/goc.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp index fc5ad9f9177e..01331b653c27 100644 --- a/src/ipa/rkisp1/algorithms/goc.cpp +++ b/src/ipa/rkisp1/algorithms/goc.cpp @@ -48,8 +48,7 @@ const float kDefaultGamma = 2.2f; /** * \copydoc libcamera::ipa::Algorithm::init */ -int GammaOutCorrection::init([[maybe_unused]] IPAContext &context, - [[maybe_unused]] const YamlObject &tuningData) +int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData) { if (context.hw->numGammaOutSamples != RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10) { @@ -81,8 +80,7 @@ int GammaOutCorrection::configure(IPAContext &context, /** * \copydoc libcamera::ipa::Algorithm::queueRequest */ -void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context, - [[maybe_unused]] const uint32_t frame, +void GammaOutCorrection::queueRequest(IPAContext &context, const uint32_t frame, IPAFrameContext &frameContext, const ControlList &controls) { @@ -102,9 +100,9 @@ void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context, /** * \copydoc libcamera::ipa::Algorithm::prepare */ -void GammaOutCorrection::prepare([[maybe_unused]] IPAContext &context, +void GammaOutCorrection::prepare(IPAContext &context, [[maybe_unused]] const uint32_t frame, - [[maybe_unused]] IPAFrameContext &frameContext, + IPAFrameContext &frameContext, rkisp1_params_cfg *params) { ASSERT(context.hw->numGammaOutSamples == From patchwork Tue Jun 11 21:20:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20267 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 414ACC3237 for ; Tue, 11 Jun 2024 21:21:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E17DB65456; Tue, 11 Jun 2024 23:21:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rb4l5aSP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B30365456 for ; Tue, 11 Jun 2024 23:21:25 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CF60A9A; Tue, 11 Jun 2024 23:21:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718140872; bh=ultZUxj9VZ+Dnzp2O8WFl4GDApRm70NtBBQDZX1E4hg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rb4l5aSP4Tt7tN78r3ajGDRfxiDnOaBNClDjaBY4pe/QaKFc0l0ndKp0F6aBirqbf TfJ/jZDR6H/U/6PCrs8/XIEFfnkTJcTl5H1IECVFCGJQ4yPJCpapGWNR4oLxbXBZVh iu19AqhIF0k9OVVT3CeuK5qKhTIh/QeAF+dG8Esk= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 3/6] ipa: rkisp1: goc: Use copydoc Date: Wed, 12 Jun 2024 00:20:58 +0300 Message-ID: <20240611212101.14313-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> References: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Use the Doygen \copydoc command instead of duplicating documentation. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/rkisp1/algorithms/goc.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp index 01331b653c27..65460eb45135 100644 --- a/src/ipa/rkisp1/algorithms/goc.cpp +++ b/src/ipa/rkisp1/algorithms/goc.cpp @@ -64,11 +64,7 @@ int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData) } /** - * \brief Configure the Gamma given a configInfo - * \param[in] context The shared IPA context - * \param[in] configInfo The IPA configuration data - * - * \return 0 + * \copydoc libcamera::ipa::Algorithm::configure */ int GammaOutCorrection::configure(IPAContext &context, [[maybe_unused]] const IPACameraSensorInfo &configInfo) From patchwork Tue Jun 11 21:20:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20268 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DC8BCC3293 for ; Tue, 11 Jun 2024 21:21:32 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9209965467; Tue, 11 Jun 2024 23:21:32 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LO6I5Jr1"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 814B665446 for ; Tue, 11 Jun 2024 23:21:26 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7623AE0C; Tue, 11 Jun 2024 23:21:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718140873; bh=clXSMilTWHCoCAYcYA/m/lLuDzSJBudUJMZlnhkPkeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LO6I5Jr1Fl40ZEajQ473h4Zd4VW2MhsEgObMOksfPDyqg2gTXtQdAwD8/m1B7QW1K W378qB23uF0MmIQfRY/XU3vAHywZSHX2H/F0GGdpZr7Ail8iqY3LhOwTNvCO+JPYYi qYEiQsmiASVNT0ua3naMxiCVDcjRqcKDBT27Gtv4= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 4/6] ipa: rkisp1: goc: Mark default gamma table as static constexpr Date: Wed, 12 Jun 2024 00:20:59 +0300 Message-ID: <20240611212101.14313-5-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> References: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The values for the default gamma table are stored in an array that is never modified. Mark it as static constexpr to facilitate optimizations. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/rkisp1/algorithms/goc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp index 65460eb45135..e98c9526722f 100644 --- a/src/ipa/rkisp1/algorithms/goc.cpp +++ b/src/ipa/rkisp1/algorithms/goc.cpp @@ -108,7 +108,7 @@ void GammaOutCorrection::prepare(IPAContext &context, * The logarithmic segments as specified in the reference. * Plus an additional 0 to make the loop easier */ - std::array segments = { + static constexpr std::array segments = { 64, 64, 64, 64, 128, 128, 128, 128, 256, 256, 256, 512, 512, 512, 512, 512, 0 }; From patchwork Tue Jun 11 21:21:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20269 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2DFE7C3237 for ; Tue, 11 Jun 2024 21:21:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CBA9965476; Tue, 11 Jun 2024 23:21:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="RqgUz4OQ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C193B6546F for ; Tue, 11 Jun 2024 23:21:27 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CCE78A9A; Tue, 11 Jun 2024 23:21:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718140875; bh=00QeN9C7Th0maLzW4bhnqQwRkf48oDu3Fd5OFzPGLGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RqgUz4OQi8EW8/vVg7WHZwxLocMTKenN2k0FEefwTK+KIBq8cmGXH6V2ABhWUzku+ yMlUpblnBHN7tfn5ckJrJhO50MTBRNHfo8byi1AAYbDHbCwCYSgqBCUi3yjJis/UM6 keFceKkmYQOaJgBdnENfqfb7VfF2UArmIgklVfuc= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 5/6] ipa: rkisp1: goc: Avoid use of auto for short type Date: Wed, 12 Jun 2024 00:21:00 +0300 Message-ID: <20240611212101.14313-6-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> References: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Replace one occurrence of the auto type qualifier with the explicit type it represents to increase readability. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/ipa/rkisp1/algorithms/goc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp index e98c9526722f..a82cee3bbf61 100644 --- a/src/ipa/rkisp1/algorithms/goc.cpp +++ b/src/ipa/rkisp1/algorithms/goc.cpp @@ -112,7 +112,7 @@ void GammaOutCorrection::prepare(IPAContext &context, 64, 64, 64, 64, 128, 128, 128, 128, 256, 256, 256, 512, 512, 512, 512, 512, 0 }; - auto gamma_y = params->others.goc_config.gamma_y; + __u16 *gamma_y = params->others.goc_config.gamma_y; if (!frameContext.goc.update) return; From patchwork Tue Jun 11 21:21:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 20270 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5744CC32CF for ; Tue, 11 Jun 2024 21:21:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AA48365471; Tue, 11 Jun 2024 23:21:35 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PQIPOcW0"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BAA465467 for ; Tue, 11 Jun 2024 23:21:29 +0200 (CEST) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3256CE0C; Tue, 11 Jun 2024 23:21:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718140876; bh=heBOn4gBq8l+63AarYPy2EP2DyGwnI9oEo02ktO6xKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PQIPOcW0Q3HVZH17yw813hIVIUElP4omW7k2N4u2564zoQlSxSICZrKkGlEyFC/qT Ttwm9GtM1DXwV9IX44XByXOK0tynfqVFfAlk99E6K+Nh3ede8jtbNfFRXASPiu4rFQ 8Th2TH0vTHaWZsnUqWnE/2qHJGIsXPBmv6S78Pfc= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH 6/6] libcamera: controls: Add missing period at end of Gamma description Date: Wed, 12 Jun 2024 00:21:01 +0300 Message-ID: <20240611212101.14313-7-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> References: <20240611212101.14313-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The last sentence of the Gamma control description misses the final period. Add it. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Klug --- src/libcamera/control_ids_core.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml index be19135616cf..9d413a94e0ee 100644 --- a/src/libcamera/control_ids_core.yaml +++ b/src/libcamera/control_ids_core.yaml @@ -870,6 +870,6 @@ controls: description: | Specify a fixed gamma value. Default must be 2.2 which closely mimics sRGB gamma. Note that this is camera gamma, so it is applied as - 1.0/gamma + 1.0/gamma. ...