From patchwork Mon Jun 3 09:42:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 20186 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3616EBD87C for ; Mon, 3 Jun 2024 09:42:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3F959634CB; Mon, 3 Jun 2024 11:42:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="U/abV3Mx"; dkim-atps=neutral Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 76224634AF for ; Mon, 3 Jun 2024 11:42:15 +0200 (CEST) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-35e1fcd0c0fso2203504f8f.0 for ; Mon, 03 Jun 2024 02:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1717407735; x=1718012535; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rWGcY0BdCbZuLjGVkZCh+0YomNXKNzqakdUYCS6xl1I=; b=U/abV3MxPT94BxKogVkEv06Xyqy+3UxBUlvMt3440uhNjDWakjul60cYTfn9slSQCB N99Q8WNvX7gfIaSDQH3m/BHKX6sjfJKZeeUsWBSU8L15iDJkBKhC9MFMgowWCNxOnBAt Sdm4Mu97rVWpUIlBbduGoyD8VWdZnrCowyl3/YVQEhHa+kAQoD0I7+hy50VnxT90Qn0j igpJvCIkPyfWLyjRocQUQAGmtOcuureFompOZ2Yw6qhhlWfTknQKWRN4LBJLNElE5l2M DLVZlXlgmZbDhK2aO9ha+Slw1WukxdP6v2FK2HOx5GhBCVv08Jqv/nimkyfB6NoX9/bA 4yxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717407735; x=1718012535; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rWGcY0BdCbZuLjGVkZCh+0YomNXKNzqakdUYCS6xl1I=; b=HV0aRKJLM0FF7Ds5mWeMzwVAC6rdFdlocss0bZCV4ucWQu2Ja3ihalFBba7bpug2RF NHI4PJYeltZytEiiE/ACmtn2TbhqkPz/ngdQZszHAV6KxSPQkbdLwGysqVV6serQrpNJ 4sqrWYi8I+/Tm/PmZ5d/pB7V72rv/St+rIHw+kJJHErK2kGyciemN5uHrpAQZbSPDp3Q 8gu30/wUAPp6ZuJOsCB0y+A0B5ZF4qnXAYnhMxua4ESeh2CiGLM1+aROriAsEYgSgiB/ LDl3VC6oCrJvlHP4zwXaiCe7Zdw0takNAwvBAJOruJEyJVsgM0F8r26DWWLb3SFbyJzn UWOQ== X-Gm-Message-State: AOJu0YxJoVJ8mFbyj76+E+UOs9a2VvXtOtdUFyFXrwqxuqnqM4FUT2Me l6goBn1C5TZj7a+RECZ/sHRlMeT1rQk7QcHthcxnOpx6eH5T+Ik9MbBr6TxQ/knNmqkLQ5YggNc e X-Google-Smtp-Source: AGHT+IEzhLT1SZnAI4kmYQg0uY3hZ/UXfbfqr+MyfgcD6vstLZ5564tjOCwsYVUo3tBla+mBHD3n0Q== X-Received: by 2002:a05:6000:1754:b0:354:f6ea:3f88 with SMTP id ffacd0b85a97d-35e0f2599fdmr5298575f8f.1.1717407734563; Mon, 03 Jun 2024 02:42:14 -0700 (PDT) Received: from localhost.localdomain ([188.39.149.98]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04cada4sm8269532f8f.40.2024.06.03.02.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 02:42:14 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck Subject: [PATCH] ipa: rpi: Disable StatsOutputEnable control by default Date: Mon, 3 Jun 2024 10:42:09 +0100 Message-Id: <20240603094209.13921-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Set the default value of controls::rpi::StatsOutputEnable to false, disabling the functionality. This stops unnecessary copies of the statistics output ending up in the Request metdata if not needed. Signed-off-by: Naushir Patuck Reviewed-by: Kieran Bingham Reviewed-by: David Plowman --- src/ipa/rpi/common/ipa_base.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index 1d12262bda01..6fb90209aa0f 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -73,7 +73,7 @@ const ControlInfoMap::Map ipaControls{ { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) }, { &controls::FrameDurationLimits, ControlInfo(INT64_C(33333), INT64_C(120000)) }, { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) }, - { &controls::rpi::StatsOutputEnable, ControlInfo(false, true) }, + { &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) }, }; /* IPA controls handled conditionally, if the sensor is not mono */ @@ -103,8 +103,9 @@ LOG_DEFINE_CATEGORY(IPARPI) namespace ipa::RPi { IpaBase::IpaBase() - : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), stitchSwapBuffers_(false), frameCount_(0), - mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s }) + : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), statsMetadataOutput_(false), + stitchSwapBuffers_(false), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0), + firstStart_(true), flickerState_({ 0, 0s }) { }