From patchwork Mon May 20 03:50:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 20076 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DA6CDBD78E for ; Mon, 20 May 2024 03:50:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E36526347E; Mon, 20 May 2024 05:50:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=protonmail.com header.i=@protonmail.com header.b="TurtHWxA"; dkim-atps=neutral Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2016361A4D for ; Mon, 20 May 2024 05:50:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1716177025; x=1716436225; bh=FuETyjbQ0n7ycsn9XFfBiLRImrrCUmn3+QRUE8Rg0XM=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=TurtHWxAKTqsVY46FWFgPk0ES+ggV7NZU7K3VkHN8JSrcMliSJ3Ff96EVXl7gNZP7 90lGUDfRHVVL2SB36MmbY2KSAuZTWpzBQfSaOz6WrzMmPafboMhjuVHAkJ9dVVfhG8 6s9RlXNYk+gVdyfmLhSJ+nIhYZ7LkobEq5cb2XUQTXhO0zk3eMZPj6uTq5G4pN14H/ ouTEpeZlE08kFLadm3Rlvw0GCHcI6U5c6S1Fp/SRClbnN1ICm3/KmhQpuDrGkL0ED8 MPWCm+5jEYEjRrS9Bi/oKLLQTt+bZrEHMsVJ6pt7hMOtmDeI7f0E4BWGfA19s38ueh ye884xisUi0Ag== Date: Mon, 20 May 2024 03:50:22 +0000 To: libcamera-devel@lists.libcamera.org From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval Message-ID: <20240520035021.205171-1-pobrn@protonmail.com> Feedback-ID: 20568564:user:proton X-Pm-Message-ID: 446d80cc64650abe79c9bfdefa598bb852ee8ff8 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" During the refactoring in the mentioned commit the quotation marks around the word *fast* were missed. Unfortunately there was a variable named *fast* and an suitable overload for `operator[]` for things to compile fine. Fixes: c1597f98965461 ("ipa: raspberrypi: Use YamlParser to replace dependency on boost") Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Daniel Scally --- src/ipa/rpi/controller/rpi/awb.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp index abe5906e..94ecbfc2 100644 --- a/src/ipa/rpi/controller/rpi/awb.cpp +++ b/src/ipa/rpi/controller/rpi/awb.cpp @@ -161,7 +161,7 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms) bayes = false; } } - fast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */ + fast = params["fast"].get(bayes); /* default to fast for Bayesian, otherwise slow */ whitepointR = params["whitepoint_r"].get(0.0); whitepointB = params["whitepoint_b"].get(0.0); if (bayes == false)