From patchwork Wed May 8 14:51:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 20021 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2496ABDE6B for ; Wed, 8 May 2024 14:51:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3A26661A73; Wed, 8 May 2024 16:51:44 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="d/9Yp7Xv"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F72761A73 for ; Wed, 8 May 2024 16:51:42 +0200 (CEST) Received: from neptunite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 780D0B0B; Wed, 8 May 2024 16:51:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1715179899; bh=SsILR4AIOk1YmZQgwKxH2pr699nwS5GMLQSDKKWCNGc=; h=From:To:Cc:Subject:Date:From; b=d/9Yp7XvX7PD+1nmGUQ+a2NQC98XvsLWfQzpn4yZlR68U3LKvu7PMAm0JnwQWGiwS wwwHQ08oJvBQErfKiv1AQUCPJWygCSls2UyzThsGu9DGGDF8RTPWvC+4JV9AL/yeSw 7QiSOT3f1PlgnhLHIr5b3kDsG/wWmPO8Sw3s06u4= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: Paul Elder Subject: [PATCH] pipeline: rkisp1: rkisp1_source: Minor fixes for clang 17 Date: Wed, 8 May 2024 23:51:31 +0900 Message-Id: <20240508145131.1452305-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove a stray semicolon and fix the declaration of V4L2SubdeviceFormat from class to struct as it should be, to fix compilation errors on clang 17. Signed-off-by: Paul Elder --- src/libcamera/pipeline/rkisp1/rkisp1_source.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_source.h b/src/libcamera/pipeline/rkisp1/rkisp1_source.h index 5a49e9d3..67bc287f 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1_source.h +++ b/src/libcamera/pipeline/rkisp1/rkisp1_source.h @@ -24,7 +24,7 @@ class DelayedControls; class MediaEntity; class SensorConfiguration; class V4L2Subdevice; -class V4L2SubdeviceFormat; +struct V4L2SubdeviceFormat; class RkISP1Source { @@ -35,7 +35,7 @@ public: int init(); std::unique_ptr initDelayedControls(); - bool isTPG() const { return !!tpg_; }; + bool isTPG() const { return !!tpg_; } const std::string &model() const { return model_; } const std::string &id() const { return id_; }