From patchwork Fri Apr 12 14:43:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 19868 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B953CBE08B for ; Fri, 12 Apr 2024 14:43:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EF51C61BAE; Fri, 12 Apr 2024 16:43:44 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pwTX3aqb"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 37B1461BAE for ; Fri, 12 Apr 2024 16:43:43 +0200 (CEST) Received: from pendragon.ideasonboard.com (ip-185-104-138-69.ptr.icomera.net [185.104.138.69]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 06C1DA12; Fri, 12 Apr 2024 16:42:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712932979; bh=R2jwGjx2Rw1ClpxCMsu3y/JnbuksznlAUB2U0QtUJjA=; h=From:To:Cc:Subject:Date:From; b=pwTX3aqbxmZprZaYbP39dUZ/LRLreDUnuR7xMnDYgbfjrZP/znjYM6lE15+eAXVxE wu/DPrMVGdl5JOmhIphSgGKnNUwOmCzlD3RMQASpc3ZN3RC2SQZmc5MDyrwhX+TrVV eVoaFGnz9FXt3A/kwXaT+1wFACNSMOSPZwm9PQrE= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Cc: Paul Elder , Stefan Klug Subject: [PATCH v2] utils: ipc: Fix async main interface functions with no parameters Date: Fri, 12 Apr 2024 17:43:31 +0300 Message-ID: <20240412144331.29858-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Paul Elder If an async main interface function is defined with no parameters, there would be a compilation error complaining about an extra comma. Fix this. Signed-off-by: Paul Elder Reviewed-by: Stefan Klug Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 9dc601cf7a689fe6eef23189edf0c8a9c38dcfe1 diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl index 238cf4a59435..f64c3c93bfcb 100644 --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl @@ -175,9 +175,9 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data) ); {% elif method|is_async %} ASSERT(state_ == ProxyRunning); - proxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued, + proxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued {%- for param in method|method_param_names -%} - {{param}}{{- ", " if not loop.last}} + , {{param}} {%- endfor -%} ); {%- endif %}