From patchwork Fri Apr 12 02:42:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 19863 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 26571C0DA4 for ; Fri, 12 Apr 2024 02:43:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2025563352; Fri, 12 Apr 2024 04:43:10 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TmgRqLFz"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4587A61B4F for ; Fri, 12 Apr 2024 04:43:08 +0200 (CEST) Received: from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EAFA8E1; Fri, 12 Apr 2024 04:42:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712889744; bh=XxHrqYpM8iqieX4XMNSotwk6X//ndiqBYgx+g9F7Qwo=; h=From:To:Cc:Subject:Date:From; b=TmgRqLFzIjFtroiMeElaWNDqwWnneP3FjgolPKnvNp2hz5+8TzhSlV5ts8zzDLkQ9 r69dNPFj6U8sr2ZODffNF8ugD5l3kahT6De/EcSmNUAY0Xj3DPW9ZwspXIFhb+bmCq rFkZ1lRhwIeqmB1DdzXsX+m1twRd79JawAdcIwME= From: Paul Elder To: libcamera-devel@lists.libcamera.org Cc: laurent.pinchart@ideasonboard.com, Paul Elder Subject: [PATCH] utils: ipc: Fix async main interface functions with no parameters Date: Fri, 12 Apr 2024 11:42:56 +0900 Message-Id: <20240412024256.651465-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" If an async main interface function is defined with no parameters, there would be a compilation error complaining about an extra comma. Fix this. Signed-off-by: Paul Elder Reviewed-by: Umang Jain Reviewed-by: Stefan Klug Reviewed-by: Laurent Pinchart --- .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl index 238cf4a5..01fe9c51 100644 --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl @@ -175,7 +175,8 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data) ); {% elif method|is_async %} ASSERT(state_ == ProxyRunning); - proxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued, + proxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued + {%- if method|method_param_names|length > 0 -%}, {% endif -%} {%- for param in method|method_param_names -%} {{param}}{{- ", " if not loop.last}} {%- endfor -%}