From patchwork Tue Feb 27 02:13:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fang Hui X-Patchwork-Id: 19544 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 698A0BD160 for ; Tue, 27 Feb 2024 02:45:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id ADB556285F; Tue, 27 Feb 2024 03:45:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="jLdT5FAl"; dkim-atps=neutral Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20601.outbound.protection.outlook.com [IPv6:2a01:111:f403:2608::601]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C77661C94 for ; Tue, 27 Feb 2024 03:45:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IY1sKxaTBGW7qLLGacx7KBTRC/YUL87XvSX86XZDLZR7BX0OmNRas0lJf+uLvkAVCgxmPYMRL+Y/0pzqbcxGTK8y+9mWb2YjnK9P0nY1mirVtjLt2vlqnFODtvOlR7Ium93nqc90zD3qHYRTKhK10GDGzuhNXFn8lNpoMFrsSL4MDgIMIwS5KcsPj0QYDUgMjjVoGgRijZWkxtBGX2VZLOhii/mfeqA6fSTRSMj2W/69q/TmEFzZEV+c4fmeAA7tKYV/V+ApC5dkoqREsHVg0WIyig6FX4eyy5+QqI1Puywgp/4wHbPxffwk0J5HDbq8uc4K5s6BBdEC6sklCb2Lpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YHyf8IjyyS8nTRyDY5Jcv4oMnwsxQqTYN5knfifxHjA=; b=XyHi6V2/dFuJhqKWCJSAWa2h7DLz6FofeEdF8264wr0QjhJB/YrrkwxTmz0X8BZadHUwtTruI8a9YaSEbxLB+bp4ebgFOSDiceOUfVZFx5Sjw1gRMAPajzbtPAMhHRXzBD7fnAY8X6g0VrGu0P6KOnXyLqZDo7IEsK6LSRZZmbg+zZDOn/GlCU+CT3e9mcDJB5EBVFh6XHUzCVSXLMQVAYN5+f38Kx83e5pZOczZ2iw7Q1ANwcWuxSPiXJ5FrM+e62n2z8Ly1NEsqXv+2lzLMOEYl3sB8crB8mVnA/OYGMc7bPK/Wsgj6OICg3/J4ek0ABlr5BbYyPN9tBJyliw2ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YHyf8IjyyS8nTRyDY5Jcv4oMnwsxQqTYN5knfifxHjA=; b=jLdT5FAlyWeLo/m2+O6udinjFvCKmD/MOsLo1NjfDgZpUeENjIbVbIXC+ZMQb9FSXW2PuV4GSXtV1XLF2aBR0vq5yPoo7F+cAJg3+RRd7Ppcdlgqc18zqLUyvMAjx/NpJDXW0KkVNlhiZVcGgKlRqIbTZwDfYsQ4D3vYpHFPwxY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9284.eurprd04.prod.outlook.com (2603:10a6:10:36c::8) by PA4PR04MB7807.eurprd04.prod.outlook.com (2603:10a6:102:b8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Tue, 27 Feb 2024 02:45:24 +0000 Received: from DB9PR04MB9284.eurprd04.prod.outlook.com ([fe80::7d9b:76bb:b6c6:7f69]) by DB9PR04MB9284.eurprd04.prod.outlook.com ([fe80::7d9b:76bb:b6c6:7f69%6]) with mapi id 15.20.7316.035; Tue, 27 Feb 2024 02:45:24 +0000 From: Fang Hui To: libcamera-devel@lists.libcamera.org Subject: [PATCH] android: camera_device: Save capture settings unconditionally Date: Tue, 27 Feb 2024 10:13:20 +0800 Message-Id: <20240227021320.3443016-1-hui.fang@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SG2PR04CA0166.apcprd04.prod.outlook.com (2603:1096:4::28) To DB9PR04MB9284.eurprd04.prod.outlook.com (2603:10a6:10:36c::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9284:EE_|PA4PR04MB7807:EE_ X-MS-Office365-Filtering-Correlation-Id: c7d50899-4412-4eb7-c3d7-08dc373e25b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I51qp8HKCOi9d4Ve/sE2lkCtgru8npm/4l7FAEJ2pqN5hTC/76TUp3qW5vcyFzr2oU8LcmdcsPcjUSFGY8OPdSnmiTCA6It4UbgO0bb6TkEdB+OUtqfu1paApoL4/k4Tby/B4HdAevZ6KlColrmtkDavQNWQhTlEdgnxnuA3JmaOKDaE/RvCLlHrUrcgeF68PN5S1UQrGKdqOSP4d2nMD7UQEgWeqoNMqnjVaVSihpf0R1El60ip6+pQn/js/iENn19MybFwJmHxdvoJ5jOL3j5Z++rr/4t0SqN+LydQDxrFdopZD1bkutYS4q0dEjuv8/OsApVAgiwKzVzITJatQYAnkMCQEHnau/gso54Asd1r/pJzISeEEbAMWI4qllXncyR2t11nwEbNwFhxVYHdG5nAk5+D1z41uD/0zgwOPHJ8yvKYE6NW7ZDan0AQVED42qpcNiBL1tgtlasSPRxdMX0ABTrvUHIyEs6oz2IY0l8FaJwxsoxDtZ6BhHcDPpZhXVs4woznZV+3nADI/gLs9QWOGMdYXRzRtMHbq6du6ywBNtf42e/1bySjWFwtYIzrtGRLfNVxB0Da8YZme8Knbv9e17DgBtr1hJtvgJbNG5cM10GgM/hyzPQ1s6Kj1Xi1cTNmeEGKOxTb1bt9ScKhw7mTrbGfvA2WM8ysZtxmdvqpbjeQ6kGlYiAG5jA1E4STUzYFHY1Qyyq2HgWD0uK57A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR04MB9284.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38350700005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bLKPmyU9xqgrJjbNt8BDaciac7cl9lbJhU3fePnhHJfQLOPOUwK04kasnKxUNTX0NQnUISI+7N9YvjtzjuSjFGup4gmye1N2hpJyYsdevyMKIvTS+aHYC2NWlzuTg2tJcAfFZN+Xas3EqyDHbnD4/8OCknc2VHove3RQVOHyw/VhnDYwmenfczlC70oeD5y9rBArb4Y19xl0FNMPqs95DBCM6z0iKuwc0LZvOs4A0QsevSgoCa/h9xR+qnHF31Xhz7G6KeVp683ourpFXHuxpVuwXhhP7kCAsNU9lZ/2TNtrDuX7AoKrX6/cSpZir8ZsXdlmm12DLaL5acbC4HONzLWXzjPKoWekKBo9IrspF312HLqkmeWZ6OS648OThRKTcW7DzNadw6VKCNBYICKTKqpnPlJ56B6dWoitmoZhqcQFOoprS6BOnQcGrJUSBlNfXkdHl7qT1i/5mrqXZCL+aBSyh8ZPdBkFKIGq0/XIa62bxPI4Zb/JuZtcQDqvjDTEoNaTwGVBTqnFCdLJZCkaUeK57xS6BXHSzbDcMJss81RlmRi295SLxNqb+IjZmxg3iUu2DRvOF4zamjSClfBn0aqyOVIP5G4FR9tv1tEn/7U69R89linoiSAaOXqYIjJSpiP2VWn6varztrspQI6Wlqx9N86Bg15cUkGw2U8ZsPqqgMYy0oJVIipraTsVKkRoPvYPtwPVusVraVWam0Y1w6FwDBepZzSxcNnVGqGypNTVEt9AW0S9N7HjYsEXYqvsXEjVnqeOdCEF8pRyVM59FvoE3mSmEZKPWgm3trOZ0wSzCxOfhyhD/8xdiEIDbstyWy3lExSB5cCMmNkGPjo5fqzSaFV9yPy6DtClA2xPacuNgWVSNPhbEXKOaOBagLFgO4zOo0+RjRfaq8M1AyiVXUI34TFRqmR8096ki6Yy/dgp8T6WjWU12N3mX5boTmz6j7QYM2Zla+bRc565qrUTpwuKADzY8plO3rqbydEzxK2vhjhQnxOAobJMh2BfaUPt9/+vmm6Q2PEAsrqRxr84yJ3o31bh48GY1RDYRo89sFS19NAQ4tjTh7SP7hUd9UFPB+BvUS6v51ERA+Favf1TI7irl8RHXDRF67Q581pc3J0gCPbcPKELHtDXBiPnv7jrihAFhjAgTDkOqCzWT81fDkerkYFFGwfxN/FtNkYiVUhqVuNNSEy2qo33eYsnDbeJ70m3Zq7I5Y9DKku1KKpEbnFEU7J64lcGPPlYEe43GISHzx+auu3tpFLTLejJzFiO5MvWgB7aGz2iyvHcv65vPpm0x+KyfWEMnnpAQ6hOl+gg+WTlM9dPCPsuvJmo43BzLNgULPVKIXZ0LTTP2QKr9rh7EHCLbg3K6cv+UykQ/Yh1zmy8iQGhJYV0lXyZlvoCaR7vEeEtb/TNLjs4iuQ0zHk8QSwLWNYuSXbf4tYsl9KBd/KQEJkdiLIomHgHKiM26bfJdkcL7zDgUEiq2wSWrt4rseHG7g7rVxxJWkobO60KO6msv06K4bwH2bdAMlO0Q4b2u+MwFefOUSt8rZVQJJp2SsXDXtQ18ol4zc8gREJHBPas1gIMpNNRX4Xupb3f X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7d50899-4412-4eb7-c3d7-08dc373e25b1 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9284.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 02:45:24.2509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 33x8ImpMAte7uKtULuD34imLrJeMOaTyXFkzApol/VTuC47YA8YG+Rf9zz6Abx8TRanaiqKQiuKJnKuQ0xZh/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7807 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: biomifang118@gmail.com Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" If not, it will be deferred to the next frame, as there's a bug assigned to this issue https://bugs.libcamera.org/show_bug.cgi?id=210 Signed-off-by: Fang Hui --- src/android/camera_device.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 25cedd44..d45ed1a5 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -952,8 +952,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques */ if (camera3Request->settings) lastSettings_ = camera3Request->settings; - else - descriptor->settings_ = lastSettings_; + + descriptor->settings_ = lastSettings_; LOG(HAL, Debug) << "Queueing request " << descriptor->request_->cookie() << " with " << descriptor->buffers_.size() << " streams";