From patchwork Fri Jun 2 06:09:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 18680 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2EA06C3200 for ; Fri, 2 Jun 2023 06:09:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id ECD6562728; Fri, 2 Jun 2023 08:09:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1685686190; bh=D1tQQDmPtFTJOpwtlzuYC1WQ/MmCXxPnJf/7lgw26I4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=lu3d4TIOHzwGgS1Zcl9uRpIlzqOOnA6Y/NdPkBAyTIe82zRTEB2yupChaSWNUPbNE /a0HRl8trkodsJYeJA59aP6OXvYoVIvzmNmTMDdzitsJGIVyCq6GOnoYr8NP1LbrWf VvyFlmWuKobIVhqcVZHt85hokk3dthcxiIowJ0odMJz9wYxyuZl9YaGHVVX7+emqmm 7Q3/7KbyUUR9kfgwb20MNeYvEoqYtbRQDyP55NxUBR1ubO0OV6Ob4Kc/qAVNrkd8bD E2V0d4M/5w/xm0a+ItkTjcVvfpINHx18IaA8xu7W++5666caEJfIcSIvzFmYE+aOa8 ZEnSH89aEkw7w== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3790F61EA5 for ; Fri, 2 Jun 2023 08:09:49 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ab5ms4P6"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (om126156168104.26.openmobile.ne.jp [126.156.168.104]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C3EE6A39; Fri, 2 Jun 2023 08:09:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1685686166; bh=D1tQQDmPtFTJOpwtlzuYC1WQ/MmCXxPnJf/7lgw26I4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ab5ms4P6l+zd2lUx2j8DRzX0okzbpj6isZ6I46Ob0zg82Py2sxR7KcUdmqXg1/Qfl tS9CGKYl4X99fYq/F0Im0dC9Q/aAAgW0AWfIC/IE/z1jq1fe0cqSOoDW+m8ZE+rH60 dXeip+plw4KRNT244UpanioYmAt7iJtYKnq+TSoQ= To: libcamera-devel@lists.libcamera.org Date: Fri, 2 Jun 2023 09:09:47 +0300 Message-Id: <20230602060947.16309-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230602060916.GP22609@pendragon.ideasonboard.com> References: <20230602060916.GP22609@pendragon.ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2] libcamera: controls: Define a default lens position behaviour X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Naushir Patuck Update the AfMode control description to explicitly define a startup/default behaviour. On startup, the camera will move the lens to the position given by the default value of the LensPosition control if operating in manual focus mode. Typically this would be the hyperfocal position of the lens. Signed-off-by: Naushir Patuck --- src/libcamera/control_ids.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 76d41f5f2a5a..985f792a53c1 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -408,7 +408,15 @@ controls: LensPosition control. In this mode the AfState will always report AfStateIdle. - - name: AfModeAuto + + If the camera is started is AfModeManual, it will move the focus + lens to the position specified by the LensPosition control. + + This mode is the recommended default value for the AfMode control. + External cameras (as reported by the Location property set to + CameraLocationExternal) may use a different default value. + + name: AfModeAuto value: 1 description: | The AF algorithm is in auto mode. This means that the algorithm