From patchwork Fri Jun 2 05:43:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 18679 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C6D63C31E9 for ; Fri, 2 Jun 2023 05:43:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 331BF62728; Fri, 2 Jun 2023 07:43:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1685684607; bh=GNiHmJFUxicPlg5A1HpZ6bzhIdh1F+8vkcva9mxkQJk=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=VVHS8aIBV/4gY4ovckGXSfNRJkEGt7jCZvPGWrt4T+VLRE2SopSyOgV/jCZjtSx7p sdufl1fhdKHYHRBbE1vO8WgnnNKrofXJ0eg4X1Xzf/IpAjf/RlmPt2xSLecf1jASJU mbYl/O2qUz+cX5zb5gCai/hTPLuZ+6A9uSeiXA3yL4EwU4uDVDW2ogaJKXv4dW9HgF WJAZtVOnzYzSiBE3t44ooFTkiBQguz038I+enjrVBJZ31otmCLjr2M8Rf/AYFousY+ KzBxqhpe1qcFq8qyhxC3MIN08fsthqT9GgYpR9V4XAp4L2imqvjTth70DU+is5hM9O JMgims+MasWsw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BDB2161EA5 for ; Fri, 2 Jun 2023 07:43:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="koghNoTg"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (om126156168104.26.openmobile.ne.jp [126.156.168.104]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D03EB2A; Fri, 2 Jun 2023 07:43:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1685684583; bh=GNiHmJFUxicPlg5A1HpZ6bzhIdh1F+8vkcva9mxkQJk=; h=From:To:Cc:Subject:Date:From; b=koghNoTgTBsz0oySvbxXAnswtIH6NnDQwigN9q5FFqRDasPsqww9OEH+R2to7WPFw a7qFr7/H5FV3Oi3/pAVNZ6B9XahYam9lAJ/ESD04C8Yp1jUVuanHWFS+qiKvafLu0s bDgicliaIVQZLunnvIjrPNdL6CzHusXRCLBgC0G8= To: libcamera-devel@lists.libcamera.org Date: Fri, 2 Jun 2023 08:43:22 +0300 Message-Id: <20230602054322.14815-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: controls: Drop reference to IPA in controls documentation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The controls relates to the public API, which doesn't expose IPA modules as they are internal to libcamera. Replace the mention of "IPA" in the controls documentation. While at it, fix a small text reflow issue. Signed-off-by: Laurent Pinchart Reviewed-by: Naushir Patuck --- David, there's another mention of "IPA" in the FocusFoM control documentation. I'm not sure how to best address that one, as it isn't totally clear to me what you wanted to convey to the user. Could you please give it a look ? --- src/libcamera/control_ids.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index f6dbfd6c0bf0..5aa656cb5032 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -333,8 +333,8 @@ controls: - FrameDurationLimits: type: int64_t description: | - The minimum and maximum (in that order) frame duration, - expressed in microseconds. + The minimum and maximum (in that order) frame duration, expressed in + microseconds. When provided by applications, the control specifies the sensor frame duration interval the pipeline has to use. This limits the largest @@ -343,7 +343,7 @@ controls: the sensor will not be able to raise the exposure time above 33ms. A fixed frame duration is achieved by setting the minimum and maximum values to be the same. Setting both values to 0 reverts to using the - IPA provided defaults. + camera defaults. The maximum frame duration provides the absolute limit to the shutter speed computed by the AE algorithm and it overrides any exposure mode