From patchwork Tue Dec 20 07:05:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Harvey Yang X-Patchwork-Id: 18040 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5158DC328F for ; Tue, 20 Dec 2022 07:05:36 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 01DE7633A2; Tue, 20 Dec 2022 08:05:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1671519936; bh=BLCfMln0vNfn48BkBrpzSIzmeaB4e04ikCJ9TfOkNAE=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=zyIU/IpeDC0miG8HKPaOPX+6YOdWdxMdKdNS7Du5myhDQ6kxYciXivBLTYFQUMTON fsvRSP7VMPiNrr3du+RtTLuw8/kcj5F/DQ24jk8hGoysTPmQa9gOuU7iOppAv+zvrK GZOr85XM2eZeLOAQG9M+rZlXoxPB8Zt9U6z9zNWpSME4jNVJ4Azxd4dDYgp8/LljFu P6rp+EeOYebQunmVWDF06gqZmDFHjemTAb6+vE1er+ie3N6Gwj9hvQBpiUAFukYCBc nT9aRtjvfprTkPbdrpQYgXyk/7uP55MmkGRMCFkSdxnM5UHF/77IxCDYz8Y9U+zlCy JxFmUE1Y7CaiQ== Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BBF4E6339B for ; Tue, 20 Dec 2022 08:05:33 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ZrGZcWYm"; dkim-atps=neutral Received: by mail-pf1-x434.google.com with SMTP id 130so7885764pfu.8 for ; Mon, 19 Dec 2022 23:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wSbhTdYD2HAGlL53bDgBoUXHDphpj2+3iTNN6b3M2vA=; b=ZrGZcWYm0xyViFt1VMA7SWAZUJadDPVQUyFdCXRgOoTW4RkvgeSZEa92u52wlDQ0hj ks1pIdQcRZ5jrKvci2AZ7ybb93+LauLcp0EvL6VjwHS5j+ppC755ItN8ON/urCMto4Tq r8tm/uYiyUC9Py5evrGNnYyKfINnZQoCtwYyQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wSbhTdYD2HAGlL53bDgBoUXHDphpj2+3iTNN6b3M2vA=; b=E38a1yiOwdf1sciJ5Vmf3KO/lIewGSmpJ4fBUHFam5RTFdbIoaUFLDxRVkrvXfE2PJ JlBjjC25TpfaxjzOx79plM5cYFCjsC/rTb3GBPRRbwMeE65uQ4uIC0ZP9vFzUzpkyX3G wJe1fMq7HZ/fVbz7cdtUSrUqBf7qcF6sStfjlZlqBe6mjqfIsLAM42lom2G41lRZk0fF ByRIMWh1pMSMe6waroVRjZKwV4HAtcvpmVBRfCXvZmO95qZZqts1rdW6aYfP2+crTVnK Gp/hu2ATJiCXO+I8XQ7u0pRDQLuRXWFpS8BCq1OJ/VpNQNEc6vqX91G2zXXy03im4Bq+ ndyw== X-Gm-Message-State: AFqh2kopC0RA1T8y9fMXWua2Rl4AIXSpqmaYtcIIe2xzIi9pCXIgSyyE IYzwJG4+IQhwcv5fbG8qxHKk/BW2aQn9Y1MS X-Google-Smtp-Source: AMrXdXtp6HzSwkFFB+jYDZE3u+AU9F5IXGBmu8aJxi7bqfGmgl9A8GTyUQ9jIMIPqwAMVf9IPcIg6w== X-Received: by 2002:a62:1cd6:0:b0:56c:318a:f83b with SMTP id c205-20020a621cd6000000b0056c318af83bmr15042688pfc.13.1671519931893; Mon, 19 Dec 2022 23:05:31 -0800 (PST) Received: from chenghaoyang-low.c.googlers.com.com (46.165.189.35.bc.googleusercontent.com. [35.189.165.46]) by smtp.gmail.com with ESMTPSA id b4-20020a62cf04000000b005764c8f8f15sm7858950pfg.73.2022.12.19.23.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 23:05:31 -0800 (PST) X-Google-Original-From: Harvey Yang To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Dec 2022 07:05:23 +0000 Message-Id: <20221220070523.3212844-2-chenghaoyang@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog In-Reply-To: <20221220070523.3212844-1-chenghaoyang@google.com> References: <20221220070523.3212844-1-chenghaoyang@google.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 1/1] Use tracing with perfetto in ChromeOS X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harvey Yang via libcamera-devel From: Harvey Yang Reply-To: Harvey Yang Cc: Harvey Yang , Harvey Yang Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As ChromeOS is using perfetto (project named as CrOSetto). When ChromeOS uses libcamera, it should use perfetto to collect traces instead of lttng. Signed-off-by: Harvey Yang --- Documentation/guides/tracing.rst | 125 ++++++++++++++---- include/libcamera/internal/tracepoints.h.in | 38 +++++- .../internal/tracepoints/meson.build | 25 ++-- .../internal/tracepoints/pipeline.perfetto | 10 ++ .../internal/tracepoints/request.perfetto | 30 +++++ meson.build | 7 +- src/android/cros/camera3_hal.cpp | 5 + src/android/cros/meson.build | 1 + src/libcamera/meson.build | 14 +- src/libcamera/perfetto/meson.build | 6 + src/libcamera/perfetto/pipeline_perfetto.cpp | 24 ++++ src/libcamera/perfetto/request_perfetto.cpp | 73 ++++++++++ src/libcamera/tracepoints.cpp | 11 ++ 13 files changed, 325 insertions(+), 44 deletions(-) create mode 100644 include/libcamera/internal/tracepoints/pipeline.perfetto create mode 100644 include/libcamera/internal/tracepoints/request.perfetto create mode 100644 src/libcamera/perfetto/meson.build create mode 100644 src/libcamera/perfetto/pipeline_perfetto.cpp create mode 100644 src/libcamera/perfetto/request_perfetto.cpp diff --git a/Documentation/guides/tracing.rst b/Documentation/guides/tracing.rst index ae960d85..bd5b3453 100644 --- a/Documentation/guides/tracing.rst +++ b/Documentation/guides/tracing.rst @@ -16,33 +16,50 @@ at periodic points in time. This can be done with other tools such as callgrind, perf, gprof, etc., without modification to the application, and is out of scope for this guide. +Library: Perfetto vs lttng-ust +------------------------------ + +To integrate with CrOS tracing infrastructure, which uses perfetto (or called +CrOSetto in CrOS), we implement the tracepoint macros (will be described below) +with two different libraries: CrOS with perfetto, and the rest with lttng-ust. + Compiling --------- -To compile libcamera with tracing support, it must be enabled through the -meson ``tracing`` option. It depends on the lttng-ust library (available in the -``liblttng-ust-dev`` package for Debian-based distributions). -By default the tracing option in meson is set to ``auto``, so if -liblttng is detected, it will be enabled by default. Conversely, if the option -is set to disabled, then libcamera will be compiled without tracing support. +To compile libcamera with tracing support in CrOS, it must be enabled through +the meson ``tracing`` option. In CrOS, it depends on the perfetto library, +which is by default available in CrOS; In the rest, it depends on the lttng-ust +library (available in the ``liblttng-ust-dev`` package for Debian-based +distributions). +By default the tracing option in meson is set to ``auto``, so if the library is +detected, it will be enabled by default. Conversely, if the option is set to +disabled, then libcamera will be compiled without tracing support. Defining tracepoints -------------------- libcamera already contains a set of tracepoints. To define additional -tracepoints, create a file -``include/libcamera/internal/tracepoints/{file}.tp``, where ``file`` is a -reasonable name related to the category of tracepoints that you wish to -define. For example, the tracepoints file for the Request object is called -``request.tp``. An entry for this file must be added in -``include/libcamera/internal/tracepoints/meson.build``. - -In this tracepoints file, define your tracepoints `as mandated by lttng +tracepoints, create two files ``{file}.tp`` and ``{file}.perfetto``, for lttng +and perfetto respectively, under ``include/libcamera/internal/tracepoints/``, +and the perfetto implementation file ``src/libcamera/{file}_perfetto.cpp``, +where ``file`` is a reasonable name related to the category of tracepoints that +you wish to define. For example, the tracepoints files for the Request object is +called ``request.tp`` and ``request.perfetto``. Entries for the files must be +added in ``include/libcamera/internal/tracepoints/meson.build``. + +In the perfetto tracepoints files, declare the tracepoint functions in +``{file}.perfetto``, and define them in ``{file}_perfetto.cpp``, `as mandated +by perfetto `_. +Currently the only enabled perfetto::Category is ``libcamera``. If you intend to +use another category, remember to define it in +``include/libcamera/internal/tracepoints.h.in``, and enable it when collecting +traces. + +In the lttng tracepoints file, define your tracepoints `as mandated by lttng `_. The header boilerplate must *not* be included (as it will conflict with the rest of our infrastructure), and only the tracepoint definitions (with the ``TRACEPOINT_*`` macros) should be included. - All tracepoint providers shall be ``libcamera``. According to lttng, the tracepoint provider should be per-project; this is the rationale for this decision. To group tracepoint events, we recommend using @@ -68,9 +85,9 @@ Then to use the tracepoint: ``LIBCAMERA_TRACEPOINT({tracepoint_event}, args...)`` -This macro must be used, as opposed to lttng's macros directly, because -lttng is an optional dependency of libcamera, so the code must compile and run -even when lttng is not present or when tracing is disabled. +This macro must be used, as opposed to perfetto's or lttng's macros directly, +because tracing support is optional of libcamera, so the code must compile and +run even when perfetto or lttng are not present or when tracing is disabled. The tracepoint provider name, as declared in the tracepoint definition, is not included in the parameters of the tracepoint. @@ -87,21 +104,75 @@ respectively. These are the tracepoints that our sample analysis script (see "Analyzing a trace") scans for when computing statistics on IPA call time. Using tracepoints (from an application) ---------------------------------------- +--------------------------------------------- As applications are not part of libcamera, but rather users of libcamera, applications should seek their own tracing mechanisms. For ease of tracing the application alongside tracing libcamera, it is recommended to also -`use lttng `_. +`use lttng `_, +or `use perfetto `_. Using tracepoints (from closed-source IPA) ------------------------------------------- +------------------------------------------------ + +Similar to applications, closed-source IPAs can simply use perfetto or lttng +on their own, or any other tracing mechanism if desired. + +Collecting a perfetto trace +--------------------------- + +A trace can be collected with the following steps: + +1. Start `traced` if it hasn't been started. +.. code-block:: bash + + start traced + +2. Start a consumer that includes “track_event” data source in the trace + config, and “libcamera” category. +.. code-block:: bash + + perfetto -c - --txt -o /tmp/perfetto-trace \ + <`_ to +visualize the trace. -Similar to applications, closed-source IPAs can simply use lttng on their own, -or any other tracing mechanism if desired. +In other words, upload the trace to `Perfetto UI `_, +where you can check the timeline of tracepoints on each process/thread. You can +also run SQL queries to do analysis. -Collecting a trace ------------------- +Collecting an lttng trace +------------------------ A trace can be collected fairly simply from lttng: @@ -123,8 +194,8 @@ viewed by: ``lttng view -t $PATH_TO_TRACE``, where ``$PATH_TO_TRACE`` is the path that was printed when the session was created. This is the same path that is used when analyzing traces programatically, as described in the next section. -Analyzing a trace ------------------ +Analyzing a lttng trace +----------------------- As mentioned above, while an lttng tracing session exists and the trace is not running, the trace output can be viewed as text by ``lttng view``. diff --git a/include/libcamera/internal/tracepoints.h.in b/include/libcamera/internal/tracepoints.h.in index d0fc1365..b6c4abea 100644 --- a/include/libcamera/internal/tracepoints.h.in +++ b/include/libcamera/internal/tracepoints.h.in @@ -9,7 +9,24 @@ #ifndef __LIBCAMERA_INTERNAL_TRACEPOINTS_H__ #define __LIBCAMERA_INTERNAL_TRACEPOINTS_H__ -#if HAVE_TRACING +#if HAVE_PERFETTO + +#include + +PERFETTO_DEFINE_CATEGORIES( + perfetto::Category("libcamera") + .SetDescription("Events from libcamera")); + +#define LIBCAMERA_TRACEPOINT(t_name, ...) \ +LIBCAMERA_TRACE_EVENT_##t_name(__VA_ARGS__) + +#define LIBCAMERA_TRACEPOINT_IPA_BEGIN(pipe, func) \ +LIBCAMERA_TRACE_EVENT_ipa_call_begin(#pipe, #func) + +#define LIBCAMERA_TRACEPOINT_IPA_END(pipe, func) \ +LIBCAMERA_TRACE_EVENT_ipa_call_end(#pipe, #func) + +#elif HAVE_LTTNG /* !HAVE_PERFETTO */ #define LIBCAMERA_TRACEPOINT(...) tracepoint(libcamera, __VA_ARGS__) #define LIBCAMERA_TRACEPOINT_IPA_BEGIN(pipe, func) \ @@ -18,7 +35,7 @@ tracepoint(libcamera, ipa_call_begin, #pipe, #func) #define LIBCAMERA_TRACEPOINT_IPA_END(pipe, func) \ tracepoint(libcamera, ipa_call_end, #pipe, #func) -#else +#else /* !HAVE_PERFETTO && !HAVE_LTTNG */ namespace { @@ -34,12 +51,17 @@ inline void unused([[maybe_unused]] Args&& ...args) #define LIBCAMERA_TRACEPOINT_IPA_BEGIN(pipe, func) #define LIBCAMERA_TRACEPOINT_IPA_END(pipe, func) -#endif /* HAVE_TRACING */ +#endif /* HAVE_PERFETTO */ #endif /* __LIBCAMERA_INTERNAL_TRACEPOINTS_H__ */ +#if HAVE_PERFETTO || HAVE_LTTNG + +#if HAVE_PERFETTO -#if HAVE_TRACING +#include + +#else /* HAVE_LTTNG */ #undef TRACEPOINT_PROVIDER #define TRACEPOINT_PROVIDER libcamera @@ -47,15 +69,21 @@ inline void unused([[maybe_unused]] Args&& ...args) #undef TRACEPOINT_INCLUDE #define TRACEPOINT_INCLUDE "{{path}}" +#endif /* HAVE_PERFETTO */ + #if !defined(INCLUDE_LIBCAMERA_INTERNAL_TRACEPOINTS_TP_H) || defined(TRACEPOINT_HEADER_MULTI_READ) #define INCLUDE_LIBCAMERA_INTERNAL_TRACEPOINTS_TP_H +#if HAVE_LTTNG #include +#endif /* HAVE_LTTNG */ {{source}} #endif /* INCLUDE_LIBCAMERA_INTERNAL_TRACEPOINTS_TP_H */ +#if HAVE_LTTNG #include +#endif /* HAVE_LTTNG */ -#endif /* HAVE_TRACING */ +#endif /* HAVE_PERFETTO || HAVE_LTTNG */ diff --git a/include/libcamera/internal/tracepoints/meson.build b/include/libcamera/internal/tracepoints/meson.build index d9b2fca5..ff5aece6 100644 --- a/include/libcamera/internal/tracepoints/meson.build +++ b/include/libcamera/internal/tracepoints/meson.build @@ -1,12 +1,19 @@ # SPDX-License-Identifier: CC0-1.0 -# enum files must go first -tracepoint_files = files([ - 'buffer_enums.tp', - 'request_enums.tp', -]) +if get_option('android').enabled() and get_option('android_platform') == 'cros' + tracepoint_files = files([ + 'pipeline.perfetto', + 'request.perfetto', + ]) +else + # enum files must go first + tracepoint_files = files([ + 'buffer_enums.tp', + 'request_enums.tp', + ]) -tracepoint_files += files([ - 'pipeline.tp', - 'request.tp', -]) + tracepoint_files += files([ + 'pipeline.tp', + 'request.tp', + ]) +endif diff --git a/include/libcamera/internal/tracepoints/pipeline.perfetto b/include/libcamera/internal/tracepoints/pipeline.perfetto new file mode 100644 index 00000000..5f45295e --- /dev/null +++ b/include/libcamera/internal/tracepoints/pipeline.perfetto @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2022, Google Inc. + * + * pipeline.tp - Tracepoints for pipelines + */ + +void LIBCAMERA_TRACE_EVENT_ipa_call_begin(const char *pipe, const char *func); + +void LIBCAMERA_TRACE_EVENT_ipa_call_end(const char *pipe, const char *func); diff --git a/include/libcamera/internal/tracepoints/request.perfetto b/include/libcamera/internal/tracepoints/request.perfetto new file mode 100644 index 00000000..fd6a42a4 --- /dev/null +++ b/include/libcamera/internal/tracepoints/request.perfetto @@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2022, Google Inc. + * + * request.tp - Tracepoints for the request object + */ + +#include + +#include + +void LIBCAMERA_TRACE_EVENT_request(libcamera::Request *req); + +void LIBCAMERA_TRACE_EVENT_request_construct(libcamera::Request *req); + +void LIBCAMERA_TRACE_EVENT_request_destroy(libcamera::Request *req); + +void LIBCAMERA_TRACE_EVENT_request_reuse(libcamera::Request *req); + +void LIBCAMERA_TRACE_EVENT_request_queue(libcamera::Request *req); + +void LIBCAMERA_TRACE_EVENT_request_device_queue(libcamera::Request *req); + +void LIBCAMERA_TRACE_EVENT_request_complete(libcamera::Request::Private *req); + +void LIBCAMERA_TRACE_EVENT_request_cancel(libcamera::Request::Private *req); + +void LIBCAMERA_TRACE_EVENT_request_complete_buffer( + libcamera::Request::Private *req, + libcamera::FrameBuffer * buf); diff --git a/meson.build b/meson.build index e4c0be16..79514b5b 100644 --- a/meson.build +++ b/meson.build @@ -156,7 +156,11 @@ libcamera_includes = include_directories('include') py_modules = [] # Libraries used by multiple components -liblttng = dependency('lttng-ust', required : get_option('tracing')) +libperfetto = dependency('perfetto', required : get_option('tracing').enabled() + and get_option('android').enabled() + and get_option('android_platform') == 'cros') +liblttng = cc.find_library('lttng-ust', required : get_option('tracing').enabled() + and not libperfetto.found()) # Pipeline handlers # @@ -208,6 +212,7 @@ py_mod.find_installation('python3', modules: py_modules) summary({ 'Enabled pipelines': pipelines, 'Enabled IPA modules': enabled_ipa_modules, + 'Perfetto support': perfetto_enabled, 'Tracing support': tracing_enabled, 'Android support': android_enabled, 'GStreamer support': gst_enabled, diff --git a/src/android/cros/camera3_hal.cpp b/src/android/cros/camera3_hal.cpp index fb863b5f..2fbd7f14 100644 --- a/src/android/cros/camera3_hal.cpp +++ b/src/android/cros/camera3_hal.cpp @@ -7,10 +7,15 @@ #include +#include "libcamera/internal/tracepoints.h" #include "../camera_hal_manager.h" static void set_up([[maybe_unused]] cros::CameraMojoChannelManagerToken *token) { + perfetto::TracingInitArgs args; + args.backends |= perfetto::kSystemBackend; + perfetto::Tracing::Initialize(args); + perfetto::TrackEvent::Register(); } static void tear_down() diff --git a/src/android/cros/meson.build b/src/android/cros/meson.build index 35995dd8..68f2bd9e 100644 --- a/src/android/cros/meson.build +++ b/src/android/cros/meson.build @@ -9,5 +9,6 @@ android_hal_sources += files([ ]) android_deps += dependency('libcros_camera') +android_deps += dependency('perfetto') android_cpp_args += ['-DOS_CHROMEOS'] diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build index 0494e808..ba8bf26e 100644 --- a/src/libcamera/meson.build +++ b/src/libcamera/meson.build @@ -62,6 +62,7 @@ libthreads = dependency('threads') subdir('base') subdir('ipa') +subdir('perfetto') subdir('pipeline') subdir('proxy') @@ -89,11 +90,19 @@ if not libcrypto.found() warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated') endif -if liblttng.found() +if libperfetto.found() + perfetto_enabled = true + tracing_enabled = false + config_h.set('HAVE_PERFETTO', 1) + libcamera_sources += perfetto_sources + libcamera_sources += files(['tracepoints.cpp']) +elif liblttng.found() + perfetto_enabled = false tracing_enabled = true - config_h.set('HAVE_TRACING', 1) + config_h.set('HAVE_LTTNG', 1) libcamera_sources += files(['tracepoints.cpp']) else + perfetto_enabled = false tracing_enabled = false endif @@ -154,6 +163,7 @@ libcamera_deps = [ libcrypto, libdl, liblttng, + libperfetto, libudev, libyaml, ] diff --git a/src/libcamera/perfetto/meson.build b/src/libcamera/perfetto/meson.build new file mode 100644 index 00000000..119a1ad7 --- /dev/null +++ b/src/libcamera/perfetto/meson.build @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: CC0-1.0 + +perfetto_sources = files([ + 'pipeline_perfetto.cpp', + 'request_perfetto.cpp', +]) diff --git a/src/libcamera/perfetto/pipeline_perfetto.cpp b/src/libcamera/perfetto/pipeline_perfetto.cpp new file mode 100644 index 00000000..07b82ffd --- /dev/null +++ b/src/libcamera/perfetto/pipeline_perfetto.cpp @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2022, Google Inc. + * + * pipeline.tp - Tracepoints for pipelines + */ + +#include "libcamera/internal/tracepoints.h" + +void LIBCAMERA_TRACE_EVENT_ipa_call_begin(const char *pipe, const char *func) +{ + // TODO: Consider TRACE_EVENT_BEGIN + TRACE_EVENT("libcamera", "ipa_call_begin", + "pipeline_name", pipe, + "function_name", func); +} + +void LIBCAMERA_TRACE_EVENT_ipa_call_end(const char *pipe, const char *func) +{ + // TODO: Consider TRACE_EVENT_END + TRACE_EVENT("libcamera", "ipa_call_end", + "pipeline_name", pipe, + "function_name", func); +} diff --git a/src/libcamera/perfetto/request_perfetto.cpp b/src/libcamera/perfetto/request_perfetto.cpp new file mode 100644 index 00000000..2cfff28e --- /dev/null +++ b/src/libcamera/perfetto/request_perfetto.cpp @@ -0,0 +1,73 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2022, Google Inc. + * + * request.tp - Tracepoints for the request object + */ + +#include + +#include "libcamera/internal/request.h" +#include "libcamera/internal/tracepoints.h" + +void LIBCAMERA_TRACE_EVENT_request(libcamera::Request *req) +{ + TRACE_EVENT("libcamera", "request", + "request_ptr", reinterpret_cast(req), + "cookie", req->cookie(), + "status", req->status()); // TODO +} + +void LIBCAMERA_TRACE_EVENT_request_construct(libcamera::Request *req) +{ + TRACE_EVENT("libcamera", "request_construct", + "request_ptr", reinterpret_cast(req)); +} + +void LIBCAMERA_TRACE_EVENT_request_destroy(libcamera::Request *req) +{ + TRACE_EVENT("libcamera", "request_destroy", + "request_ptr", reinterpret_cast(req)); +} + +void LIBCAMERA_TRACE_EVENT_request_reuse(libcamera::Request *req) +{ + TRACE_EVENT("libcamera", "request_reuse", + "request_ptr", reinterpret_cast(req)); +} + +void LIBCAMERA_TRACE_EVENT_request_queue(libcamera::Request *req) +{ + TRACE_EVENT("libcamera", "request_queue", + "request_ptr", reinterpret_cast(req)); +} + +void LIBCAMERA_TRACE_EVENT_request_device_queue(libcamera::Request *req) +{ + TRACE_EVENT("libcamera", "request_device_queue", + "request_ptr", reinterpret_cast(req)); +} + +void LIBCAMERA_TRACE_EVENT_request_complete(libcamera::Request::Private *req) +{ + TRACE_EVENT("libcamera", "request_complete", + "request_private_ptr", reinterpret_cast(req)); +} + +void LIBCAMERA_TRACE_EVENT_request_cancel(libcamera::Request::Private *req) +{ + TRACE_EVENT("libcamera", "request_cancel", + "request_private_ptr", reinterpret_cast(req)); +} + +void LIBCAMERA_TRACE_EVENT_request_complete_buffer( + libcamera::Request::Private *req, + libcamera::FrameBuffer *buf) +{ + TRACE_EVENT("libcamera", "request_complete_buffer", + "request_private_ptr", reinterpret_cast(req), + "cookie", req->_o()->cookie(), + "status", req->_o()->status(), // TODO + "buffer_ptr", reinterpret_cast(buf), + "buffer_status", buf->metadata().status); // TODO +} diff --git a/src/libcamera/tracepoints.cpp b/src/libcamera/tracepoints.cpp index 0173b75a..a07ea531 100644 --- a/src/libcamera/tracepoints.cpp +++ b/src/libcamera/tracepoints.cpp @@ -4,7 +4,18 @@ * * tracepoints.cpp - Tracepoints with lttng */ + +#if HAVE_PERFETTO + +#include "libcamera/internal/tracepoints.h" + +PERFETTO_TRACK_EVENT_STATIC_STORAGE(); + +#else + #define TRACEPOINT_CREATE_PROBES #define TRACEPOINT_DEFINE #include "libcamera/internal/tracepoints.h" + +#endif /* HAVE_PERFETTO */