From patchwork Mon Dec 12 07:16:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 17978 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1F73AC31E9 for ; Mon, 12 Dec 2022 07:16:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6558463362; Mon, 12 Dec 2022 08:16:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1670829418; bh=+JBOhToP2haO2JcwfnJCK0pb283fLxQO2ib8JwzeHBE=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=mEtwz5GnRqKlDbqFgpEkIWxosWrvD28Pc9ocrqcoB+QiP6rWV9eGREBkQkKHqaIS5 nIvHSmtd7QjrtWjoVKgiQraw8eWqhrFnBRO10SuvDdt4MqjQ7XFQJbXFqVUzWTLioS 8PIZiG+ua6aUveM2rTGMqWlAs6SCGdW0KjjhdjszdCMtFKPmO0o8M6fwmynFcZMLbp b+lNEXv8KhhSjFsKYt796nenr1eM6xU2f3dOwyzS6fYEmGMWm2i5YGGPj0A4j5Xd8I QCMrxf2MDKPKq477k0PT092bMHAq3DqVYezUE5yx+Kg/Xz3UXOlyAhGoXYltuwAHEW BXtFDCJLqpQMw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B7894603C8 for ; Mon, 12 Dec 2022 08:16:56 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TD4b1ReK"; dkim-atps=neutral Received: from umang.jainideasonboard.com (unknown [IPv6:2401:4900:1f3e:7d24:3f0:3e81:fb16:ab4d]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 094A3896; Mon, 12 Dec 2022 08:16:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1670829416; bh=+JBOhToP2haO2JcwfnJCK0pb283fLxQO2ib8JwzeHBE=; h=From:To:Cc:Subject:Date:From; b=TD4b1ReK+/5bwnD9yf0Nbgd5rkE2lhCYiNVgm6wcnWOpamPgkdGnKjGuIAKuoS59u 6h1/1ouNHMdmXLX/kYyJawYIDdfMTuSgBfTkerxepe4jeYrq+hdsUAYYbtGt+NHIyI rzQkcHvmTjWPfxw7f5v0Zbe6YPQl/SPjSa7In/qg= To: libcamera-devel@lists.libcamera.org Date: Mon, 12 Dec 2022 12:46:47 +0530 Message-Id: <20221212071647.23803-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: camera_sensor: Rectify test patterns listed for IMX519 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IMX519 driver reports ColorBars and ColorBarsFadeToGray but upon inspecting the test pattern modes via v4l2-ctl utility, these test patterns do not comply with MIPI CCS v1.1 (Section 10.1). Hence, omit from camera-sensor-properties database for now and add a comment for the same. Fixes: e3b26b4c4eb2 ("libcamera: camera_sensor: Add IMX519 sensor properties") Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/libcamera/camera_sensor_properties.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp index 04d80d6d..7f5e404e 100644 --- a/src/libcamera/camera_sensor_properties.cpp +++ b/src/libcamera/camera_sensor_properties.cpp @@ -106,10 +106,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen .unitCellSize = { 1220, 1220 }, .testPatternModes = { { controls::draft::TestPatternModeOff, 0 }, - { controls::draft::TestPatternModeColorBars, 1 }, { controls::draft::TestPatternModeSolidColor, 2 }, - { controls::draft::TestPatternModeColorBarsFadeToGray, 3 }, { controls::draft::TestPatternModePn9, 4 }, + /* + * The driver reports ColorBars and ColorBarsFadeToGray as well but + * these two patterns do not comply with MIPI CCS v1.1 (Section 10.1). + */ }, } }, { "ov2740", {