From patchwork Thu Nov 24 15:53:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Schulze X-Patchwork-Id: 17898 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4A193BE08B for ; Thu, 24 Nov 2022 15:53:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 049BD63319; Thu, 24 Nov 2022 16:53:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669305231; bh=sfFvGE11+iuy0egk9oEWahbW8749aGgqYy6pOcUucMs=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=DlR8iD0wYBIRc9xHvm0PxY0ri+oGWD6kaON5vi+3O+HytxlReF9s1UjvfBtKyOJ6g pgGuim9Q5zuCP92S9tfzy8CaS8aZFCP0sVZ3YDy50f4lz29fmS7iQg3ktfUI8YpiiM kbx04gYjE3mxMmahhZEjxxN2tZnMLH6aYKMp4P4V42D+P5rIbxA2rDcZ4+rCwzt1Fn Sbdn3U1wZHMll5Ey9Ek/mi2NHVAvUAW7rBsqoQ97Xy7hym97PhvtdWycKBBS8iTVkR oONlqjkRFicSoWM+ydJp/DJaZxlwkeNSWExa+iiX/vrsABgEtJKo4jBophmH8ucR1k 01YoLg4iW8fpQ== Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DD6D6330D for ; Thu, 24 Nov 2022 16:53:49 +0100 (CET) Received: from raspberrypi.fritz.box ([84.160.56.77]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M27ix-1ovlZN304f-002Y4G; Thu, 24 Nov 2022 16:53:48 +0100 To: libcamera-devel@lists.libcamera.org Date: Thu, 24 Nov 2022 16:53:15 +0100 Message-Id: <20221124155314.21332-1-max.schulze@online.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Provags-ID: V03:K1:hClnlmyORnyMkc76RJfqcG9G4H76lVX+fJVYsgbQEuQbVwLKu1n lTk+/vKa10quplh3qzWzqABGMXx+erq28tg8K+KtUxRz9U4XPs8Ow6iRKl7nhqz4ChFJkqb 1GEmEdn9f+oO4nKXFLBhbAk4PN1t15lJRl03MEfRvRL5bFxd1LkG9ZrR08ee4ChDMSqJiRI USgTMPHN03pjIef54nLPw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:lzsupu2IEOM=:E+fbLUQa0pi0b/OCQlC2p4 vqT3SJhD/pjYMSReupHWmqXTSQmnTVNHb1DkpRmrxubUg9VlovCHkaiDYvphQW/PhZCLu/cur yYEltBvgAe9EpxzDWaatOvlWEVuHmDzLJruvcXlon3OSfnyn/JD7qhooNP4ueThEySbXW4SBi Fa3FPtytmck45NdD8JVnOXO1Mo258uDQLwjOuChW6Augwa+3fuLAf6a5XcMsYclKGWPl7oLu2 547X57BK/kuVR/FivCB1AyrVB8owNm4sxt/6aHV9VBpSg6fq1nLFQk1eDgG7tjKKIuCK7dQDm OxGWgkFe0Dd6nKhijXxiWNg5h5sNTxnW/UaIjrw0fiGKCRWeOqwkf2AYptYl+HnrocI6tFeuC KbO5ZcI3ulKQWRsC6G+jXkyrUWy5/Iv3whUTpW4NyETyzWTaiMV/XdlRcJZ4UA5lQSnFvBYy9 bXpPe/rZpNSJTpE4ivSiAvNXKtf2V2SRYi5h+/jAlUzn6p1KFx1OvjGdLHC2IImQ4ksjixAml TjJdVjN6ABYySRNJuZSvxZTUy9yJDNjvfNMidam3453H+SAyTdAxn9DqodHEg5Pcpi5hjcluv mt3tZIfdWmxyDAT5o8zGqCMVzJz3PWRI/HStGEHnhvw8brTD4dYDxSwZ2Qpy9790CQ0lbh/+M LzaxDomSvqant2etCgffOPhXijzgvIJ7hyy6jVqPe82ejDYFXStgMdfe9o3F3NZvf8s8lPOJJ oDJ8ffjEnOR/GkAjVml9AAefwSqCZg7Gz72ng6v5it6wM75qfWEoBRF6WREdqlhz9f5Uan2hR 5FE4Hy+ Subject: [libcamera-devel] [PATCH] ipa: rpi: print path and version read on config mismatch X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Max Schulze via libcamera-devel From: Max Schulze Reply-To: Max Schulze Cc: Max Schulze Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When the version is not what we expect, it is way helpful to note the file where it happened and which version was effectively read (i.e. to rule out conversion errors...) Signed-off-by: Max Schulze --- src/ipa/raspberrypi/controller/controller.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp index e9156785..3f09ea92 100644 --- a/src/ipa/raspberrypi/controller/controller.cpp +++ b/src/ipa/raspberrypi/controller/controller.cpp @@ -41,7 +41,9 @@ int Controller::read(char const *filename) if (version < 2.0) { LOG(RPiController, Warning) - << "This format of the tuning file will be deprecated soon!" + << "This format of the tuning file " << filename + << " will be deprecated soon! \n" + << " Read version " << (*root)["version"].get("") << " Please use the convert_tuning.py utility to update to version 2.0."; for (auto const &[key, value] : root->asDict()) {