From patchwork Tue Nov 22 12:03:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17839 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 93BFCBE08B for ; Tue, 22 Nov 2022 12:03:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 46A0761F2B; Tue, 22 Nov 2022 13:03:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669118632; bh=D6hGiSrlAsmyAEZZHB0ByVnwKlmYVX+dIGEZupbGkkU=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=fUiB4IM58bBmqJpDbSmUlkTtqMv2xXK9/xr8ubs3wvUuJx9G/1AUvP5Fq6DDICtrR OWxpM4ftV10xZh1utuXlbhfurrGo2kE0o4n8EIV2dk9WZOAgfYhm2k81tT/1zLDDYh XTNKEn0kflvXJgj6rXFlDXdujQ91NE8ybudsAqBSuPD9iiux0+BGiMc2Ueg9U7e6A3 lLupi1GZ5kQkDO6baVEnaFb+4jFus66CTRvFBsjtIjMGUfRRt3wHpEqJ6kY9bkrZJT EmfU/dn4JqrAIiq8OMfUGEYlpN7GcTyM4Xb1Yi8XgNvQTWUHSKO3ukHn2XN0zeshhO e3HHTY5FLAuaw== Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 437D6603CE for ; Tue, 22 Nov 2022 13:03:50 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="qIFqPl5f"; dkim-atps=neutral Received: by mail-wm1-x332.google.com with SMTP id p16so10555779wmc.3 for ; Tue, 22 Nov 2022 04:03:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sFU0Gg/wNt18KDrjME9o7kh6pYcn2Lz9x0Cmmv2WCwg=; b=qIFqPl5frT9rs6kDWkI91UVaspFdwQ15mMb+YriXSAY/S/yZL9CrnGZFxRZycbaSG2 q+kptQTURFEEQEPmSe0j5HAJbNVxd5L/dD6bpRl/iBZ0MAvX7zDZVH6IAWTp3x1V2KKi IJBqVVdfs3ty8vyxvOCKW4BR1BXhKfvsU57Fm5dCEKWLaZCeW0qxzONS3sN83DCmfHKS zxpI/AlVnDhg1EPZ0r7VIHN7POozqM8rumfiAUWB2wfsi1DfK4W49z8+Ig/ilss+RT4E 9m7wC/PBx+/TudNgvB5QfpJzwEeg8Vji6xiGHflxHH+dNdi3KUWvNptKo8RotXnZwUzb 4TbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sFU0Gg/wNt18KDrjME9o7kh6pYcn2Lz9x0Cmmv2WCwg=; b=VyUYGlSBm2Selh2nzETGSPMHe1PV7aCqv5d2HxdmGwNsYgpZF2xJ4XhmbAkuHRC6j9 EuGo88lFS+4tp2aIYu7MDrX3JAv43qPEzGAaXNd+4uYF2okMS7PJgksMpKNuE1fyGnJI dNaoaYjqhfOzvwfQ7T9DdXuAF82S+R8hu8eNaasjMLzR6N1hBlpuhoowTTDV5MBOy+AP XskOO7ffAwYRtO2laL92px6uWTS/0rF6sl2j97ScD28kN0R4NidGmK2MOoJ1bQORAsSY AnFsJFt9FmcGes0nmb4tTSMdUlV8PMkle0FThouX4mDBZeWuXTxVFfutAMyhTlYrFfBG TexA== X-Gm-Message-State: ANoB5pmJvxhVFc/tmyQbYEUmlEcgq2bv06mXWBwyUt0Pgd1IduKa7r0h AytWCNlWHg1EPHb0viiAN/7WqCj3RJQi3Q== X-Google-Smtp-Source: AA0mqf4RBGDZo2umTdHtH29/MSCufiN1kqD+qQUX3DYsz1LDMSpkKL23uxjExmzPd8IGckMgZr7oFQ== X-Received: by 2002:a1c:f006:0:b0:3cf:7b68:631 with SMTP id a6-20020a1cf006000000b003cf7b680631mr20137307wmb.55.1669118629588; Tue, 22 Nov 2022 04:03:49 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id p18-20020adfe612000000b002366a624bd4sm12119141wrm.28.2022.11.22.04.03.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 04:03:49 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Tue, 22 Nov 2022 12:03:41 +0000 Message-Id: <20221122120343.4825-2-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221122120343.4825-1-david.plowman@raspberrypi.com> References: <20221122120343.4825-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] libcamera: camera_sensor: Add a function to reset the HBLANK interval X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The existing code to reset the HBLANK interval to the minimum value (in the init method) is moved into a separate function that pipeline handlers will be able to call. We no longer reset the HBLANK in init because we may not own the camera and the operation may fail, so pipeline handlers will have to call the new method for themselves. These calls will be added in subsequent commits. Signed-off-by: David Plowman --- include/libcamera/internal/camera_sensor.h | 2 ++ src/libcamera/camera_sensor.cpp | 10 +++++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h index b9f4d786..c97b5698 100644 --- a/include/libcamera/internal/camera_sensor.h +++ b/include/libcamera/internal/camera_sensor.h @@ -68,6 +68,8 @@ public: CameraLens *focusLens() { return focusLens_.get(); } + int resetHblank(); + protected: std::string logPrefix() const override; diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index 572a313a..589e9736 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -176,6 +176,11 @@ int CameraSensor::init() if (ret) return ret; + return applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff); +} + +int CameraSensor::resetHblank() +{ /* * Set HBLANK to the minimum to start with a well-defined line length, * allowing IPA modules that do not modify HBLANK to use the sensor @@ -192,17 +197,16 @@ int CameraSensor::init() const ControlInfo hblank = ctrls.infoMap()->at(V4L2_CID_HBLANK); const int32_t hblankMin = hblank.min().get(); const int32_t hblankMax = hblank.max().get(); + int ret = 0; if (hblankMin != hblankMax) { ControlList ctrl(subdev_->controls()); ctrl.set(V4L2_CID_HBLANK, hblankMin); ret = subdev_->setControls(&ctrl); - if (ret) - return ret; } - return applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff); + return ret; } int CameraSensor::validateSensorDriver() From patchwork Tue Nov 22 12:03:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17840 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 832D6BE08B for ; Tue, 22 Nov 2022 12:03:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C258B6331D; Tue, 22 Nov 2022 13:03:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669118632; bh=G8frbkZVyMaSX9UYgeVvPpdfKXAc2FdySpJjfQpPuxE=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xX0bhW4TfhBF7xsUlcPcWj02CvaixHlxR3qUVnsa9c/Qp9VlLLmgW2jGDLyG6JxhZ RZDG3vNvi5WLjmvWh3Djft8ove6W141+/uyv/ZhqINYkbqa+Ffx5HK6bWJOA3FyouG kDXUi1+kZi8KLPi+YRVMPdzvu17kYLblrdHFWka8CyBZYiQhQNX1jxtR9J6DwzK59g QtAQ12gsvUpiCg0WhtU5Nki6RQwOY3pSh2yCu4HcQriEgxik8VNVhAvlgZxgc30Z3K sm/ycrcdtNiHJdepC5L9fyqoYqi4DQ9C5zoiGe9EZS5OUDf3l5LBlUYBYrHdxg/A84 8yMhvhh5QImfA== Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3133363314 for ; Tue, 22 Nov 2022 13:03:51 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="INqJK4iA"; dkim-atps=neutral Received: by mail-wm1-x333.google.com with SMTP id l39-20020a05600c1d2700b003cf93c8156dso11102565wms.4 for ; Tue, 22 Nov 2022 04:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K9hGY02j4oY0BOoVT4ZMtV3lThC8jKwGnVMrWOiWI24=; b=INqJK4iA7Nk825hrmgVGDW3REsF0fVGcrR2ELMdekCgRPXRdUBJptBfIYgjAdKEkY2 kQ0DhvIS4AFTUHBPUiHKctj5WBc7AFnnVMc2R35yqshDYE9KFvQJwGpnk7JqsJ+Ebaow yQP72xXUygPUkkItZikskPSEhnui9CsODB3Vv5uAcEUuHpRZeVddBCKaaX43lPeNT1mT BwVjfIgMS9tP+m2kH8XoPxdpSJBWSKhIYjzMiOS7K7SBwkNM8WWvTBQFmfw8YVj6CZb2 /2Fnihg7+b/3fTOth5urxUnhxTHmDkp+lXaS9k/Z8ZivgjBDlkuVIk12b0A8vIHJFBKu uzAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K9hGY02j4oY0BOoVT4ZMtV3lThC8jKwGnVMrWOiWI24=; b=DOozPFGIfqUR5wZWE6zTWnJOzDkFM/cOnyjWnX56Ay6tyrO2ov9iKo8cnH4X6R9nWK JNeN32P0gu/P03zIVjGCb1VdurG/ijWZIOaWPI+AD9n8LHzX5FMj3Ef4Ww7Yd8HdXKWL 7kr90PevZl/8mve0ppD+XuClUKbyC8/raBvfCtcY28gj4jpkj4tAJmLzvq7HJzRorCCr T29xMos7DWXBzCvSqfys6DL8R+A8hlBitm95iiR2P4/U5iubH6bGxtnaK2Yc3WFOJCI4 tn9N9xF2OriiCgfmGekrJElJnBjHGJrQNQneIsy3Y2TOKLaugUuQ470c22uYE4v4HWJz akcg== X-Gm-Message-State: ANoB5pnDQJOk6rmCsKBsx7NHuk9kfo+P4O33X3TLpmgh1o/Pt+3LuCI+ hQ2OOUHBNaNZxZN6A4NadgEFkBuRyJn4nA== X-Google-Smtp-Source: AA0mqf5m19ATH2S5NH5cU1BW2ndJWWjoW80Hd4cLAwomEIcdxarEcwfMf/F6ylb1XkFjZ+sbfQVrpg== X-Received: by 2002:a05:600c:46c8:b0:3cf:8896:e1de with SMTP id q8-20020a05600c46c800b003cf8896e1demr8991976wmo.4.1669118630462; Tue, 22 Nov 2022 04:03:50 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id p18-20020adfe612000000b002366a624bd4sm12119141wrm.28.2022.11.22.04.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 04:03:49 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Tue, 22 Nov 2022 12:03:42 +0000 Message-Id: <20221122120343.4825-3-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221122120343.4825-1-david.plowman@raspberrypi.com> References: <20221122120343.4825-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] libcamera: pipeline: rkisp1: Reset sensor HBLANK control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Resetting the sensor's HBLANK to its minimum value is no longer performed for us, so the pipeline handler must call the helper method to do it. Signed-off-by: David Plowman --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 3d3a7086..4163cc27 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -632,6 +632,9 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) if (ret) return ret; + /* Reset the horizontal blanking to minimum in case it has changed. */ + sensor->resetHblank(); + /* * Configure the format on the sensor output and propagate it through * the pipeline. From patchwork Tue Nov 22 12:03:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17841 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5EEA5BE08B for ; Tue, 22 Nov 2022 12:03:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 22D9863314; Tue, 22 Nov 2022 13:03:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669118635; bh=6FM3QFEdtWOjmGPVWwF1R7Y9blkyrWCuUZsR9VgGB5M=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VIZds3PzYlPib7mF3qe/6HsOZ0vSJZeNlqjET/UA1pudppLLia/kEG8y4m56uiqxi a/hWZWfE0M6QWOAfXlDFSFbFzCwJEQ2e6LBmhnQof4xrB57Q6jSZszrK04nzVNxfsa zJbd0B0EY5H16WrU0WVhuJksLfeR0l4LJPe4e4MpM9NgtGaaJwteoYkSanGsWXHLA5 /wzm+dhOx4qOYWZjydXFCzViPCv5yYtYp0cgbO1vify6oQTSYK9ZrP+ORhCzmacdS7 7rniCOpCBHFS83X/oncn0jILnHQYaCMYhbf6Y79ZiXn21cyIbTekaHsuptqpy/Xehw Wc77gN2xjUDkQ== Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5834C6331E for ; Tue, 22 Nov 2022 13:03:52 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="OyxY1OuM"; dkim-atps=neutral Received: by mail-wm1-x334.google.com with SMTP id j5-20020a05600c410500b003cfa9c0ea76so11115146wmi.3 for ; Tue, 22 Nov 2022 04:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QM3FI8MTL2nC87hq0DBBUKu5+wbe6JmvxrskIriyLVE=; b=OyxY1OuM+GOfLUlnq5hHrl8+gJJQUvQby8lHcTHchEB1BYWY7T2A7FDy3m6Q/iUFOi trqHTrQCSAWqw9PQLAgD3zJzYFizJQghI5Ss1FpnoSUkbS16mON//FIyw/1OriKgkxrv OuI0C3/A7l+hp90QLcBmbAfEFahHDiJZo2V/ulbIm5ASAQIfAruF+24T48d49FbaktQ9 PcKoyVr1TZgwXjnqHEKZ3PmrJm6rCpZuHuKmJc+ytK7L3qxVSJ4zlhzez4UBy6YdQh02 vpg25zo7/XTi83NKYk/VAX0kRvYF/Dp9f+5qisWYAFj6mSrLU97e5iRGEQ1WDCdkeF5v GyCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QM3FI8MTL2nC87hq0DBBUKu5+wbe6JmvxrskIriyLVE=; b=c0jYJcR8/Unrnu9qbb5LpC7FEPdwzB/NOPQ3uGe4Ks4Dy9MoRkJBo8/VjEXk5zz6EM AsKuPSpgbZYXRXpsyqEy+sxej2HyjPo272/6om7O/D5yIqy09zv282Of9rN8pmCA57k/ m25lI09D+Zky4RRlXin6ihP8ik30eQoblYemQdfEOtw3lQG3QberghWN1DQl+poDREXb hhdWISBU8o/KFxO9/HoYp/aTS1+jMlWhkCNUjl9aizagBkD/cKSvvQ60lA3jPsSten7F Px7g43UKrM63CAC5LPvRz5UxSJUWzmm4gT/aCz82ULj1NrhBjj7GsdCPvpCY46oLJIHS 2zgQ== X-Gm-Message-State: ANoB5pk1m82nQitlDcEA4I1zmVpjO7RhNrzUikiO6dANlHSqtLI46y2V YZsGTCzKOdFnTbxwjme2mZPOEFF2hUMWfg== X-Google-Smtp-Source: AA0mqf5BTv7xfbT8F4+jqJBncuMMVbWQFQdfng8h17cHkU3K5/HUuqlEyzdj35L9orZq/NtYiCk0QQ== X-Received: by 2002:a05:600c:1e89:b0:3cf:774b:ce6f with SMTP id be9-20020a05600c1e8900b003cf774bce6fmr2999915wmb.133.1669118631385; Tue, 22 Nov 2022 04:03:51 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id p18-20020adfe612000000b002366a624bd4sm12119141wrm.28.2022.11.22.04.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 04:03:50 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Tue, 22 Nov 2022 12:03:43 +0000 Message-Id: <20221122120343.4825-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221122120343.4825-1-david.plowman@raspberrypi.com> References: <20221122120343.4825-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: ipu3: Reset sensor HBLANK control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Resetting the sensor's HBLANK to its minimum value is no longer performed for us, so the pipeline handler must call the helper method to do it. Signed-off-by: David Plowman --- src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index e4d79ea4..47ec6bd0 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -566,6 +566,9 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c) if (ret) return ret; + /* Reset the horizontal blanking to minimum in case it has changed. */ + cio2->sensor()->resetHblank(); + /* * Pass the requested stream size to the CIO2 unit and get back the * adjusted format to be propagated to the ImgU output devices.