From patchwork Fri Nov 18 20:39:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17816 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6A3FFBD16B for ; Fri, 18 Nov 2022 20:40:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B67E96309B; Fri, 18 Nov 2022 21:40:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1668804002; bh=uN/NZb2krpnizgpg/rbNzi1UqrShwdydj24pz+D+MoU=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=jZMBqFLXaHWBXgCj0kwIYAavpfrXRSC7kDH3POvUokeRpyxUGYtSfngJvU8A32J53 1W4QfcdKuKZJibqw4NpSc2SIiI9fGWts/dk4k64y7KJC1jxHQXycMfuuF1NlZx4FBM yRkHlvlwNfxNL+BMBDuSlUNxim3bDJ7ew2MoKVTzIHQeyIxJLbCJVKqGe22XrPLUlc DaYd1/qp8x2/2hCd9s50c4J0BQdAgwJJbAqLFDhxukk+Lld1QwUdb1S2xqFjHnUeqK xqUX02huObDnofhyKY3x5a3adRirMY2p7h8JnJRlcR9JplcIXSP5wbESnyYjczrJJJ +hOsD3beG2RYw== Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CBC3E6308D for ; Fri, 18 Nov 2022 21:40:00 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmx.de header.i=@gmx.de header.b="D7svM4lf"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1668804000; bh=uN/NZb2krpnizgpg/rbNzi1UqrShwdydj24pz+D+MoU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=D7svM4lf3n8UWztrYrZtTIHE9tNlhfKbp/SoI1131O/cRv+c/zX1FQKhPGAwzg7vT sYBGzAj7trHjI1YXl5H7pdOz7tMbL93rI9B75SjTS1dE/rZ12kmOfIkt8wSQMJkQAg /0GMMxYzGDeHJbAY+yqPxKffVy3fDflTa5u7MYnItTMqbQlKrSTZCI24Z+dimZRVzL ZLYX/xS0gvcs1cyN7XBXWUj0a+jSaqawdTB2I4PJ3X6NgJP3vHE83diH5WZu9punCt vEBjJ68d4B1D47qZfJSkHLhzYJyF21DmzliWw3RcES/Lsj+i6XvMb7clsRVBHcfV/A l9z0sLT91Vraw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from voyager ([46.183.103.17]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N8XU1-1p01xG0aUT-014Win; Fri, 18 Nov 2022 21:40:00 +0100 To: libcamera-devel@lists.libcamera.org Date: Fri, 18 Nov 2022 21:39:51 +0100 Message-Id: <20221118203951.89812-1-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:wcxJ2zYJV3inhm6fNif74CvjNg9zKkOpB+UncvOzYgIW9lMhQea ZlUt8esHK2y17uCCSdgkrQvGC+YyMTJzNiXinXSWJ7taHZrwdS2Ph52Kqnyst+fBkDYZ9Ri 8Hie1djdAGfBHdDgga3BcOazyB/ctrJa6fk7T5FeQE8Yn9mOZ20KP8Pq36IeYigUqMCAE9N TibZseSmz/YewFGIktlTg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1; M01:P0:gsGU53zXHjE=; EESZDD9lBO9GALCATzx9xAl42kv FVd6+YuyHsccrx1Dhwtqv2cZfs7QciUJ/A0B8PRFeGp6Rkt2UMpp5s89wt7cmsqYHx+T/qdQ3 sEMYSwz3/SBdqfamiK4gFGhmvuk2G9rBiubmI1eQXhmOV8WjJLoK1uYhyTmXVZOzpd/CFbazB KflegawdMejZIr/LpMkv20j2yVXacZy02cYy/0YJ8fOw/KdWZ6Ibt0066KSDVw+Mwq+iCGhQ2 mMJrHrGmEUFu6A2S0cboRd+HzS52/qkEecXXyZ9c1SuZr/cxLM3S+NZfj3Q0NLheibbJiRW1Q ShmVB07zeYM+/8evGFO22aGytBLqrcA4RYOGWkSN2CLwcWtAmJPL8fMKd5dPJgl2U0WiNQn7r sCWs6oGKJkEPKI6LhrfnY5Ztfn3vlqujBE+UupwGmGRGm98I8K2dpFANLwGdg9zrd/+0gSkLb EPVXygibkZijPN9e8X43KGN6NhLE/fQXVpDUU61T8Dk+EpoDkqa8S4673lG93KhkUFf6io+sc PnGeWUWodYZJhB6u4g80A2Y/6FGXXvNkSFBaHqd7Ajx66/q4dOxTPVxS2Vf6UfhBh5H5PY/+o zMh43c9hp/A5zhCQ+838thwxGctngvX0NOY0PY6NBJsOrANy8X2MwPRKtSpxluSuXSsy5se55 GEBXKEwZUDyRzIZX9OiLRZsni0N2ag4NVjydZm+v7BWxuBJ6CZJH3J2EWxrBDZWp0NBqo4KiR UAzqYRd+dwCssrYgoKy2hmimaOhLyhc0VG44cfSAuwzX6t1bBFIRDM1o6DFcflGMt3pA5T82O xuUqnt0pdEU3sKBHxXeGzBOfMFeolSGaDcv2EEtAvfROO4iBBXYcUL1bQUeKC2mLAD+jM5qHm gd2D32C1Sc+0LBcinQbrJKwOa4LacXzMkkrNitYsOFrjI5R+FWVETvwgFzS2VGajSg0gNpxxE gFPnIeakBApYI1REO9rZ5o92tLk= Subject: [libcamera-devel] [PATCH v2] kms: flag 'request' as 'maybe_unused' to avoid 'unused-parameter' warnings X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The parameter 'request' is only used in an assert. assert is only defined for debug builds and release builds will not use the parameter, resulting in warnings messages only for non-debug builds. Fix this by flagging the parameter as 'maybe_unused'. Signed-off-by: Christian Rauch Reviewed-by: Laurent Pinchart Reviewed-by: Umang Jain --- src/apps/cam/kms_sink.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/src/apps/cam/kms_sink.cpp b/src/apps/cam/kms_sink.cpp index 754b061e..353209cd 100644 --- a/src/apps/cam/kms_sink.cpp +++ b/src/apps/cam/kms_sink.cpp @@ -517,7 +517,7 @@ bool KMSSink::processRequest(libcamera::Request *camRequest) return false; } -void KMSSink::requestComplete(DRM::AtomicRequest *request) +void KMSSink::requestComplete([[maybe_unused]] DRM::AtomicRequest *request) { std::lock_guard lock(lock_);