From patchwork Sat Sep 3 23:06:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17293 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4B9A1C3272 for ; Sat, 3 Sep 2022 23:06:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A1AB96203D; Sun, 4 Sep 2022 01:06:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1662246418; bh=9Z64mlT74qHO/5XwtLJVylIiUkcu4JB31Wu56NGXd6M=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=SuE4d7i8r9FMq2jQZ3p4Xr2ErDtPqzswuOMtaixgugiJxjETqdR0J2rndh/1JrLhm m9qzLP2sZZY6lNfhxLnV3+gVg0DdYc3/joYDzcp7IBBawJcXmutcueCjXWQsCrxGgd Z5NfkhemAwX21JzM0zfJxOKhS1emj3PhRc2zBlJG/ldW/88gIIU+yS0DlwwBs81Wtd a/Pgr51+JJRocfQO/I6XZqOLNDnt0EpyNs5CsGXhTuc4Qi4a6eomDB4EDzBmnyGJAE AvCqmg9KLVk/6SqmUfM+/BwufQsRv7lvRfBAoiGdt3Eb3VZIem2q8WmxFzhVr3Ztd1 0Id4Ek93xFDoA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 01F12603DD for ; Sun, 4 Sep 2022 01:06:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="m1MtdSm0"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 242A62E4; Sun, 4 Sep 2022 01:06:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1662246417; bh=9Z64mlT74qHO/5XwtLJVylIiUkcu4JB31Wu56NGXd6M=; h=From:To:Cc:Subject:Date:From; b=m1MtdSm03/NuF+WIIZdu6njQei/KuB8ykTPSchlIt/UYV36l+REqy62BRFN8T8mf0 x7r94E2BMl5nWfdCdtt90CTnlOwX2ne6agxvuELam9I9pRGT3JlDN19VmxCXCeaLpc /6ZbpKsLRF2tk2VCqOGxPKH5ZE4IVdtWyU5sdjgI= To: libcamera-devel@lists.libcamera.org Date: Sun, 4 Sep 2022 02:06:43 +0300 Message-Id: <20220903230643.19284-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: v4l2_device: Map YCbCrEncoding::None to V4L2 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The ycbcrEncodingToV4l2 map is missing the YCbCrEncoding::None encoding, which results in a failure of V4L2Device::fromColorSpace() to convert color spaces from libcamera to V4L2 for RGB formats. Fix it by adding the missing encoding. As V4L2 has no such encoding, use V4L2_YCBCR_ENC_DEFAULT as the value doesn't matter. Signed-off-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Umang Jain --- src/libcamera/v4l2_device.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp index 1d899657bf7d..7f251bd820a0 100644 --- a/src/libcamera/v4l2_device.cpp +++ b/src/libcamera/v4l2_device.cpp @@ -796,6 +796,8 @@ static const std::map transferFunc }; static const std::map ycbcrEncodingToV4l2 = { + /* V4L2 has no "none" encoding. */ + { ColorSpace::YcbcrEncoding::None, V4L2_YCBCR_ENC_DEFAULT }, { ColorSpace::YcbcrEncoding::Rec601, V4L2_YCBCR_ENC_601 }, { ColorSpace::YcbcrEncoding::Rec709, V4L2_YCBCR_ENC_709 }, { ColorSpace::YcbcrEncoding::Rec2020, V4L2_YCBCR_ENC_BT2020 },