From patchwork Mon Aug 29 18:58:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marvin Schmidt X-Patchwork-Id: 17237 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 18350C3272 for ; Mon, 29 Aug 2022 18:59:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AABBE61FC2; Mon, 29 Aug 2022 20:59:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661799543; bh=Ep/F8ywxEYci28rZy4z6A3Drx4kokNEZUWQ2TnmvhsI=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=UU8koiLgbT0JXNyRGfXxBBwUBA35ZwkVMbCnI4d6vCd13VtPODGHI7xz8izaNG9eT xeEdOgcbz6r0PsEnR2T0nP7X1HGgfXe9XkQIMDx/+RpjPgSVF7sbH448JpZdz4GA80 6+QHpnP3vYjJuMKStRdM+dxvvqIAeJwxc/FGDU0faWsnNyC2H6DmOEeoLwoTv4MtiJ C6FW+sjORFNKGaEU7bD0XfzqUyg7+ivbZOpzInWtSm8JwLwlv3MQwvquW+Ikfm1nZ7 CtINUqq0lVj1K3DvvtiN/UQU2Eta0tdykH6gYJ6i5o7vkjKjbVJO++lwnKVaQPURcS A30M/GWj+nIog== Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4753F61FBA for ; Mon, 29 Aug 2022 20:59:02 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GZPK23rT"; dkim-atps=neutral Received: by mail-ej1-x635.google.com with SMTP id y3so17606636ejc.1 for ; Mon, 29 Aug 2022 11:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=KYPO9091lscjawHuZzSZcftTdUaCoD2F4Td2XI55HEk=; b=GZPK23rTjP4TpSLJJAxH4fRjqGyugcm9LG7LxVqPU9TBc1B3PWlpKP2z8UK/QaOH5z eV76JNMWt6eGwACcPJn2tD0Nhp2JHvtWFDRPvFJz23KI+0POGjb9a9bsr1NZfVh3BUt4 E8IeHlJdeREV5rQy64oI/uvunfXDqaA8rPVamnwoDlOD8+V1u4Te7LV37QPRPfVX8U9G 8/EfjDMgdUTnkGFCW6FiUV8GnWUffOfnDMvb4TSDz6/y5D0MUEm1jXXkMArT4AgE6sSX x0Tq0Crhx5ec62dvrG1TR7yKqBmgaL2A6eiOT3MCvddCK7bLyyzvhCfZA3dYLLbb6int H1Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=KYPO9091lscjawHuZzSZcftTdUaCoD2F4Td2XI55HEk=; b=Ko0W1mc+Oitw3wCBkKrMQm451ZBO4y8DaNuyrt4AJUQ0DyJVZlXbgwqvm7rFR/sN1n 11tooIMDdUFAs3Zor5YZMQD5PZu7yJYyv/jnYdNBwuRaa9BEm3bLxwf6RHG2WL6How0h iZr8q/zAczUrrnTgYdQ74Aa6tKz3CQ0CLOzNKT2q2ktRxkiTPb+C7hR0irbhLOuQaRZf QueUcOnkC8qoeZEC5EHlhacUJW7EEkNiTjTMcl3RYYi7LKtHW2FbMEFEJS/WWCJND0Ob +OlOwIwLhF8MI2smn4iM1g3rSSy9z7Vz6TCBehby+Gsn9CutUKYR0g027NF+WAqjTCGU +jRg== X-Gm-Message-State: ACgBeo3G75DLditYL8M383rtmGh8kAhanEx91wlhceUc6fiExvVteZmy 4TdaZyJ8W1cQ1928cTvfzUDyRLflTIc= X-Google-Smtp-Source: AA6agR5lmP50Jly7/BP9yAVsRVRXfz5L41qhaYf8Z66NHWfeLkDFGgSqvK9BrmEX6s0mC/YNwfdb/w== X-Received: by 2002:a17:907:3d8b:b0:741:9f51:ac16 with SMTP id he11-20020a1709073d8b00b007419f51ac16mr3223738ejc.39.1661799541613; Mon, 29 Aug 2022 11:59:01 -0700 (PDT) Received: from pythagoras.local (dynamic-077-003-143-111.77.3.pool.telefonica.de. [77.3.143.111]) by smtp.gmail.com with ESMTPSA id 17-20020a170906211100b006fef0c7072esm4828136ejt.144.2022.08.29.11.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 11:59:01 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Aug 2022 20:58:47 +0200 Message-Id: <20220829185849.1884517-2-marvin.schmidt1987@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> References: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/3] test: camera: Remove redundant call of std::string::c_str() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Marvin Schmidt via libcamera-devel From: Marvin Schmidt Reply-To: Marvin Schmidt Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" libcamera::File::exists() takes a const reference to a std::string and clang-tidy's readability-redundant-string-cstr check warns about it: > ../test/camera/camera_reconfigure.cpp:182:21: warning: redundant call to 'c_str' [readability-redundant-string-cstr] > if (File::exists(pname.c_str())) { > ^~~~~~~~~~~~~ > pname Signed-off-by: Marvin Schmidt --- test/camera/camera_reconfigure.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/camera/camera_reconfigure.cpp b/test/camera/camera_reconfigure.cpp index f6076baa..d12e2413 100644 --- a/test/camera/camera_reconfigure.cpp +++ b/test/camera/camera_reconfigure.cpp @@ -179,7 +179,7 @@ private: continue; string pname("/proc/" + string(ptr->d_name) + "/comm"); - if (File::exists(pname.c_str())) { + if (File::exists(pname)) { ifstream pfile(pname.c_str()); string comm; getline(pfile, comm); From patchwork Mon Aug 29 18:58:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marvin Schmidt X-Patchwork-Id: 17238 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 13EBEC327D for ; Mon, 29 Aug 2022 18:59:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BDDD361FC9; Mon, 29 Aug 2022 20:59:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661799546; bh=Jos+LhCNs18cwF+Un9F40PUKpM8/yLawM1pih7TPZus=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wwXIMNr9Eu1shmC7VEIik5XOTPAaJBLTOjGSTYzcpoZApulczaHn+M1JEkRihWmV9 Zw9qMHTAyIK8Uv83z0DgI0+P4vbKNfDz86HiUA0wJ4TC0u1kbG5MA+9cG+E4wBJ4UE rlEYWmrfqKPCj9ONOxiRcgVJU+LQVRbvzbXC1qeb0FRHU2B/G7K68d/LiM9GvnCkok CqO7hV+UkCD8si9ui9vT3VTw3Tkc33lm6TTbhTcpAwTb/XzAh2oVI6/pwKNTyId8q4 PWrYFk3GJEwBA7elGBn3omzKupBjf+9RuYBgvPz85i9gRrrnS4caK1Zn4urgmxVM/U XSmAywIhBrbBg== Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 13F4261FC3 for ; Mon, 29 Aug 2022 20:59:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bOqUaBLl"; dkim-atps=neutral Received: by mail-ed1-x530.google.com with SMTP id z41so3941094ede.0 for ; Mon, 29 Aug 2022 11:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=2OlmZP7JRnr9HHxNIH683hvLfcTV3E+NkjsSXmg0f3Q=; b=bOqUaBLlt+XdCMmCqw5KdfHZIo+Dg2Y6dHGPT6AeSb8FEUdTGs8nKoXZKBlYlw/iHW 8iDThDxHdESJDBDIuIbLaDpE9NEqHzOEIDbwJwy4rkO1SoWpDx9gWIYhi3GmWK3Rx7mI 8GSmKtMc4nwf4U0YzoZs72OZlWobwWVJjmN2DMtXqwnjJZlGWGZFmjr73As/mp/+WoDt YnJExY/FqHeb3oQcWiOQ3HKeXBsjkRsMyhXxZBTkdVZuseypykDQu9QgI8aTfsPoRhgN rRKlb9cgLCcmgw6/7lLbv17cf8VREyCNm9hc7vgJQ2Q+dAv1RpvPMTFP/AqpmPAY+as/ 6QGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=2OlmZP7JRnr9HHxNIH683hvLfcTV3E+NkjsSXmg0f3Q=; b=yLBpf//9cSHlB9KLtRTnOOJrv0gcyrdxO9JeiEjW05DFDIVg9xd3ETlziidYpRsn2B P6GbhxE+SKVF7jaouIBkxMFNgS2+OBwMkpquh54RTNzYJ/AhxgWnByGE3VxtJNd14mpp E1LTuEGhdeEPotCG5mx3LlVBwM8e1MyUVcBPIOWBQXcCtHST19HHMDWIWg1m+sxwQy5k 3z9u9Moune96GNj1q3ihVjPnTSKcUHMsB/cSFd6xbKg+WvdU6fozxVdQcK6jTF1oyZev wrA27YfKzjzpzDxVF3iUP3mqDlr2S5OrvRx1WxIuZTIkAE4eiRXqtwdm+0reW4HYVm4p m1wA== X-Gm-Message-State: ACgBeo0AEhVyG1xPImLC42NaLgkM/E3i9fBZHpwmbKzQzo907rK0fA92 ZvviZ1uScBalZ97iKS8y0p45pWcWqok= X-Google-Smtp-Source: AA6agR52BLNCvQR92rNV4oe3NeW1pU6VxZhaVBHx0waVNdvEuoDK+ODuHlkCvA8dZMutYEY3fpoBnw== X-Received: by 2002:a05:6402:290d:b0:448:32f5:1e7 with SMTP id ee13-20020a056402290d00b0044832f501e7mr8779461edb.50.1661799542383; Mon, 29 Aug 2022 11:59:02 -0700 (PDT) Received: from pythagoras.local (dynamic-077-003-143-111.77.3.pool.telefonica.de. [77.3.143.111]) by smtp.gmail.com with ESMTPSA id 17-20020a170906211100b006fef0c7072esm4828136ejt.144.2022.08.29.11.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 11:59:01 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Aug 2022 20:58:48 +0200 Message-Id: <20220829185849.1884517-3-marvin.schmidt1987@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> References: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/3] ipa: ipu3: Remove redundant call of std::string::c_str() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Marvin Schmidt via libcamera-devel From: Marvin Schmidt Reply-To: Marvin Schmidt Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The constructor of libcamera::File takes a const reference to a std::string and clang-tidy's readability-redundant-string-cstr check warns about it: > ../src/ipa/ipu3/ipu3.cpp:330:12: warning: redundant call to 'c_str' [readability-redundant-string-cstr] > File file(settings.configurationFile.c_str()); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > settings.configurationFile Signed-off-by: Marvin Schmidt --- src/ipa/ipu3/ipu3.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index e37b2fa0..e3c1e816 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -327,7 +327,7 @@ int IPAIPU3::init(const IPASettings &settings, context_.configuration.sensor.lineDuration = sensorInfo.lineLength * 1.0s / sensorInfo.pixelRate; /* Load the tuning data file. */ - File file(settings.configurationFile.c_str()); + File file(settings.configurationFile); if (!file.open(File::OpenModeFlag::ReadOnly)) { int ret = file.error(); LOG(IPAIPU3, Error) From patchwork Mon Aug 29 18:58:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marvin Schmidt X-Patchwork-Id: 17239 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B94DCC3272 for ; Mon, 29 Aug 2022 18:59:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5953C61FC3; Mon, 29 Aug 2022 20:59:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661799547; bh=mZ5A/dwYqBmwO3GkG6MkqTcH1a0m6fVilpgJJXRMbbs=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=IYBaXfP2vpcB95maiDrHdtmvPbV75yjw9zab87f8WMz9vQDVpScEucaGsBcjKPD3G Q4aVQFanccDBM503ZD/AVqtaOSoY1xNT8GOC7SBvliG4jICczwGziMZqPwu/JRaHPg Y3S7YZsJsF9CTS0eTaFdg6dIpgQKMfk3vznPEk7e3ZjQOVf+6PBaJPtfcCjgOYxNVB ifKFqgcFRdsa5uLRkIgcpReq7rNESz+njmUeyEy8diTz5Ig6Zmc0MW7VXGala8MotT 8j/VId61Hqqj/guKyYdJhj8+rH4tMfBYvIC3Uz2XlVg6BeMAfPKuWWFoq2jmWuJG6E cOzgPkznqSMLQ== Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F110161FC8 for ; Mon, 29 Aug 2022 20:59:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HmeHBIyN"; dkim-atps=neutral Received: by mail-ed1-x52d.google.com with SMTP id z2so11369955edc.1 for ; Mon, 29 Aug 2022 11:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=P5yH+Wui4qN59uyPB7PWWHAyvw0tGsqkJtFMBz+cyKI=; b=HmeHBIyNkilSXNKAX6wXNqENvd87b8rS/qwvAMYTbQ8E2jJ2VcPg0UVRH4rUxOyEKq EjCSvHPKwcgNTlki4Q6OD+HBIl00lFUvETb0KcsRYl7xGjqfBs0YKcfJwFphGo3pdSWV dhIM6TEU9gO+/Wa21vVyeYvfsxablgK4hqb0AJn2rnnu/nPI8sngoin3qByvtBlNnpKk 7haDGkJ3fofl18RynleaPnOBO8Y7bWfzVwcOfMMe+tP3/qN2+tczBCOg/1bx8I2dBBng tsQxRamb2Ha634+R4tJGqKKmyqHyqGIc/4yeZOpH8m58+V9Qegxz2xJS8aISwXdj1BJm BFpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=P5yH+Wui4qN59uyPB7PWWHAyvw0tGsqkJtFMBz+cyKI=; b=FxSzCdB9DUh/2HdvX0myFb5lnGRFAhvEesGC5TRZTu4KgFa9Oy+ZE6zR0RFAIyAMPc GAuKwE1Wuehqn4lG+lrmOqUPgpC61Y5OT+IukHSMIle4+ux7VPwJl7DCGLFGibuZJ/lG z15r/flwwFscLPxY2jRmniWdA9OxoLZgwKpRDgRvcsHzy8Nw2yFhntPP4dhlH/e87AOD 016Q+ZZ1bLCwtba3ozMivgzn8xcEePqXOhol2LJW6ot90jLW/JKKEDIaQuUQF6vOPT68 hm+08DSYK7p4QGU1pxYFgMWaFKeTBT6TvkGJmQziFpCU8eDHwcli0BDYtTALLZYS8vMC JUcA== X-Gm-Message-State: ACgBeo0Rv2DCuJFuGLYH9wUUHkAS7QrTjpkhy7Wk0buKAqqMVeqg24NT Stce4JT9cnazpcMBtHYlcHcgv9W9q+A= X-Google-Smtp-Source: AA6agR5ZthJ+hAhrvI0EETuYJauUN1jwkzADYS2Xm7j/FKSZ9MQV3zPqSSBcP5U8dAZy8G/zPspQ3w== X-Received: by 2002:a05:6402:1d4e:b0:43d:9822:b4d1 with SMTP id dz14-20020a0564021d4e00b0043d9822b4d1mr17649679edb.212.1661799543153; Mon, 29 Aug 2022 11:59:03 -0700 (PDT) Received: from pythagoras.local (dynamic-077-003-143-111.77.3.pool.telefonica.de. [77.3.143.111]) by smtp.gmail.com with ESMTPSA id 17-20020a170906211100b006fef0c7072esm4828136ejt.144.2022.08.29.11.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 11:59:02 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Aug 2022 20:58:49 +0200 Message-Id: <20220829185849.1884517-4-marvin.schmidt1987@gmail.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> References: <20220829185849.1884517-1-marvin.schmidt1987@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/3] ipa: rkisp1: Remove redundant call of std::string::c_str() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Marvin Schmidt via libcamera-devel From: Marvin Schmidt Reply-To: Marvin Schmidt Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The constructor of libcamera::File takes a const reference to a std::string and clang-tidy's readability-redundant-string-cstr check warns about it: > ../src/ipa/rkisp1/rkisp1.cpp:147:12: warning: redundant call to 'c_str' [readability-redundant-string-cstr] > File file(settings.configurationFile.c_str()); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > settings.configurationFile Signed-off-by: Marvin Schmidt --- src/ipa/rkisp1/rkisp1.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 27b4212b..9e3eb7fb 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -144,7 +144,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision, } /* Load the tuning data file. */ - File file(settings.configurationFile.c_str()); + File file(settings.configurationFile); if (!file.open(File::OpenModeFlag::ReadOnly)) { int ret = file.error(); LOG(IPARkISP1, Error)