From patchwork Fri Aug 26 17:34:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17215 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CDEA5C3272 for ; Fri, 26 Aug 2022 17:34:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9B6C361FBB; Fri, 26 Aug 2022 19:34:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661535270; bh=tIaonYy4IBbM0ubtpXEfksF3Htg5EcUEV2iQclBuypU=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=OiZMOfx7uRGxcESKI4PxQuxYivSJSr4DiyNTLkx14Lo0xKjparc9P1jNEOS9jAyH3 kI7atcgiNZXCftR6xFUT7NpavHyf40MHwmN2FwAWeFsNw7nUVpNLYBWSu9tPOuCd7q +kLpadmiITDihf/NiiG2u3zESTFTC2OdDmJpztAs8u2vT1LUcblvFhwfCZsGtEs2XS UWRu7gTi/lxAOcg+FwVZPvjrjmpuWr3AqnlJRwsdTGHS0LEpxWqpUK3DJRHj934uK/ eSdbdSOsPUrGM7uww273cLSIUWbgSdsHlB04XN5lbOArGrZCSbq5Z9cJEJVDyJyVoS ehVHrPcY8EGYw== Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9367361FA2 for ; Fri, 26 Aug 2022 19:34:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="CchNbTOn"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1661535268; bh=tIaonYy4IBbM0ubtpXEfksF3Htg5EcUEV2iQclBuypU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=CchNbTOnE0oRylwixKeMvEB/7118TvzB3QPitM9djGv5CvscRjgkiR/Vw0ANQFd7L 1kJATTJVbAnfhEZiybJy8Laqq9r1fYnvW36b3o+asV8rbVGsd8A/0fZ83RQmjPnCZt ClVFjZiS+IoAt7RVcKNhaXVtYuBuYiBWVyP7iJ18= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MFsUv-1oe45L0Fzz-00HMFn; Fri, 26 Aug 2022 19:34:28 +0200 To: libcamera-devel@lists.libcamera.org Date: Fri, 26 Aug 2022 19:34:26 +0200 Message-Id: <20220826173426.633461-1-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:FXo0H5VVmz19r/vu7EwLvRnBKeZIMFcKnxGSwXoEEEuEYCDR1up EUWGZEtcp2iM5m2rWgk3TcdD3TwTuPDR7X2FREzqRwT/BpW152Ej7czeOoWaVC2J0F5rLGb NiX+xxQmFTo7U816S5SA3E/xEF5RIrhMB0EDLaN5HwkBlWSZP3pFvKAxzdz5bZuu8lQn3fu vF/JwMCIY+OqITTP4gpHw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:deZ5BzyUbL0=:XwjoL+6jOlqSUqRNbYupQB Mdphj2bNwMoMhJbSLXO17jiRj79Mapw77jdDYi87rmfLbUEKWck2TRdX7SQnfW1v5+zPiSZk2 rYwhlUMi2tLQ6S1PmhR837E3MYqsQ8ozhzZASHhqgK8M0Vq+po5Bn8FBd9oyq8GGb7k4KNbiL Ob9nUB5GMSjIST9irm72fixb0LpY/osq9I3vFQqE/QXfjy2MxazqnsMPZITWqHpR4cvxSvIZI EfwokuBzTMOtbuMwcJuhYBl3885k2R+xAmI3zmYX8NM/W/Ab20f2Bl16Rkhczd9ji/CjbXOib FzDwh3KNz06nG3EfhKY6nC7WThFV2ClO9VxF+CjRAmLNOaZt56nogc3F/oLFYKQLSzqI93d8d z+LbvT+fykcr6mldNKJcS8ROrjDPozPqE9kpm6KPjFoGAo4HjxiwlPzdtuLjkDcLKOwGrJMf8 sS4P9Ou5OCsWcWRA0ellrjKz/MoW/0OPxsbt1+P9cZ8DuG7Gz9F5QJHkJLnHn4f3LNqM9/7De A46WofQHe51g2vkEMzkZ+FruCAtrJFcyAg4RAQNAiY2SuqGleafyJ02hJpMFkchncTHT8vFj9 O/ty3uFtM/FyhDLcEQzq7VjQXnn/7ywpwo24dbG+epoqqS49b2r8CUdVYQA9XNblTa1HNOVy1 GSixA7NW2bbzump0QIaSqQ1ioT5ByGqQx+JzZVnSvp6H6BVoa4QMr8FnsRy4GNrf1qwv9q63E mbS0DHrvQT5MPEH2hMEUETogxkrEuIoyTHVD6r8wwCN5Lo685UFGxGchJVp94EwPOb62RtfFc j599PnZQw8nRKJnZEyWo0Ryv0+XvwGwwk6xMRCRLN4pu6y7pHMy/I8ym65J+eie5GcbH8afD1 PR8+dunM17YF/v+Ks9nIp0WG87u2kiKbpUr9n1UqmQW0Z+4ID0vw2bDi3efKMNzcmsN9YHc25 /RTF/RUDALs3r0LTIFt4T+eQEMFO+H+v8zKBkkMzfuqcuPXueASZq02MPhrFVZ3TF/ojO+C20 aWIBZ90gdvlJLe4UCq27xAZbYUo955cVGBXFNAgdHqGvEOFSGpLk26Uqsx8cYGgSG+6SB3xl4 hOe96eEX9QmvXgRnODWc6Qz2Wl7+qetz597YMhg+IyMUsJntsPbRi0mEg== Subject: [libcamera-devel] [PATCH] libcamera: control: initialise control info to ControlTypeNone by default X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The default ControlInfo constructor allows to partially initialised the min/max/def values. Uninitialised values are assigned to 0 by default. This implicit initialisation makes it impossible to distinguish between and uninitialised and an explicitly 0-initialised ControlValue. Default construct the ControlValue in the ControlInfo default contructor to explicitly represent uninitialised values by the ControlTypeNone type. Signed-off-by: Christian Rauch --- include/libcamera/controls.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.34.1 diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h index ebc168fc..38d0a3e8 100644 --- a/include/libcamera/controls.h +++ b/include/libcamera/controls.h @@ -268,9 +268,9 @@ private: class ControlInfo { public: - explicit ControlInfo(const ControlValue &min = 0, - const ControlValue &max = 0, - const ControlValue &def = 0); + explicit ControlInfo(const ControlValue &min = {}, + const ControlValue &max = {}, + const ControlValue &def = {}); explicit ControlInfo(Span values, const ControlValue &def = {}); explicit ControlInfo(std::set values, bool def);