From patchwork Sun Aug 14 09:52:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17113 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8D9DCBE173 for ; Sun, 14 Aug 2022 09:52:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CE75261FC4; Sun, 14 Aug 2022 11:52:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660470766; bh=2VCDqkBTNTL/L+YBxAMnyQgoAR276osW/Tm6mF4dY/8=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=CZ7VfIoSkYNcnU7unlFdB52gw8Lkt6U1lMI970jzsIN9Q3v//9Z9kzHxjtoGD5MXX vv/Hqh+roIqB3RJmtF3zoQK/KqnzaGZ4esAaoe97K50SDuQi6elG55LH6NghLrh4wP YKAyzMigLh/CilMBemZfX2AvSv5cT4MjZlcWOIhl51Suw7udaByIYakRSUhQib05eH xPcx5dHbXJPnD7yt0OUmO94S4L9MM8PD1C1TH7IUjBHBBTgtsbfrlj55Ff7Apnazc9 JLgzQ+Qgkd7HNQ2VVS7BZG4iSK8K12NsJ+opP/+qmQ/w4e5jmZ0qVYPgBImegT3Pqd 53H/UlaikegoQ== Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 34EDC61FA9 for ; Sun, 14 Aug 2022 11:52:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="N0wDs6Gv"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660470764; bh=2VCDqkBTNTL/L+YBxAMnyQgoAR276osW/Tm6mF4dY/8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=N0wDs6GvK3f16U2YH7PXBFAtNJnpMUqhTBfBak36NPl/8TFiFK5ZoZh5Belo1MIOh l7EUlwJS65S3ZWt9tTK0wLJS1LwUyvOhltQXangfxTGOOiEyd2QMmflTgcIs5mEQou penAd+lSb5EgUxCcfjzkJ6be6YZEFMPUpHqBuqhM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7QxB-1nIBxx2kt3-017nI4; Sun, 14 Aug 2022 11:52:44 +0200 To: libcamera-devel@lists.libcamera.org Date: Sun, 14 Aug 2022 11:52:39 +0200 Message-Id: <20220814095241.137108-1-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:gNXOv+y9dSFQcZlbhkTl4JwllgIEOaEy6PyzqAc6G2r9sNSspeZ BFTCOeFnaE/u7CnM/uVvpNJA27Kd9xiiXJujPSn6kPfyHiDbTqq4sZyN4rGVtBeC5Q2AoU6 bVPMJbRrgnZBV7J79Cu+g2VsLiMQrng5sdQDs+r2qbqg0GM09phnATuV89SbDRuuXTOxp3j QiPXvc8/ZCnkSUMLWFNEg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:OAjEyghh+2k=:FhA06/zsld0KAAwMJYP5Sw qHasd7E2JDD4VG2whoDA7+tNrqKAX1uyBKTDoAc3Nw/7Ms2ywWsADeePBFJgF9utJbe2B+7a9 VpGtTlu6nL2MCcNHGtliqGfFDx8UXfEQjzEZVX0BtwfWaasll+F+8Rp2GpXfCET9U1CwSsLJD gwXMmVGArHT3F+jfGXeV52hXhDIIiNNzwxZvv3Q1vOH8QoqsaNmVh5DqusPLtvcYDhSLzvili yjAwqpvuzK/Q6kyCjatrcGoS9Dd/m/iDRiGQsJHTCl3gfGumsALtcRhyLkZYVVXLSkC3tEQ9h 0yvtDs6T3k+LsBMaAvGBkUUhg/7FkkO5tViZAIuqVhK5y0lwfWLw/tFdVLIxGqUsOox6DLiJE bmoVT8SR3FscfkpPPpP3zo00aMSsX2KwJadUSGEt7MLtDRUDL10y227+GCMjqSUd/FkyD7TS6 WyGaws+y1XsRQd2gBNzb38s66d2peBFcMacIcQ00mBaDhvC47XC6HsXuFmPVEZokRTVY3JJ9/ hN1Orrn7iANleHiU3Qik/goxaZofRDtOBZ/FhF0lCzre5TtRwasvv5BYijNngonCe1pnmWoX8 LYPG21t36xGjU1QcjQCGpTSJrfdYLfshCYNqjFWuCEYIbBEy3SrV4Lzy2rBgPeUUsCqGdQmGL As0LC+Jpese5gW8MmBwvGkAbiXwH/HHNqQCNT6LugGtYS8ioaMbNSiPtREs11zbcmP6+K/owK MJxxOCogOLoBIjUF89/w/Kxj0IKF4CmFXYP2K8vnbfXlKQgJoNpT1kM5vAAon8wyP4t8Zsm0N yz9+G4g+hYLAJJVDF/iC2uOebVb7vM5DylwSk2B5OOJTZ/3qCScmFanMPzX1EJenhSwd3GuZj fyvSU1dQpx/8brLb6vUFOSLA4E0dT2k1W5UBYpiVKu4ae2UAKDXAY42YVkM/ArzV5yCh3u0ko fhPU6FqU1/dmejAGIxPKxVXKu+p5LaCe1f5SFONb3SP/ixuLANQSFff/rPv20FG+5uh7zpTpp iF6To4cygItG1/I1IT2gFW2Rw3S7w1JEjZYGw3FTg6gv1Alh6tW8n1xneKDI0bm9v3sOC6DO/ RrpF5WZ3EatSqq4TX54C4H4DZ65BvUCo+rJ0SnFO5BvNpj7wA4g/Gq7bQ== Subject: [libcamera-devel] [PATCH 1/3] libcamera: remove unused header X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" --- src/ipa/raspberrypi/raspberrypi.cpp | 1 - test/serialization/ipa_data_serializer_test.cpp | 4 ---- 2 files changed, 5 deletions(-) --- 2.34.1 diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 69c73f8c..8d731435 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -49,7 +49,6 @@ #include "geq_status.h" #include "lux_status.h" #include "metadata.h" -#include "noise_status.h" #include "sharpen_algorithm.h" #include "sharpen_status.h" diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp index d2050a86..377ecdb0 100644 --- a/test/serialization/ipa_data_serializer_test.cpp +++ b/test/serialization/ipa_data_serializer_test.cpp @@ -20,11 +20,7 @@ #include #include -#include "libcamera/internal/device_enumerator.h" #include "libcamera/internal/ipa_data_serializer.h" -#include "libcamera/internal/ipa_manager.h" -#include "libcamera/internal/ipa_module.h" -#include "libcamera/internal/pipeline_handler.h" #include "serialization_test.h" #include "test.h" From patchwork Sun Aug 14 09:52:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17114 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C30F5BE173 for ; Sun, 14 Aug 2022 09:52:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BA4F861FC0; Sun, 14 Aug 2022 11:52:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660470767; bh=pWdY2dowanLkW2bDf+ucf0b0pk9+ac7LeGPx1pbp6ec=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=GYoKlHCNbmaT/I972mbnDqXMFfZo6bBl21aH3HpzH0ct331YXeqCYKkuNZdCa3bPj mr2JP0C8sJHUJqf6aog98jbGMYrPmiSTdK4oUDlnvw1B/8JoBa6OgB9vUBRS4lSYDt C3CDTMpQv2w7fz3+AMvt5mtkN4hHM6lVpSqiFTLaJCPgh1jG4H4RzWlvhDd0ka+UG7 YlMeXmJK+nW64z89JwFXTzgV2DXGUvHdJnGdRo2ycrJou3bzg4VxaiK0NjAxeK3jbQ xPdWeUzsrCXcs3s4cFj6dwvblPd9HhGSD8hCyaKjej9ers9JYIEBR0Ga2bb3osCPjK U9iRdXVYvZzhg== Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 531C461FBC for ; Sun, 14 Aug 2022 11:52:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="KowgvpBF"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660470764; bh=pWdY2dowanLkW2bDf+ucf0b0pk9+ac7LeGPx1pbp6ec=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=KowgvpBFV6GhVnQM6COHpm0wRHhn6t0OGFRNSIRt+0OB3FrQSOTpUW1HXU6LpavcC ECZuRaBakciezO4LeVXNvz3rVH7VRytBvhya9qvzwsv/Wo0mNtz5IhUeO6FIcvZ5rb uvK5MeLf9+l8YsCyWL6+qWDNJCWbPBLXfnYwc82c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiPl-1nvuUr3JgD-00U2cW; Sun, 14 Aug 2022 11:52:44 +0200 To: libcamera-devel@lists.libcamera.org Date: Sun, 14 Aug 2022 11:52:40 +0200 Message-Id: <20220814095241.137108-2-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220814095241.137108-1-Rauch.Christian@gmx.de> References: <20220814095241.137108-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:fbbDokoiDVIT1w5A8x2PsuTeA6fx23frg30W1Pu0GFkk7xRfFo4 IIoe2f7/OcCaz+yjoA6CdsX3ShszkzbwaKNsUm/XgqsHuBEWTSTnIFghiPpYdf+oXcROkaR 5WK/sPudVjL6yBS0ngLlPEcY0kcENXxd5V9nuIZ9PyfcKNhDNLaknkGelkNO8kvPmYH0XKJ UgWy0wAUKVEabXeoyP3SA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:leZXziZQp7k=:G263lVL7dvy8omkt2DOobt 0jfB3BtR4dQ7sD4hkLig2qJgq6GqFEP9xGAaesUodt4eXr2tk617bgqMF7SXK0mHztSEeJiqi puaKFh40nUcQiuf3X5qcLrelzdWBnAcSB/2qVrNDxunL6fjyxfu1GTSlBz6XWlN0vqLELryPv e/D7Q5GXo4We8d/n/1erCaxZeulIFsb8fVfaMTmnJzq97f2AcYn0iafJSrsqyjm8LkB3V3Oyp Ce8GMM7bEEKMzrqhDuBpsM/7JOE/htcLBkdRndOsfvOCg0+ma2SfXuiXr6VzgwKqU3+E6fPAF wDU5NG5bA1X3xE4uXJWHywAK6lIEVGdCawVZiB+HrQ/4Q87Qtj2jWwMK4W/lq1Wq7Q/2feE2g mj3mSOJAPUQACO/rb3OnB8xjp/rC3gUgWCuHdZAD2lpZ2Y9uvavo6HSULCvXrjx9HX7xVn2Ae Vzxhu0zlG8RyjKJLDQX99PareajR6MCRn5cwki+409J5r7MQAGLBbU8DIs4a2QAdqwyzT37Yw 6EJL+CIke/uLxaGQO7abcv4Rt0PgcmPxlaHKQ/DliBfDoHVm5EWkT/xjZSvwCBx+xmwFiBz1A 3kWyWE82heNrXeWWM66KUbcBq1Qm0Ih8ctFDSFAx2UxXmTXZIPJFSJjg7+A0EU30bwoAUL5OI 1YS7Vkt5tjY299BMyOrIVFktrZWkGRjRWoV558I2jm+GuRoomNEI4eaLId7K5fQb5N3MFPvwn pjhwkbD6uRwxLn9oxwGJZcw8xVgtIzLEvouKdUXxHFnN7fRAkqEXdyEaEpOC0n0WKPhCMWTEA 8q5g0Ruw3z49tv9u2jFnAoVYZU47oS/oOM8IN9hwpHkTBgVE9bdVUHCwldGVYSHyMSlyviRSl n/Dt/MySksQd2oqSnoHdN6vtH8OQ7q0bEgYMNOrX6JZtgjllvRGhWX/MFMi5R3muROa3b6LnN JPYo+tlu0FjTXdkS+hwsiPTBP+a8P1oC7l3/5VReVJR9K0TM8rOKeGFqEjwjJqgW7TrfTSYWL h8zq7UZJy/kMdAzD7XfIprteWaZv9nWS8rnVAryrUeS//ilzx7I59vTovPEfAAbkpgO/Pkub1 vAzOZMJHmL/FoG4YphtLxipXV+R9ADoGOl5lpBsQkfFbGznan3LiEQdmg== Subject: [libcamera-devel] [PATCH 2/3] libcamera: use const reference for range loops X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Christian Rauch --- src/libcamera/camera_manager.cpp | 2 +- src/libcamera/device_enumerator.cpp | 2 +- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +---- src/libcamera/pipeline/vimc/vimc.cpp | 2 +- src/libcamera/pipeline_handler.cpp | 2 +- 5 files changed, 5 insertions(+), 8 deletions(-) -- 2.34.1 diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index 70d73822..7ff4bc6f 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -189,7 +189,7 @@ void CameraManager::Private::addCamera(std::shared_ptr camera, { MutexLocker locker(mutex_); - for (std::shared_ptr c : cameras_) { + for (const std::shared_ptr &c : cameras_) { if (c->id() == camera->id()) { LOG(Camera, Fatal) << "Trying to register a camera with a duplicated ID '" diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp index d1258050..f2e055de 100644 --- a/src/libcamera/device_enumerator.cpp +++ b/src/libcamera/device_enumerator.cpp @@ -161,7 +161,7 @@ std::unique_ptr DeviceEnumerator::create() DeviceEnumerator::~DeviceEnumerator() { - for (std::shared_ptr media : devices_) { + for (const std::shared_ptr &media : devices_) { if (media->busy()) LOG(DeviceEnumerator, Error) << "Removing media device " << media->deviceNode() diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index fbe02cdc..0306f56c 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -340,10 +340,7 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request) { ControlList controls(data->video_->controls()); - for (auto it : request->controls()) { - unsigned int id = it.first; - ControlValue &value = it.second; - + for (const auto &[id, value] : request->controls()) { processControl(&controls, id, value); } diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index 153cf849..d2f2e460 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -378,7 +378,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request) { ControlList controls(data->sensor_->controls()); - for (auto it : request->controls()) { + for (const auto &it : request->controls()) { unsigned int id = it.first; unsigned int offset; uint32_t cid; diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 7d2d00ef..e5cb751c 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -616,7 +616,7 @@ void PipelineHandler::disconnect() */ std::vector> cameras{ std::move(cameras_) }; - for (std::weak_ptr ptr : cameras) { + for (const std::weak_ptr &ptr : cameras) { std::shared_ptr camera = ptr.lock(); if (!camera) continue; From patchwork Sun Aug 14 09:52:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17115 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 81DF4C3275 for ; Sun, 14 Aug 2022 09:52:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6C46C61FC2; Sun, 14 Aug 2022 11:52:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660470768; bh=3kflEUfW2klgdCpg1xHCMM/wJ38hRngrQoDQPaL8P4k=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=SEOd7gGtdWPDIz48ZRGpD3M47NcfxfnL9fkqxWlIw9nRB8I/EXi6jdTeSoD9udCLZ u4zGb5JFpY8MDR2+XqVsheythl1NTv6I/xJjnteeV7P6cZH4dIHQejpCtlJl7ZX509 WFnIyA9eg5uc7+2ctEA8gTYxPanmmaPmnpI+yBG8TTytXkIPLItAT+Zw9W/uv58IR9 OExUcpUnFRc7QbVAhFA8EmbHtrXss9FD7jMu0Kdo8FaKyuhGvpuypsX2mr88mZ/oDr 1pLxzPhjx5Ql+eNi7ppmWNsjFN7oo7wIMsCnpx4CswN9ny7lPfO1bw7ww8aa0LUo8x +CQQWflaraIdg== Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6999261FBF for ; Sun, 14 Aug 2022 11:52:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="VNQ8gKC2"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660470765; bh=3kflEUfW2klgdCpg1xHCMM/wJ38hRngrQoDQPaL8P4k=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=VNQ8gKC2C4lHPqKWB9Q0M2tQGfXdTfHsBJM4MoAROVJkejSnndJL59w+jI1caaDB+ xcwUsmS3E9fuTYshWTF+o1XjTxLidZ8Op7ljlfLg7wTVCwiwuNIXSD/l9KuiAB64ps 49+bksXrzFSqyK/VzxMRbP0KYHgkBv970878BWgU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MLiCu-1o5UtA3v1s-00HiPB; Sun, 14 Aug 2022 11:52:45 +0200 To: libcamera-devel@lists.libcamera.org Date: Sun, 14 Aug 2022 11:52:41 +0200 Message-Id: <20220814095241.137108-3-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220814095241.137108-1-Rauch.Christian@gmx.de> References: <20220814095241.137108-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:e4kj4DJS52VG5butfbX6FkOomioyEiRYCW1UJkJve6M9sguQZth k9que8dkXOYtIDJKPu9HzwDKaVq/5jGBM8fCY5oGWKocJWxuRxyDloOu2Bw5s+86ujd9E3X 7qbXxrPo1ct4L3PQyzTA5E7z+H0o94TlEAlwxHEw0C+AS5zfLCl2MGxxeVfutYXm/SVXGb0 vXU3Dq3kdlzfAFqrO5GaQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:cihOjB1UZxo=:XYhKjNq4FhNLpBMstgIAmJ kUdtzXNX6DK4AMuBFAIGGmsnOnxz1eGoQUj1P69xtwTREvDlRaNM2RdHV60ll82omoHKP66AV 84zRqUzaajGuF5IoqkDjGBP7lGAnW/FPNjfdS0MUcmh/uOQhgTV8YocuANy4mfQD6Q+G0SYDA ogs+Lm6FswZZ30/O6E/ZcdCACq9N3Ow2jW+ZD6YMt/TnIywCQPiAtpKef2lo+c0ogeIB2UY3r vV9G12NUcIY/FWF4+3DD7XRhNfEWxSXYZsYG71ql39VQssqUSn53MBhq6xL5cVw3W+vnZfq2i 89KHq3d7bxiSgdsMIeD2bsVTnCrKnGEy+6T19B7MtoVoPSNgJcS7NdRr+cX9e5GVa8QVz4EAQ 9er7e4hP4Zy3cDkS1wvLVbiKU+fkB+GHB7RiETRpBXUU5a7eEHds5xqrs63Phx/YgPbaRMiN1 1xamQvJ8cVjhXmFxO1wJC/KYHOMdm8H0oQQlaVakv8VSK4ZYj9q6f8zbdg5abAGofTNc/9HCM K1yUH6KTKhUbhCfsYMOwp2L1wYe7ARzEEWU67vM1iPaeLICcqwprV13OUdAw3eBSTKK7YMC9/ 9TgLMvsX/YZ1fNDbghzVLZsgtDAi1WDOJQnVLjqbcyHxL46hFtofOImBxnE7r+/WQO+00aH1J tRp5gBrloiSNkePixn0kyk4+7ymsdY0Yc6VfEmh0ssB9dFyyR3ZF1v+tZEp0nCRMO0JJboH+U 0MrpYskYQ6G9QO9gFLeSVIST2TVDOrGVgqVdjpTDN7GJ0xrB1M+SbZJ9SD6H8YO6xpBt8SiVo CU+XpO1ZTVYaCUmb5rJgyXE7RQ7646GS02SfdiCLdcodsEigMqZatIXDru7T+dMx81UWn1rXM KhdMpQdtmiUWvr5YWYbDipZ4SjxrMRxtlEgreK51LQnpGj6TUwlKZkw+qDIWdx0Nq7cEhXvp4 Ka47xDlbeIBKpS1ptf6oC7x9kAQLAUfLfmt5qhVa0VGpcBeayDLec1cqinamxVk9VWCURg7qd nrkKKvKnXrmmRvPDbJrfEjvDAsru2nJWYKBqIegLH8fYfRDcFvTos+CkYo+2lPzj4EG6lH7Ue fdlMQM5pDYGqe1hQxFCnH05gnp65QSaOspYzEWBF/bPQMlsWPftkUftEw== Subject: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: remove unused assignment X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Christian Rauch Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 - 1 file changed, 1 deletion(-) -- 2.34.1 diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 93287332..03bbe6b4 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) /* \todo Turn this into a hard failure. */ LOG(RkISP1, Warning) << "Camera sensor information not available"; sensorInfo = {}; - ret = 0; } std::map entityControls;