From patchwork Mon Aug 8 15:19:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17025 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1FA2EC3272 for ; Mon, 8 Aug 2022 15:19:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 49C9D6332B; Mon, 8 Aug 2022 17:19:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1659971970; bh=cvRy7+V5wIPAWKnef4qBm0Cs9AYoHmxNurZWBb2QiUs=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=J7Q8rvp/Ur2YT72DPUDNmiLbFw6pUM7z6ZQo/vROkPEnK/8oU/Q0vVsdflryHe9tx bNz7AgvN5uDkPahKC3NlcAz+/oWWygS/Fo9ruHuJ8LcDqsLLuFD8o4/bZuk7YtP7RO OD1RVeW+oZn/uuzq7Fp2HvCRYnVrUOHSjMwAmHhMda/Az7l/QqLlluRDCvfUvm+7Bx 25BjohEGaJSeQGnifROCJgiomD3zE7Ns/eN7VAMTbDnxqiuSnh9NxJapJl7ySupiZt +VRq2ETSzpWkAtB78vnKa6/ZsJSzBF+JyQ05fXwd/yZkJayK29w+5pNH9u6XcIPude Dp8CI6rTW8Dkg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E2A063315 for ; Mon, 8 Aug 2022 17:19:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DG7k4wTL"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FDAB481 for ; Mon, 8 Aug 2022 17:19:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1659971968; bh=cvRy7+V5wIPAWKnef4qBm0Cs9AYoHmxNurZWBb2QiUs=; h=From:To:Subject:Date:From; b=DG7k4wTLuPhuwtaGQ9+jrj7HaQocHYfy7gdgqYX0k4SmCaa+jFz/3raWlLOxI4fdP pCAqVVnq0mTqGSWdnwnZbUJBG0iAzBwZVB8rDNIcBPtSZTxyysTqQBBRl3pkVAbw1V gbe8ez9dNkELj3UKJXpLipJd8GSIeejgRiFXyuKw= To: libcamera-devel@lists.libcamera.org Date: Mon, 8 Aug 2022 18:19:18 +0300 Message-Id: <20220808151918.25411-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH] libcamera: base: Make message.h and mutex.h private X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The message.h and mutex.h headers are not used in the libcamera public API. Make them private to avoid there usage in applications, and to prevent having to maintain them with a stable ABI. As mutex.h is used by libcamerasrc, the GStreamer element must switch from the libcamera_public to the libcamera_private dependency. Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- include/libcamera/base/message.h | 2 ++ include/libcamera/base/mutex.h | 2 ++ src/gstreamer/meson.build | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/libcamera/base/message.h b/include/libcamera/base/message.h index 65572c7470e9..b939af6f79bb 100644 --- a/include/libcamera/base/message.h +++ b/include/libcamera/base/message.h @@ -9,6 +9,8 @@ #include +#include + #include namespace libcamera { diff --git a/include/libcamera/base/mutex.h b/include/libcamera/base/mutex.h index 2d23e49e4546..52441c55287a 100644 --- a/include/libcamera/base/mutex.h +++ b/include/libcamera/base/mutex.h @@ -10,6 +10,8 @@ #include #include +#include + #include namespace libcamera { diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build index 77c79140eb37..eda246d7ffc8 100644 --- a/src/gstreamer/meson.build +++ b/src/gstreamer/meson.build @@ -42,7 +42,7 @@ endif libcamera_gst = shared_library('gstlibcamera', libcamera_gst_sources, cpp_args : libcamera_gst_cpp_args, - dependencies : [libcamera_public, gstvideo_dep, gstallocator_dep], + dependencies : [libcamera_private, gstvideo_dep, gstallocator_dep], install: true, install_dir : '@0@/gstreamer-1.0'.format(get_option('libdir')), )