From patchwork Thu Jul 28 12:04:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 16861 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C718FBE173 for ; Thu, 28 Jul 2022 12:04:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3092763312; Thu, 28 Jul 2022 14:04:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1659009884; bh=0t5K11BgVW2Vl7fuyB2H5B3oFysoskwssOfkg0NQb5g=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PC+JugG7QZ9kkCgPEjUiZN8TrCI/spiarmNypgp1rGg1Q5PJ37bbLn5BBuIWi50Ny dUhg7mC7mWmhWn2nU4V+AsmpKcYr+w2qHUiN/h5TKnPwaOF0uheBE5fZgDvpCt1o00 oxFY39ar6vMPZEGr9WABoIy3sBmpfk8az32P66MUOtyzvLNbbPzEHGU26cKPE52U31 P98zpcY/1KRZ5YM7fDNA4S6vZ5sl+BwxNCINpiW3WGBCwHB4chK9JITT17Q0IEmJIA FGJ55WuuJFamevbTImAFoH8YQ6ziwnxFp31INqOn1BrK7FDHFH9/kkFzCFASpj/BLw 1yeBflCp48aTw== Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CAE916330D for ; Thu, 28 Jul 2022 14:04:42 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="JQuvz3ux"; dkim-atps=neutral Received: by mail-wr1-x42c.google.com with SMTP id l4so1882253wrm.13 for ; Thu, 28 Jul 2022 05:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HhIv6k0CHJvTBvoaKGV0JcjDyNE1CjTk33FdaEsfZX0=; b=JQuvz3uxA1x2TRzeuFFmAAXL7MMB6uqv+9OX2yivSEBjvJfehZWMjgdLggU4Law8OM ZGJg2An8kpBpx8HUtAEGRKLAOpHVw70Nh17t6cAw/Uf+YXdEd+gSdjHIsVEabThhXAwk 5KCy7ccbJ6DogrET6UVJFH4J1LldXgJjUKurE35TWOGRlN8uic7qczNsZPie9T9jTVRy WjEDXvct2JVam+jM/p8hrOKE3ROezUyGCr88opEm+42y6kxhwKiciP6u581wIQzm2JAE tqnvYU6V1SN3VHeto9IlJc7fTpvmWgvNCxYZFVuzDYE1GfDZd9bRki222T2GKBcyncpR Tc2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HhIv6k0CHJvTBvoaKGV0JcjDyNE1CjTk33FdaEsfZX0=; b=XvYsuUrG9HqA20zK20fjws+7LJxE42ziwqVwHUgTB+2HBK1r3D0TI04QrZQU5nQ+HV g7gP7OnhrjOgH9oemjImKHE8565JBejKzYWP8Tx+IgkZyChDYKlodVOXiMfYxRzMo9t4 6qXVJFWVcLMFvPwBVHsAY0LpA0O8xDo8bN9XcxdJunCSLnJuPlXJt29mQC6+Rd1hyrhB vkTEgs2FWdSV58vGPMgwbsFd2NnCUob0YE45VCowp+WkRqHl0NnuKiSv9LsTOG27dxMf F8xlWYmkIOLOiRMRX/u+0NVDGvo+jKwvUpbRygD4Xc1ct+N7Ljs909n8X7lrL7/YlGW5 bkgA== X-Gm-Message-State: AJIora+cX/oUih0vuQyO6JCQO4GPuLdmOoVZV8/YFJ0X0HXxuZHdaZGZ Cobr5/qeRbjjo4jvbv6xFGuwyllb9h8RKg== X-Google-Smtp-Source: AGRyM1uaCrYjFxkj0f6wflQ/y/hHbRT9DgXKiukhD1CNIidtAwsb1LDcvAw68rlZWHXQDPApA52JEQ== X-Received: by 2002:a5d:6d04:0:b0:21f:877:e2ef with SMTP id e4-20020a5d6d04000000b0021f0877e2efmr1139136wrq.131.1659009882098; Thu, 28 Jul 2022 05:04:42 -0700 (PDT) Received: from naush-laptop.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id d3-20020adffbc3000000b0021e297d6850sm686531wrs.110.2022.07.28.05.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 05:04:41 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Thu, 28 Jul 2022 13:04:39 +0100 Message-Id: <20220728120439.4109-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused Controller constructor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The Controller(char const *jsonFilename) is not valid anymore since Controller::read() can now return an error on a failure. Additionally, this constructure is not actually used, so remove it. Signed-off-by: Naushir Patuck --- src/ipa/raspberrypi/controller/controller.cpp | 7 ------- src/ipa/raspberrypi/controller/controller.h | 1 - 2 files changed, 8 deletions(-) diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp index bbd382bce3ab..f489278668ef 100644 --- a/src/ipa/raspberrypi/controller/controller.cpp +++ b/src/ipa/raspberrypi/controller/controller.cpp @@ -25,13 +25,6 @@ Controller::Controller() { } -Controller::Controller(char const *jsonFilename) - : switchModeCalled_(false) -{ - read(jsonFilename); - initialise(); -} - Controller::~Controller() {} int Controller::read(char const *filename) diff --git a/src/ipa/raspberrypi/controller/controller.h b/src/ipa/raspberrypi/controller/controller.h index 6be1e3cfa156..3e1e051703b3 100644 --- a/src/ipa/raspberrypi/controller/controller.h +++ b/src/ipa/raspberrypi/controller/controller.h @@ -40,7 +40,6 @@ class Controller { public: Controller(); - Controller(char const *jsonFilename); ~Controller(); int read(char const *filename); void initialise();