From patchwork Tue Jul 19 21:01:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 16692 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 629FEBD1F1 for ; Tue, 19 Jul 2022 21:02:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9BA7563312; Tue, 19 Jul 2022 23:02:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1658264546; bh=GIG/53qLLQ1J+ZkYGomi9mZ9uGs3z03uwzigHj4YWU4=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=kotrAr/YiyPhj4+8Be9HD0PrBK3+u0qAlS8DUM5Rw85grQkTeZltetCa2qA+lK1q6 EwZTFIZWlu6894oQ8z0BW4Vf07AhhdC/3CxKBs5V8vjsvrj5kTm0n5NuFZIJwTu6Z2 vOe11MNZc+dIIPOR+8lS3rb9exwbUkYIObkDGpO6FkexaTW6Mkvrn5TrZ3aI+CTBHN xLfLtn2YHoKmRRStVGOlUGhWJIyNB7Nyafti4/OtrkidK1pLsJb1vqja6iXwqEtOsQ BevMjGa6+o5APSsyrYFi9QtuvkXFnomHOgq8u4IV0/3xqMdAmC3dqUgabTdQBRMPqN Xx2EjnIyQAf9A== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 47688603F4 for ; Tue, 19 Jul 2022 23:02:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="umnuLi/t"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C00836EE for ; Tue, 19 Jul 2022 23:02:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1658264544; bh=GIG/53qLLQ1J+ZkYGomi9mZ9uGs3z03uwzigHj4YWU4=; h=From:To:Subject:Date:From; b=umnuLi/tj21c+1czLoyh6KVXGj+p1VT59rpwji0HqNkuK045f/q7vCGJgGBJF4MRs figSs+AGWWmOgywSV5XIRbKYOZOotKcaGWYcj4asWzhdX7nxOwjsswXblwpxHLcmC5 6SnSFDhKjtypSVm77WGaxDPZyG/Tiui6pJfGMmrM= To: libcamera-devel@lists.libcamera.org Date: Wed, 20 Jul 2022 00:01:48 +0300 Message-Id: <20220719210148.4588-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: Remove extra ':' after '\todo' X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The doxygen '\todo' directory doesn't need to be followed by a colon, yet a few strayed occurrences have made their way in. Fix them. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Paul Elder --- include/libcamera/internal/delayed_controls.h | 2 +- src/ipa/ipu3/algorithms/agc.cpp | 2 +- src/libcamera/camera.cpp | 4 ++-- src/libcamera/controls.cpp | 2 +- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- src/libcamera/request.cpp | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) base-commit: 62e32042aee4042b6a931bc27a6ad11384b521f5 diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h index f560c823d4e9..cd3ca8070278 100644 --- a/include/libcamera/internal/delayed_controls.h +++ b/include/libcamera/internal/delayed_controls.h @@ -51,7 +51,7 @@ private: bool updated; }; - /* \todo: Make the listSize configurable at instance creation time. */ + /* \todo Make the listSize configurable at instance creation time. */ static constexpr int listSize = 16; class ControlRingBuffer : public std::array { diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp index f16be534dd71..5bc64ae52214 100644 --- a/src/ipa/ipu3/algorithms/agc.cpp +++ b/src/ipa/ipu3/algorithms/agc.cpp @@ -229,7 +229,7 @@ void Agc::computeExposure(IPAContext &context, IPAFrameContext *frameContext, /* * Filter the exposure. - * \todo: estimate if we need to desaturate + * \todo estimate if we need to desaturate */ exposureValue = filterExposure(exposureValue); diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp index f8150dcdc788..2a8ef60e3862 100644 --- a/src/libcamera/camera.cpp +++ b/src/libcamera/camera.cpp @@ -184,12 +184,12 @@ void CameraConfiguration::addConfiguration(const StreamConfiguration &cfg) * This function adjusts the camera configuration to the closest valid * configuration and returns the validation status. * - * \todo: Define exactly when to return each status code. Should stream + * \todo Define exactly when to return each status code. Should stream * parameters set to 0 by the caller be adjusted without returning Adjusted ? * This would potentially be useful for applications but would get in the way * in Camera::configure(). Do we need an extra status code to signal this ? * - * \todo: Handle validation of buffers count when refactoring the buffers API. + * \todo Handle validation of buffers count when refactoring the buffers API. * * \return A CameraConfiguration::Status value that describes the validation * status. diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp index 03ac6345247c..840bea4b92b8 100644 --- a/src/libcamera/controls.cpp +++ b/src/libcamera/controls.cpp @@ -908,7 +908,7 @@ ControlList::ControlList(const ControlInfoMap &infoMap, void ControlList::merge(const ControlList &source) { /** - * \todo: ASSERT that the current and source ControlList are derived + * \todo ASSERT that the current and source ControlList are derived * from a compatible ControlIdMap, to prevent undefined behaviour due to * id collisions. * diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index d60f20b08e27..4fe52f74a68c 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -552,7 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c) return ret; /* - * \todo: Enable links selectively based on the requested streams. + * \todo Enable links selectively based on the requested streams. * As of now, enable all links unconditionally. * \todo Don't configure the ImgU at all if we only have a single * stream which is for raw capture, in which case no buffers will diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 07613cb33709..d2af1d2212ad 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -349,7 +349,7 @@ Request::Request(Camera *camera, uint64_t cookie) camera->_d()->validator()); /** - * \todo: Add a validator for metadata controls. + * \todo Add a validator for metadata controls. */ metadata_ = new ControlList(controls::controls);