From patchwork Wed May 18 12:20:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 15944 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ED402C0F2A for ; Wed, 18 May 2022 12:20:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1EB7365656; Wed, 18 May 2022 14:20:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1652876435; bh=zKdAJgZVtAzgMmF8fx7vtM7+OxvIGJUUHDzJCGFPRhQ=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Ojb27QAkZKKYDnqyU10nd/0RVA9MXNPP8WZa0wLzdmrtIbFqjGzpeo4nSlRGsXpTI nmtGpeUGGLgXtVrKkno/7jwmiZE0T/6cBflJHL/w+zWcifCyzXivXhpbweimMBORKe xWVVJ3z9ypuLuVUiSuKE1EdklEyrIk/s/tEuBI8vAtYnaYeS9Zxfq5RFccoY0NA2zC ifQD+pyeE14N5MwccyoYBJX3Jkmr4aDsUW7IwJ64vQYiww9U3+wfzMBAehRZz5pWeB TA3QWbrO6tQHzcYSi4gfiiKiK+NwknlVKKQrdqNyjYxFMW5RLlBVuAqiuQhVlTVOeO h5RYNhz3iQI3w== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 06CC365656 for ; Wed, 18 May 2022 14:20:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VPDo5m1G"; dkim-atps=neutral Received: from deskari.lan (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 52FCEE50; Wed, 18 May 2022 14:20:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1652876433; bh=zKdAJgZVtAzgMmF8fx7vtM7+OxvIGJUUHDzJCGFPRhQ=; h=From:To:Cc:Subject:Date:From; b=VPDo5m1GOy/df6Sp89p76FtPWC7yP/7FENiECtZWCSi8XyKluB8KTRr2jGEZR3zkt nI4K2Jb9A2DTDV+C76TvXtG2R695YRlEwaprn7oQabrLaTLozOxtqKGQqrbWfGOsku qNirbtiAL/yBiuq1Evy7LH9lEBQAu8kg2Nydw8/A= To: Laurent Pinchart , Kieran Bingham , libcamera-devel@lists.libcamera.org Date: Wed, 18 May 2022 15:20:13 +0300 Message-Id: <20220518122014.54506-1-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] libcamera: formats: fix warning print X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tomi Valkeinen via libcamera-devel From: Tomi Valkeinen Reply-To: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove extra "0x" from the print. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- src/libcamera/formats.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp index afcaabc5..3e60ec7d 100644 --- a/src/libcamera/formats.cpp +++ b/src/libcamera/formats.cpp @@ -926,7 +926,7 @@ const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format) const auto iter = pixelFormatInfo.find(format); if (iter == pixelFormatInfo.end()) { LOG(Formats, Warning) - << "Unsupported pixel format 0x" + << "Unsupported pixel format " << utils::hex(format.fourcc()); return pixelFormatInfoInvalid; } From patchwork Wed May 18 12:20:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 15945 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 903F5C0F2A for ; Wed, 18 May 2022 12:20:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 545DC65659; Wed, 18 May 2022 14:20:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1652876436; bh=SmX8y42YsG4WXo5EfCGnymQCB8AoxAOr6nOEyZUFBcI=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Wk0VDTVfYkX5gIuHuajnNOiu3GYz1ipxK366xZy459WtnP16uqpSWIFDMfLKmY1BP Di4gZQQcqPTiQDF2VC7X6BirFP2cpNY6n9cwybl8rCX5YfTqX/C/TNkAYbeBQ5Lhv+ IR7OIkzSQWeUbca8+9+n9eZWK3l8oTDxoPNhkv6sZB8Gk4jQyniX1mmkpx1G8Bn8Li JDGcpsRMDypSeP/Sr8ro8w7mzl8e2IwyQqef/B2o3dilnjR6DusTO9oNAZBHj9dhon ue2sA/hHjZTfF2/XZ7Okxde0FzmjLi2xLb3hzqCE4i9KjjTCNg92h3GQvVqDg8Bb26 1HTuIBRW5XYOg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2EB8A65657 for ; Wed, 18 May 2022 14:20:34 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="S9lXj9xL"; dkim-atps=neutral Received: from deskari.lan (91-156-85-209.elisa-laajakaista.fi [91.156.85.209]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C52241027; Wed, 18 May 2022 14:20:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1652876434; bh=SmX8y42YsG4WXo5EfCGnymQCB8AoxAOr6nOEyZUFBcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S9lXj9xL1+H4h/Mc9mKDV11Sk+4Pa6G2+40Z4KTDG9nq44fU7wTk6PzfiXV+846q2 QZgvrhuuADaZ0/pqmP5qQ7afAFgAim5r/+BgxHy4y6InoVlRSGLq9gYXgdjEWndM/4 Wi9/HX4DkiFoxS9rubYHqBq8StJDbMwljyBC2Q/0= To: Laurent Pinchart , Kieran Bingham , libcamera-devel@lists.libcamera.org Date: Wed, 18 May 2022 15:20:14 +0300 Message-Id: <20220518122014.54506-2-tomi.valkeinen@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220518122014.54506-1-tomi.valkeinen@ideasonboard.com> References: <20220518122014.54506-1-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/2] libcamera: formats: add missing RGBX8888 info X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tomi Valkeinen via libcamera-devel From: Tomi Valkeinen Reply-To: Tomi Valkeinen Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add missing RGBX8888 PixelFormatInfo. Signed-off-by: Tomi Valkeinen --- src/libcamera/formats.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp index 3e60ec7d..1c710541 100644 --- a/src/libcamera/formats.cpp +++ b/src/libcamera/formats.cpp @@ -231,6 +231,19 @@ const std::map pixelFormatInfo{ .pixelsPerGroup = 1, .planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }}, } }, + { formats::RGBX8888, { + .name = "RGBX8888", + .format = formats::RGBX8888, + .v4l2Formats = { + .single = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32), + .multi = V4L2PixelFormat(), + }, + .bitsPerPixel = 32, + .colourEncoding = PixelFormatInfo::ColourEncodingRGB, + .packed = false, + .pixelsPerGroup = 1, + .planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }}, + } }, { formats::BGRX8888, { .name = "BGRX8888", .format = formats::BGRX8888,