From patchwork Tue May 3 15:57:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 15761 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CA69DC3256 for ; Tue, 3 May 2022 15:57:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 15F7F6564A; Tue, 3 May 2022 17:57:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1651593474; bh=o7VIjcYU9DzJ6gzyuQQFnrPJ6p1VlqanSCy0BwXgsFA=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=wz3eDl6PJzRa5xrcVkTs86Q+Equak7XKXJwH4PzwxTKU4d4xPI7Tno41SVz+YnYb1 N/Mun7cc1wzTXVtA2oq0fLgWNqOwWFxHNNxhMXUsptPra7aa1WPA+BRySkOaGkLkiE Ic1tR/KnSVUpmRuuddrRZ2fpn3f1zvm5RU87Er3Ok6Sw/MJw4xby0bWeX91GUImaD/ VM5ZzXQ3x2hlSfikxq7tFZXYaFCPdBxEJ4GHUhBFd0tDR6/Xg/Vmzs+HvtS8m4R2dH NB29xGI83iUTEiqcQGuEnCJALQcf6Hpr0Iw4pYZ9tNB/R5YjCHeUAdphevq1sz0ZKe hAJpSd1mEu70Q== Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B8D3965642 for ; Tue, 3 May 2022 17:57:51 +0200 (CEST) Received: (Authenticated sender: foss@0leil.net) by mail.gandi.net (Postfix) with ESMTPSA id F0FD2240012; Tue, 3 May 2022 15:57:50 +0000 (UTC) To: Date: Tue, 3 May 2022 17:57:24 +0200 Message-Id: <20220503155725.1168826-1-foss+libcamera@0leil.net> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Add OV5675 sensor properties X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Quentin Schulz via libcamera-devel From: Quentin Schulz Reply-To: Quentin Schulz Cc: libcamera-devel@lists.libcamera.org Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Quentin Schulz Add an entry to the sensor properties for OmniVision OV5675. Only the first test pattern is included as the others that are exposed by the kernel aren't supported by libcamera control yet. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- src/libcamera/camera_sensor_properties.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp index 7a349012..235edca1 100644 --- a/src/libcamera/camera_sensor_properties.cpp +++ b/src/libcamera/camera_sensor_properties.cpp @@ -123,6 +123,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen { controls::draft::TestPatternModeColorBars, 1 }, }, } }, + { "ov5675", { + .unitCellSize = { 1120, 1120 }, + .testPatternModes = { + { controls::draft::TestPatternModeOff, 0 }, + { controls::draft::TestPatternModeColorBars, 1 }, + }, + } }, { "ov5693", { .unitCellSize = { 1400, 1400 }, .testPatternModes = { From patchwork Tue May 3 15:57:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 15762 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 934F1C326C for ; Tue, 3 May 2022 15:57:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 818186564B; Tue, 3 May 2022 17:57:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1651593474; bh=0v+V5spnf96ABemg8U3CQqu8+33/YuEDLGluW052vIo=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rMLA34ncTwotYqL7DZpU1O+ZaHToysk4FneuMi6RNlIJTpPLjUTQ11hfAcS+w66W/ ZVQSPsvxy03zlRa6EsscbaMFpNMwgRgwudaEFWNeKgtk6W+8/irEOz/P/+rTZaiJ+w Yg9UsxMQawAkDdrnZo9g/08c/yx1dzWHQrzGKaTHwNGFyxrKhgKvGMe4dg8rNiuBZ+ +7V/NturgcvZiFmJebazwqwFqwMegb4S0XnOxA+uk0kZV0qQDIPvlmj6uF2QezJw1T 5sC28bkEBe+9oEO6ZQJGalDW8jFT1TvJNpRHejm5iYq4LtaJljjZGmrxcGonP3nyHV vyypYMwOcBz6A== Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C96265642 for ; Tue, 3 May 2022 17:57:52 +0200 (CEST) Received: (Authenticated sender: foss@0leil.net) by mail.gandi.net (Postfix) with ESMTPSA id CB496240015; Tue, 3 May 2022 15:57:51 +0000 (UTC) To: Date: Tue, 3 May 2022 17:57:25 +0200 Message-Id: <20220503155725.1168826-2-foss+libcamera@0leil.net> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220503155725.1168826-1-foss+libcamera@0leil.net> References: <20220503155725.1168826-1-foss+libcamera@0leil.net> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/2] libipa: camera_sensor_helper: Add OV5675 helper X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Quentin Schulz via libcamera-devel From: Quentin Schulz Reply-To: Quentin Schulz Cc: libcamera-devel@lists.libcamera.org Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Quentin Schulz The OV5675 is an OmniVision sensor with a linear gain model, expressed in 1/128 steps. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index c098e48c..0f156137 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -429,6 +429,17 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("ov5670", CameraSensorHelperOv5670) +class CameraSensorHelperOv5675 : public CameraSensorHelper +{ +public: + CameraSensorHelperOv5675() + { + gainType_ = AnalogueGainLinear; + gainConstants_.linear = { 1, 0, 0, 128 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("ov5675", CameraSensorHelperOv5675) + class CameraSensorHelperOv5693 : public CameraSensorHelper { public: