From patchwork Tue Mar 8 09:15:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 15433 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1526BBF415 for ; Tue, 8 Mar 2022 09:15:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C7A626118D; Tue, 8 Mar 2022 10:15:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1646730936; bh=M9PmQ2YtILsBpoEt+K2LHsNLnfIj8YSeQ142ZN9DJHc=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=AuEj51MR+IpY85S8wvQYa1rRgwxqiEPXgaK8o7KJXcmwc+fcF97enzIMftuo/IEC/ S4dd0P9yTEqwAWSC7+wlH5LsByo+ZQb7z9MkFmHtgj1HEokDv5KEYlUTIWVmSnSlct biSIeTPX7u0Sn8/xsqFBVtnSlElsXDjTltX3ZIougcwkCkHq2o155TFNjs8RdtW+97 Lmw4P3kC6DlRRDN4LKwk4jDkruP0viu5kD5skjAwpsjNN/IjuAcc3znYFgSAgxRohC z2bIGEshqzctZL2GEFhHN3NEIgThp5yGY0E9V4G0avviIh5LW2l9Ah1KMehEsiDzwK bgz/A7imDe9Ew== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F58C604E9 for ; Tue, 8 Mar 2022 10:15:34 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="baGe7POk"; dkim-atps=neutral Received: from perceval.ideasonboard.com (unknown [103.251.226.72]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4AD28488; Tue, 8 Mar 2022 10:15:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1646730934; bh=M9PmQ2YtILsBpoEt+K2LHsNLnfIj8YSeQ142ZN9DJHc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=baGe7POkuARZgv0RxNK4cd4qiT7zHE+lQiFg45DoaUqOvdM37D3EsiH5dsxT8U10g mkDUp5Dwg4+CicMPLj4cbrHEQE4VNlQNFxG5EkS02OO/eMXJeOa/RG0pJxrLFOAM4u d9DBejgRdtgvXlAvSxs8YysNwvduEAyos1tZN1Wc= To: libcamera-devel@lists.libcamera.org Date: Tue, 8 Mar 2022 14:45:19 +0530 Message-Id: <20220308091520.34607-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220308091520.34607-1-umang.jain@ideasonboard.com> References: <20220308091520.34607-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] ipa: rkisp1: Drop private exposure and gain limits X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The private members of exposure and gain limits can be dropped from IPARkISP1 since they are not used class-wide and can be easily replaced by local counter-parts. In case they are required to be widely available, these should then sit in IPASessionConfiguration. Signed-off-by: Umang Jain Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder --- src/ipa/rkisp1/rkisp1.cpp | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 2d79f15f..129afddd 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -69,10 +69,6 @@ private: /* Camera sensor controls. */ bool autoExposure_; - uint32_t minExposure_; - uint32_t maxExposure_; - uint32_t minGain_; - uint32_t maxGain_; /* revision-specific data */ rkisp1_cif_isp_version hwRevision_; @@ -166,15 +162,15 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info, autoExposure_ = true; - minExposure_ = itExp->second.min().get(); - maxExposure_ = itExp->second.max().get(); + int32_t minExposure = itExp->second.min().get(); + int32_t maxExposure = itExp->second.max().get(); - minGain_ = itGain->second.min().get(); - maxGain_ = itGain->second.max().get(); + int32_t minGain = itGain->second.min().get(); + int32_t maxGain = itGain->second.max().get(); LOG(IPARkISP1, Info) - << "Exposure: " << minExposure_ << "-" << maxExposure_ - << " Gain: " << minGain_ << "-" << maxGain_; + << "Exposure: " << minExposure << "-" << maxExposure + << " Gain: " << minGain << "-" << maxGain; /* Clean context at configuration */ context_ = {}; @@ -191,10 +187,10 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info, * * \todo take VBLANK into account for maximum shutter speed */ - context_.configuration.agc.minShutterSpeed = minExposure_ * context_.configuration.sensor.lineDuration; - context_.configuration.agc.maxShutterSpeed = maxExposure_ * context_.configuration.sensor.lineDuration; - context_.configuration.agc.minAnalogueGain = camHelper_->gain(minGain_); - context_.configuration.agc.maxAnalogueGain = camHelper_->gain(maxGain_); + context_.configuration.agc.minShutterSpeed = minExposure * context_.configuration.sensor.lineDuration; + context_.configuration.agc.maxShutterSpeed = maxExposure * context_.configuration.sensor.lineDuration; + context_.configuration.agc.minAnalogueGain = camHelper_->gain(minGain); + context_.configuration.agc.maxAnalogueGain = camHelper_->gain(maxGain); for (auto const &algo : algorithms_) { int ret = algo->configure(context_, info); From patchwork Tue Mar 8 09:15:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 15434 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F0AFEBF415 for ; Tue, 8 Mar 2022 09:15:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 41F376118E; Tue, 8 Mar 2022 10:15:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1646730937; bh=Zlkww4U0hVCtPNF/Hx756pBPj1vNFkogLkp42673DKk=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=i5MCS2bm5kYsHfpknd0sn2xS4qJ7HpHh7G8uq9DyiAr5I71/iI10QU4lhqJuyVd46 BLjFgSFdM/OqypGsCffyecWZf0zBm3/N7/5pXnxiYXe7ecLUXKARG7lYKFdY577SkX C5SMPtzZdLKU1cmhE7Fb+ur9yKKE4D7xYGS8mug58QnDvTxY9yalbbXHKKvJVoAAg/ naubJNoiL9x8yudX63PrfK8XT7DuPqMf65E7Z3uzv9ojTSYJy2whQeoCRd6tGZWY8m hIBzm3607af9TsENSHWH0WZaqXbstcg6G6tEtgPKJesTOcWWDdKRn+mgCoUjl0+7ab 6cTXkCua1HeTw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F123A604E9 for ; Tue, 8 Mar 2022 10:15:35 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aby8VAmh"; dkim-atps=neutral Received: from perceval.ideasonboard.com (unknown [103.251.226.72]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 11222488; Tue, 8 Mar 2022 10:15:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1646730935; bh=Zlkww4U0hVCtPNF/Hx756pBPj1vNFkogLkp42673DKk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aby8VAmh2QIcM9wUMGXEKkCi6RYA5qBpkCIwEXV1iE60AwDV2JNX+6ghTYtsXgElu QeMhWKL4IL75pbgp3qkwfvjmXSnxUX3eK8C9Qu/RTuDkz7SOhhy/7nGkmjXAbpohfn JZau1RFSfCJHjnhtptjv+XMF0lStmXNbIjrbX+KE= To: libcamera-devel@lists.libcamera.org Date: Tue, 8 Mar 2022 14:45:20 +0530 Message-Id: <20220308091520.34607-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220308091520.34607-1-umang.jain@ideasonboard.com> References: <20220308091520.34607-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/2] ipa: rkisp1: Replace event-based ops with dedicated functions X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPARkISP1Interface currently uses event-type based structures in order to communicate with the pipeline-handler (and vice-versa). Replace the event based structures with dedicated functions associated to each operation. The translated naming scheme of operations to dedicated functions: ActionV4L2Set => setSensorControls ActionParamFilled => paramsBufferReady ActionMetadata => statsBufferReady EventSignalStatBuffer => processStatsBuffer() EventQueueRequest => queueRequest() Signed-off-by: Umang Jain Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder --- include/libcamera/ipa/rkisp1.mojom | 31 ++------- src/ipa/rkisp1/rkisp1.cpp | 82 +++++++----------------- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 71 ++++++++------------ 3 files changed, 56 insertions(+), 128 deletions(-) diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom index c3a6d8e1..a0b92b84 100644 --- a/include/libcamera/ipa/rkisp1.mojom +++ b/include/libcamera/ipa/rkisp1.mojom @@ -8,28 +8,6 @@ module ipa.rkisp1; import "include/libcamera/ipa/core.mojom"; -enum RkISP1Operations { - ActionV4L2Set = 1, - ActionParamFilled = 2, - ActionMetadata = 3, - EventSignalStatBuffer = 4, - EventQueueRequest = 5, -}; - -struct RkISP1Event { - RkISP1Operations op; - uint32 frame; - uint32 bufferId; - libcamera.ControlList controls; - libcamera.ControlList sensorControls; -}; - -struct RkISP1Action { - RkISP1Operations op; - libcamera.ControlList controls; - libcamera.ControlList sensorControls; -}; - interface IPARkISP1Interface { init(libcamera.IPASettings settings, uint32 hwRevision) @@ -45,9 +23,14 @@ interface IPARkISP1Interface { mapBuffers(array buffers); unmapBuffers(array ids); - [async] processEvent(RkISP1Event ev); + [async] queueRequest(uint32 frame, uint32 bufferId, + libcamera.ControlList reqControls); + [async] processStatsBuffer(uint32 frame, uint32 bufferId, + libcamera.ControlList sensorControls); }; interface IPARkISP1EventInterface { - queueFrameAction(uint32 frame, RkISP1Action action); + paramsBufferReady(uint32 frame); + setSensorControls(uint32 frame, libcamera.ControlList sensorControls); + statsBufferReady(uint32 frame, libcamera.ControlList metadata); }; diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 129afddd..dc00c1f8 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -51,14 +51,12 @@ public: const std::map &entityControls) override; void mapBuffers(const std::vector &buffers) override; void unmapBuffers(const std::vector &ids) override; - void processEvent(const RkISP1Event &event) override; + void queueRequest(const uint32_t frame, const uint32_t bufferId, + const ControlList &controls) override; + void processStatsBuffer(const uint32_t frame, const uint32_t bufferId, + const ControlList &sensorControls) override; private: - void queueRequest(unsigned int frame, rkisp1_params_cfg *params, - const ControlList &controls); - void updateStatistics(unsigned int frame, - const rkisp1_stat_buffer *stats); - void setControls(unsigned int frame); void metadataReady(unsigned int frame, unsigned int aeState); @@ -231,60 +229,34 @@ void IPARkISP1::unmapBuffers(const std::vector &ids) } } -void IPARkISP1::processEvent(const RkISP1Event &event) -{ - switch (event.op) { - case EventSignalStatBuffer: { - unsigned int frame = event.frame; - unsigned int bufferId = event.bufferId; - - const rkisp1_stat_buffer *stats = - reinterpret_cast( - mappedBuffers_.at(bufferId).planes()[0].data()); - - context_.frameContext.sensor.exposure = - event.sensorControls.get(V4L2_CID_EXPOSURE).get(); - context_.frameContext.sensor.gain = - camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get()); - - updateStatistics(frame, stats); - break; - } - case EventQueueRequest: { - unsigned int frame = event.frame; - unsigned int bufferId = event.bufferId; - - rkisp1_params_cfg *params = - reinterpret_cast( - mappedBuffers_.at(bufferId).planes()[0].data()); - - queueRequest(frame, params, event.controls); - break; - } - default: - LOG(IPARkISP1, Error) << "Unknown event " << event.op; - break; - } -} - -void IPARkISP1::queueRequest(unsigned int frame, rkisp1_params_cfg *params, +void IPARkISP1::queueRequest(const uint32_t frame, const uint32_t bufferId, [[maybe_unused]] const ControlList &controls) { + rkisp1_params_cfg *params = + reinterpret_cast( + mappedBuffers_.at(bufferId).planes()[0].data()); + /* Prepare parameters buffer. */ memset(params, 0, sizeof(*params)); for (auto const &algo : algorithms_) algo->prepare(context_, params); - RkISP1Action op; - op.op = ActionParamFilled; - - queueFrameAction.emit(frame, op); + paramsBufferReady.emit(frame); } -void IPARkISP1::updateStatistics(unsigned int frame, - const rkisp1_stat_buffer *stats) +void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId, + const ControlList &sensorControls) { + const rkisp1_stat_buffer *stats = + reinterpret_cast( + mappedBuffers_.at(bufferId).planes()[0].data()); + + context_.frameContext.sensor.exposure = + sensorControls.get(V4L2_CID_EXPOSURE).get(); + context_.frameContext.sensor.gain = + camHelper_->gain(sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get()); + unsigned int aeState = 0; for (auto const &algo : algorithms_) @@ -297,18 +269,14 @@ void IPARkISP1::updateStatistics(unsigned int frame, void IPARkISP1::setControls(unsigned int frame) { - RkISP1Action op; - op.op = ActionV4L2Set; - uint32_t exposure = context_.frameContext.agc.exposure; uint32_t gain = camHelper_->gainCode(context_.frameContext.agc.gain); ControlList ctrls(ctrls_); ctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure)); ctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain)); - op.sensorControls = ctrls; - queueFrameAction.emit(frame, op); + setSensorControls.emit(frame, ctrls); } void IPARkISP1::metadataReady(unsigned int frame, unsigned int aeState) @@ -318,11 +286,7 @@ void IPARkISP1::metadataReady(unsigned int frame, unsigned int aeState) if (aeState) ctrls.set(controls::AeLocked, aeState == 2); - RkISP1Action op; - op.op = ActionMetadata; - op.controls = ctrls; - - queueFrameAction.emit(frame, op); + statsBufferReady.emit(frame, ctrls); } } /* namespace ipa::rkisp1 */ diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 8cca8a15..d395e335 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -104,8 +104,9 @@ public: std::unique_ptr ipa_; private: - void queueFrameAction(unsigned int frame, - const ipa::rkisp1::RkISP1Action &action); + void paramFilled(unsigned int frame); + void setSensorControls(unsigned int frame, + const ControlList &sensorControls); void metadataReady(unsigned int frame, const ControlList &metadata); }; @@ -316,8 +317,9 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision) if (!ipa_) return -ENOENT; - ipa_->queueFrameAction.connect(this, - &RkISP1CameraData::queueFrameAction); + ipa_->setSensorControls.connect(this, &RkISP1CameraData::setSensorControls); + ipa_->paramsBufferReady.connect(this, &RkISP1CameraData::paramFilled); + ipa_->statsBufferReady.connect(this, &RkISP1CameraData::metadataReady); int ret = ipa_->init(IPASettings{ "", sensor_->model() }, hwRevision); if (ret < 0) { @@ -328,39 +330,27 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision) return 0; } -void RkISP1CameraData::queueFrameAction(unsigned int frame, - const ipa::rkisp1::RkISP1Action &action) +void RkISP1CameraData::paramFilled(unsigned int frame) { - switch (action.op) { - case ipa::rkisp1::ActionV4L2Set: { - const ControlList &controls = action.sensorControls; - delayedCtrls_->push(controls); - break; - } - case ipa::rkisp1::ActionParamFilled: { - PipelineHandlerRkISP1 *pipe = RkISP1CameraData::pipe(); - RkISP1FrameInfo *info = frameInfo_.find(frame); - if (!info) - break; + PipelineHandlerRkISP1 *pipe = RkISP1CameraData::pipe(); + RkISP1FrameInfo *info = frameInfo_.find(frame); + if (!info) + return; - pipe->param_->queueBuffer(info->paramBuffer); - pipe->stat_->queueBuffer(info->statBuffer); + pipe->param_->queueBuffer(info->paramBuffer); + pipe->stat_->queueBuffer(info->statBuffer); - if (info->mainPathBuffer) - mainPath_->queueBuffer(info->mainPathBuffer); + if (info->mainPathBuffer) + mainPath_->queueBuffer(info->mainPathBuffer); - if (info->selfPathBuffer) - selfPath_->queueBuffer(info->selfPathBuffer); + if (info->selfPathBuffer) + selfPath_->queueBuffer(info->selfPathBuffer); +} - break; - } - case ipa::rkisp1::ActionMetadata: - metadataReady(frame, action.controls); - break; - default: - LOG(RkISP1, Error) << "Unknown action " << action.op; - break; - } +void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame, + const ControlList &sensorControls) +{ + delayedCtrls_->push(sensorControls); } void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata) @@ -865,13 +855,8 @@ int PipelineHandlerRkISP1::queueRequestDevice(Camera *camera, Request *request) if (!info) return -ENOENT; - ipa::rkisp1::RkISP1Event ev; - ev.op = ipa::rkisp1::EventQueueRequest; - ev.frame = data->frame_; - ev.bufferId = info->paramBuffer->cookie(); - ev.controls = request->controls(); - data->ipa_->processEvent(ev); - + data->ipa_->queueRequest(data->frame_, info->paramBuffer->cookie(), + request->controls()); data->frame_++; return 0; @@ -1120,12 +1105,8 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer) if (data->frame_ <= buffer->metadata().sequence) data->frame_ = buffer->metadata().sequence + 1; - ipa::rkisp1::RkISP1Event ev; - ev.op = ipa::rkisp1::EventSignalStatBuffer; - ev.frame = info->frame; - ev.bufferId = info->statBuffer->cookie(); - ev.sensorControls = data->delayedCtrls_->get(buffer->metadata().sequence); - data->ipa_->processEvent(ev); + data->ipa_->processStatsBuffer(info->frame, info->statBuffer->cookie(), + data->delayedCtrls_->get(buffer->metadata().sequence)); } REGISTER_PIPELINE_HANDLER(PipelineHandlerRkISP1)