From patchwork Thu Mar  3 11:06:39 2022
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Kieran Bingham <kieran.bingham@ideasonboard.com>
X-Patchwork-Id: 15403
Return-Path: <libcamera-devel-bounces@lists.libcamera.org>
X-Original-To: parsemail@patchwork.libcamera.org
Delivered-To: parsemail@patchwork.libcamera.org
Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com
	[92.243.16.209])
	by patchwork.libcamera.org (Postfix) with ESMTPS id D415FBF415
	for <parsemail@patchwork.libcamera.org>;
	Thu,  3 Mar 2022 11:06:46 +0000 (UTC)
Received: from lancelot.ideasonboard.com (localhost [IPv6:::1])
	by lancelot.ideasonboard.com (Postfix) with ESMTP id 17F286115E;
	Thu,  3 Mar 2022 12:06:46 +0100 (CET)
Authentication-Results: lancelot.ideasonboard.com;
	dkim=fail reason="signature verification failed" (1024-bit key;
	unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com
	header.b="FC9IW8+Z"; dkim-atps=neutral
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
	[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])
	by lancelot.ideasonboard.com (Postfix) with ESMTPS id CFD19601FF
	for <libcamera-devel@lists.libcamera.org>;
	Thu,  3 Mar 2022 12:06:44 +0100 (CET)
Received: from Monstersaurus.ksquared.org.uk.beta.tailscale.net
	(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])
	by perceval.ideasonboard.com (Postfix) with ESMTPSA id 46ECF885;
	Thu,  3 Mar 2022 12:06:44 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;
	s=mail; t=1646305604;
	bh=wliCWh+os367vtKtBb7/BzrBzTDBZyDzIOlWEUZy2kg=;
	h=From:To:Cc:Subject:Date:From;
	b=FC9IW8+ZYvpST5ywNLc9Oeb8wbHQK+S1C+qMy/BOVNvkQMrJi/cnIAyC5QLjvMLeh
	30NbgWEGJW4x0XcmHX+bZRbXARwNFSvyoH5emYhd4nNBdlW7ve/cmkpnLdZo2aIC0L
	3xz+mkns3VIz2yTcQGCJnYOaJ6ktO1nmwjzW7uqg=
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: libcamera devel <libcamera-devel@lists.libcamera.org>
Date: Thu,  3 Mar 2022 11:06:39 +0000
Message-Id: <20220303110639.3469390-1-kieran.bingham@ideasonboard.com>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Subject: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix header include
	order
X-BeenThere: libcamera-devel@lists.libcamera.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <libcamera-devel.lists.libcamera.org>
List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>,
	<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>
List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/>
List-Post: <mailto:libcamera-devel@lists.libcamera.org>
List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help>
List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>,
	<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>
Errors-To: libcamera-devel-bounces@lists.libcamera.org
Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org>

The includes in the v4l2_camera_proxy do not match the code styel
and trigger clang-format changes when running checkstyle.

Update and fix the include order accordingly

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/v4l2/v4l2_camera_proxy.cpp | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Note, this might likely only apply on top of the pending V4L2 frame rate
patch.

diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
index 493c41c0ad0f..4427ae3302d8 100644
--- a/src/v4l2/v4l2_camera_proxy.cpp
+++ b/src/v4l2/v4l2_camera_proxy.cpp
@@ -10,22 +10,23 @@
 #include <algorithm>
 #include <array>
 #include <errno.h>
-#include <linux/videodev2.h>
 #include <numeric>
 #include <set>
 #include <string.h>
 #include <sys/mman.h>
 #include <unistd.h>
 
-#include <libcamera/camera.h>
-#include <libcamera/controls.h>
-#include <libcamera/control_ids.h>
-#include <libcamera/formats.h>
+#include <linux/videodev2.h>
 
 #include <libcamera/base/log.h>
 #include <libcamera/base/object.h>
 #include <libcamera/base/utils.h>
 
+#include <libcamera/camera.h>
+#include <libcamera/control_ids.h>
+#include <libcamera/controls.h>
+#include <libcamera/formats.h>
+
 #include "libcamera/internal/formats.h"
 
 #include "v4l2_camera.h"