From patchwork Fri May 3 15:37:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 1156 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A4A360003 for ; Fri, 3 May 2019 17:37:11 +0200 (CEST) Received: from Q.Home (unknown [IPv6:2a02:c7f:1887:5d00:c990:5ff4:193b:c9b8]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B8D2931E; Fri, 3 May 2019 17:37:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1556897830; bh=5nJj2tjgIE60BvSHJ8564S+I+kuAv60vcG2cntfFVQI=; h=From:To:Cc:Subject:Date:From; b=K0vivtD/vLuI+TAjvYeGtrlUufxJLfimawBEThz1cl+hE/AT6rbwgpLVy3DAxDcVE IY7AQJBxgJko3NBiVGFl2zlMq0Ny40QHPcKouSrEZ1MJdccneXO+9qRVFuQBnUCW/m w1rujMFLdwPezAOEQfSxmd3hgRb5fsgSvijP9Lqc= From: Kieran Bingham To: LibCamera Devel Date: Fri, 3 May 2019 16:37:07 +0100 Message-Id: <20190503153707.8918-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: v4l2_device: Increase error level for unsupported devices X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 15:37:11 -0000 If a component tries to open an unsupported device type, no error is presented unless debug is enabled. Report an error if an unsupported device type is opened to ease pipeline development. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/libcamera/v4l2_device.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp index e22323de19c3..8366ffc4db55 100644 --- a/src/libcamera/v4l2_device.cpp +++ b/src/libcamera/v4l2_device.cpp @@ -349,7 +349,7 @@ int V4L2Device::open() fdEvent_ = new EventNotifier(fd_, EventNotifier::Read); bufferType_ = V4L2_BUF_TYPE_META_CAPTURE; } else { - LOG(V4L2, Debug) << "Device is not a supported type"; + LOG(V4L2, Error) << "Device is not a supported type"; return -EINVAL; }