From patchwork Thu Nov 25 08:05:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 14773 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D8A2BBDB13 for ; Thu, 25 Nov 2021 08:05:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0B5AA60233; Thu, 25 Nov 2021 09:05:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="iVVkOXkO"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 73D1060228 for ; Thu, 25 Nov 2021 09:05:25 +0100 (CET) Received: from perceval.ideasonboard.com (unknown [103.251.226.170]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D31090E; Thu, 25 Nov 2021 09:05:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637827525; bh=uuu6qKx5kpNbrosqfGorVCdCd6lNOGlg4U5SmhNigbU=; h=From:To:Cc:Subject:Date:From; b=iVVkOXkOnxgzrO8Q1IjfSkzGGn70t2/5cRNAa7op4COYzZgWh3L4uZLbHyW/siOiS RKHDhNhLBpUhPRptCFPeQW4tLCWYWfa9ijXxaWE6eumf06r5kNyvcTEaACxo2FQlrb aqdcXgVhIe2Peb6zaEScBrw5T4TZFDK6l16iiP0U= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Thu, 25 Nov 2021 13:35:18 +0530 Message-Id: <20211125080518.779815-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] android: camera_device: Provide toString() helper for stream_type X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Provide a directionToString() helper to return a human-friendly name for camera3_stream_t->stream_type. Replace the int value being printed in configureStreams() INFO log with directionToString(). Signed-off-by: Umang Jain Reviewed-by: Jacopo Mondi Reviewed-by: Hirokazu Honda Reviewed-by: Kieran Bingham --- src/android/camera_device.cpp | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index f2e0bdbd..804a71fd 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -175,6 +175,20 @@ const char *rotationToString(int rotation) return "INVALID"; } +const char *directionToString(int stream_type) +{ + switch (stream_type) { + case CAMERA3_STREAM_OUTPUT: + return "Output"; + case CAMERA3_STREAM_INPUT: + return "Input"; + case CAMERA3_STREAM_BIDIRECTIONAL: + return "Bidirectional"; + } + + return "Unknown"; +} + #if defined(OS_CHROMEOS) /* * Check whether the crop_rotate_scale_degrees values for all streams in @@ -548,7 +562,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list) PixelFormat format = capabilities_.toPixelFormat(stream->format); LOG(HAL, Info) << "Stream #" << i - << ", direction: " << stream->stream_type + << ", direction: " << directionToString(stream->stream_type) << ", width: " << stream->width << ", height: " << stream->height << ", format: " << utils::hex(stream->format)