From patchwork Fri Nov 12 06:29:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 14585 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 61261BF415 for ; Fri, 12 Nov 2021 06:29:58 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 783746034D; Fri, 12 Nov 2021 07:29:57 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="fgokP/Hv"; dkim-atps=neutral Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 68DC560232 for ; Fri, 12 Nov 2021 07:29:56 +0100 (CET) Received: by mail-pf1-x42c.google.com with SMTP id x131so7657250pfc.12 for ; Thu, 11 Nov 2021 22:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F1KNCN40VbB3g8tpkQDcWaOhyB+TH2rzFO0r9HSPUjw=; b=fgokP/Hv2KQl5RuXbbaR7JandnvI0/iWivVa7aAjZPsyzZc6gopFK8xqAvTcj18OoQ L4DTAhA8xxLGfDMjdU1bUJVdabmTyhuBoPoubBV+8Uh1X2vKpcMFKM6/C8VJDbBmImfc jfM0SyTcjV8pViD8Vr9hNoaRUfxfqpvkT48pU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F1KNCN40VbB3g8tpkQDcWaOhyB+TH2rzFO0r9HSPUjw=; b=oBPktmz1dLIr8xwqE1s2oLpPRLZl4nFBdaGGuIw5Ow7dwtSQDelwBuxf0fwQX9rpIj 6/X1LP808bz1waSB6VXeTiKidWL3CQJMQ4lwwFz0FHvNE7RcsSj1zS8VfxcDulLB/Dl9 0fu6sht0WzUJrf4l48MPMyvV7T1X7ZJeqQsYgVS605rPnK20LUtpnnq3/TGMd5JTbDoK khXJ9phr8Edg9LygVCtYzNSzbpRzmTLYsGBqP8RUnDvX3WkBGVBgWpJBabJd7Av6usct qwtIHA5Yz9OEbHhCNl+8pD47d7mAy7dsFoAZtdz4wtmaFQgCLGH0VtcSszxNqAbObgyd GUeQ== X-Gm-Message-State: AOAM532yI+DW4wwSLiGvWJ7mak2bPLDHoSkAGEPGmut908LA/93W9ac8 24+mJKE3rtfYBfdO6miuVRKyWIsvh6J2PQ== X-Google-Smtp-Source: ABdhPJxflJL+cMJCOU6P8c+jmwvmx+jgBw50OZ2cDvGhVbe9HAGXev4/NnHAg7e2APa3s3hAwlJcxQ== X-Received: by 2002:aa7:9e9c:0:b0:49f:c7cf:ff5 with SMTP id p28-20020aa79e9c000000b0049fc7cf0ff5mr11816836pfq.62.1636698594415; Thu, 11 Nov 2021 22:29:54 -0800 (PST) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:203:e65a:906b:8c5c:e7f8]) by smtp.gmail.com with ESMTPSA id cv1sm9769850pjb.48.2021.11.11.22.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 22:29:53 -0800 (PST) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Fri, 12 Nov 2021 15:29:48 +0900 Message-Id: <20211112062948.1432821-1-hiroh@chromium.org> X-Mailer: git-send-email 2.34.0.rc1.387.gb447b232ab-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4] lc-compliance: Build with gtest in subprojects X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" libgtest-dev is provided as a static library at least by Debian 10. The compiler and linker to create the static library might be different from ones used for libcamera. This causes a problem upon linking. This puts gtest code to subprojects, builds the code and link it for lc-compliance. However, libgtest is locally built as a library on ChromeOS and thus the used compiler and linker are the same as one used for libcamera. We don't do these on ChromeOS build environment. Signed-off-by: Hirokazu Honda Tested-by: Jacopo Mondi Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Umang Jain --- README.rst | 2 +- src/lc-compliance/meson.build | 16 ++++++++++++++-- subprojects/.gitignore | 4 +++- subprojects/gtest.wrap | 14 ++++++++++++++ 4 files changed, 32 insertions(+), 4 deletions(-) create mode 100644 subprojects/gtest.wrap -- 2.34.0.rc1.387.gb447b232ab-goog diff --git a/README.rst b/README.rst index 8af5f118..c48b4dba 100644 --- a/README.rst +++ b/README.rst @@ -99,7 +99,7 @@ for android: [optional] libexif-dev libjpeg-dev libyaml-dev for lc-compliance: [optional] - libevent-dev libgtest-dev + libevent-dev Using GStreamer plugin ~~~~~~~~~~~~~~~~~~~~~~ diff --git a/src/lc-compliance/meson.build b/src/lc-compliance/meson.build index aa5852f6..130ddbb5 100644 --- a/src/lc-compliance/meson.build +++ b/src/lc-compliance/meson.build @@ -1,13 +1,25 @@ # SPDX-License-Identifier: CC0-1.0 libevent = dependency('libevent_pthreads', required : get_option('lc-compliance')) -libgtest = dependency('gtest', required : get_option('lc-compliance')) -if not (libevent.found() and libgtest.found()) +if not libevent.found() lc_compliance_enabled = false subdir_done() endif +if get_option('android_platform') == 'cros' + libgtest = dependency('gtest', required : get_option('lc-compliance')) + + if not libgtest.found() + lc_compliance_enabled = false + subdir_done() + endif + +else + libgtest_sp = subproject('gtest') + libgtest = libgtest_sp.get_variable('gtest_dep') +endif + lc_compliance_enabled = true lc_compliance_sources = files([ diff --git a/subprojects/.gitignore b/subprojects/.gitignore index 410b8bd6..391fde2c 100644 --- a/subprojects/.gitignore +++ b/subprojects/.gitignore @@ -1 +1,3 @@ -/libyuv \ No newline at end of file +/googletest-release* +/libyuv +/packagecache \ No newline at end of file diff --git a/subprojects/gtest.wrap b/subprojects/gtest.wrap new file mode 100644 index 00000000..40128b35 --- /dev/null +++ b/subprojects/gtest.wrap @@ -0,0 +1,14 @@ +[wrap-file] +directory = googletest-release-1.11.0 +source_url = https://github.com/google/googletest/archive/release-1.11.0.zip +source_filename = gtest-1.11.0.zip +source_hash = 353571c2440176ded91c2de6d6cd88ddd41401d14692ec1f99e35d013feda55a +patch_filename = gtest_1.11.0-1_patch.zip +patch_url = https://wrapdb.mesonbuild.com/v2/gtest_1.11.0-1/get_patch +patch_hash = d38c39184384608b08419be52aed1d0f9d9d1b5ed71c0c35e51cccbdddab7084 + +[provide] +gtest = gtest_dep +gtest_main = gtest_main_dep +gmock = gmock_dep +gmock_main = gmock_main_dep