From patchwork Tue Oct 12 00:13:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 14101 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 429C1C323E for ; Tue, 12 Oct 2021 00:13:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9233A68F4C; Tue, 12 Oct 2021 02:13:43 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KDDMk42Y"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BAB36027A for ; Tue, 12 Oct 2021 02:13:42 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B36DCF1 for ; Tue, 12 Oct 2021 02:13:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1633997621; bh=PBe5kPVyimTBHbf6+aiukqFox8WCMd2pVKlsaTUPcfs=; h=From:To:Subject:Date:From; b=KDDMk42YSsG/44CQHutb+KMFKk2ZMCQ9vYaiL/B9n5xwkR5rWF8OSr02Sk1xKBJ/o gj5E5cVRNV/nDaeb5jYg08LOQ4WP0uRvCvYvqkPaw5jFweyUGewMvgGHw1x+ln2eyT QsmfiLos9fffHgbGgbHAhchc1YvWxsxcLKr8B8I8= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 12 Oct 2021 03:13:25 +0300 Message-Id: <20211012001325.1952-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: v4l2_subdevice: Set format field to V4L2_FIELD_NONE X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" libcamera doesn't support interlaced formats, set the field to V4L2_FIELD_NONE explicitly instead of relying on drivers to interpret V4L2_FIELD_ANY the way we want it. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/libcamera/v4l2_subdevice.cpp | 1 + 1 file changed, 1 insertion(+) base-commit: fa7a95bf32c6a8ee87b67159d4238cbc8e6dc3a9 diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp index 8fe5e45b31ee..023e2328893d 100644 --- a/src/libcamera/v4l2_subdevice.cpp +++ b/src/libcamera/v4l2_subdevice.cpp @@ -425,6 +425,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format, subdevFmt.format.width = format->size.width; subdevFmt.format.height = format->size.height; subdevFmt.format.code = format->mbus_code; + subdevFmt.format.field = V4L2_FIELD_NONE; int ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt); if (ret) {