From patchwork Mon Sep 27 21:19:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 13955 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 54471BDC71 for ; Mon, 27 Sep 2021 21:19:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C582D69189; Mon, 27 Sep 2021 23:19:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DuWYybP9"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DDC86012C for ; Mon, 27 Sep 2021 23:19:46 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DFAA1224; Mon, 27 Sep 2021 23:19:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632777585; bh=MIST+CRsLPUpbX0iXi3OZwufk6rL2yK7v9+62Ff6FIs=; h=From:To:Cc:Subject:Date:From; b=DuWYybP9Mz/JN2q/z5GJYc5vxnfnDaCUM0w3++I2vVZcn7d3pysYQVN48QMlCMUJf fNYjFjSdrxZh0czOd8dERHE/DNnEjiEKg2UASdr/SAcgrWJnvG21rGddWH8Ya5uUv3 hrkRae9lrhnxHGkGNUBVV/H5OuOLndiuBAv9JXjM= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 28 Sep 2021 00:19:33 +0300 Message-Id: <20210927211933.25088-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: control_serializer: Fix usage of uninitialized variable X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The idMap variable may be used uninitialized in the ControlSerializer::deserialize() function as reported by gcc 11: ../../src/libcamera/control_serializer.cpp: In member function ‘T libcamera::ControlSerializer::deserialize(libcamera::ByteStreamBuffer&) [with T = libcamera::ControlList]’: ../../src/libcamera/control_serializer.cpp:609:33: error: ‘idMap’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 609 | ControlList ctrls(*idMap); | This is due to a missing default case in a switch/case. Fix it by adding the default case. Fixes: 6b1404fc4836 ("libcamera: control_serializer: Fix usage of uninitialized variable") Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Paul Elder --- src/libcamera/control_serializer.cpp | 1 + 1 file changed, 1 insertion(+) base-commit: 957c5d534b42e05520de82f27b2204fa864d511a diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp index 77b77448d61d..e87d23625ed2 100644 --- a/src/libcamera/control_serializer.cpp +++ b/src/libcamera/control_serializer.cpp @@ -594,6 +594,7 @@ ControlList ControlSerializer::deserialize(ByteStreamBuffer &buffer break; case IPA_CONTROL_ID_MAP_V4L2: + default: LOG(Serializer, Fatal) << "A list of V4L2 controls requires an ControlInfoMap"; return {};