From patchwork Mon Aug 9 16:04:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13267 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 98BE2BD87D for ; Mon, 9 Aug 2021 16:04:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0DF2468826; Mon, 9 Aug 2021 18:04:55 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="oEsbBTUR"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DA5C960269 for ; Mon, 9 Aug 2021 18:04:53 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.61]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9258B466; Mon, 9 Aug 2021 18:04:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1628525093; bh=gNFexdiplVyzqFZooU5y1Kbykiw1K53q7B4YAFo0NlQ=; h=From:To:Cc:Subject:Date:From; b=oEsbBTURrHoL3QX2wNZ66WlAl7wXrkVGo9xxmZhA1eZJmfLrCBKcFYx1BQW3DCH1t utC36iJMdikaPyKx3wu92MtUewsiHSRuG8gZaJ+1SWgj1VHFnnoX5a6QTqGiinTPja n3NtNK7XE70Kkmo+EUREWILXYsnNQNhGZDlterIU= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Mon, 9 Aug 2021 21:34:45 +0530 Message-Id: <20210809160445.179306-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: frame_buffer: Print errno on mmap() failure X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In mmap() error handling path, errno is stored but never printed in the error log. Print it. Signed-off-by: Umang Jain Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder Reviewed-by: Kieran Bingham --- src/libcamera/framebuffer.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp index 41e6e68f..280f64c6 100644 --- a/src/libcamera/framebuffer.cpp +++ b/src/libcamera/framebuffer.cpp @@ -388,7 +388,8 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, int flags) MAP_SHARED, plane.fd.fd(), 0); if (address == MAP_FAILED) { error_ = -errno; - LOG(Buffer, Error) << "Failed to mmap plane"; + LOG(Buffer, Error) << "Failed to mmap plane: " + << strerror(-error_); break; }