From patchwork Fri Jul 23 04:04:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 13104 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A6F82C0109 for ; Fri, 23 Jul 2021 04:04:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 13D6E687A9; Fri, 23 Jul 2021 06:04:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sme49bzP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AC428687A3 for ; Fri, 23 Jul 2021 06:04:27 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BE93255 for ; Fri, 23 Jul 2021 06:04:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1627013067; bh=Ew3xPXCe3ydw5mLkoXEPA9EdJqNIV3TKZ5fhKEcP8y8=; h=From:To:Subject:Date:From; b=sme49bzPdQbzqoXeQYMd7sJbe5ljUHg9lx6NjQdNG3tANtshZaKfhNGmmrO2RHoJu 3mknVK7Jrh2w+2D2kkFiLwSQqCm00N8vrbxuGilGyn3CYTNk3o2OVSkiyjlUnOQ4Z8 6/jpHH0Q3+It2xNKH29lymr5ZzJngZUTNY8avruY= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 23 Jul 2021 07:04:21 +0300 Message-Id: <20210723040421.1898-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] cam: Initialize CamApp::loopUsers_ X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The CamApp loopUsers_ member variable isn't initialized, which results in random execution of the event loop. Fix it. Fixes: caa6ffacb2fc ("cam: Reorganize run() function and merge the two event loops") Signed-off-by: Laurent Pinchart Reviewed-by: Umang Jain Tested-by: Umang Jain --- src/cam/main.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cam/main.cpp b/src/cam/main.cpp index f9a90672a474..34cbc3229563 100644 --- a/src/cam/main.cpp +++ b/src/cam/main.cpp @@ -56,6 +56,7 @@ private: CamApp *CamApp::app_ = nullptr; CamApp::CamApp() + : loopUsers_(0) { CamApp::app_ = this; }