From patchwork Mon Jul 5 16:01:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 12809 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 682A7BD794 for ; Mon, 5 Jul 2021 16:01:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D5E25684E4; Mon, 5 Jul 2021 18:01:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eU6bXk5D"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C1A4E6050A for ; Mon, 5 Jul 2021 18:01:23 +0200 (CEST) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:1d16:e950:dd18:abef]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 520B38C8; Mon, 5 Jul 2021 18:01:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1625500883; bh=HMEOn/xWN2yswRCAw8Amp/m+jmoqUaVnX9OOk+tQabI=; h=From:To:Cc:Subject:Date:From; b=eU6bXk5DFek9nIHF6eXJIUjyroLyj1I69MQ4Ada3dfOuKudrE8tr6RFOSdV2SL1+L 25jH+JhvYuwfjGdOIPaKg8CdP0kPFK9fOSPmD/ACZfKlJY+utpOKEtXpLk02bs1gy3 NHtqZzeSHjAKD6JbKLZhjcJCYF5IOGoqpmhq0O+Y= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Mon, 5 Jul 2021 18:01:20 +0200 Message-Id: <20210705160120.86313-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: libipa: Fix ov5670 analogue gain parameters X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Based on datasheet, the gain multiplier is 128 and not 256 (the fraction bits are the 7 lower bits). Fix it. Signed-off-by: Jean-Michel Hautbois Change-Id: I87e4b078f65c68da005a3ad4f1216256b8487df7 Reviewed-by: Laurent Pinchart --- src/ipa/libipa/camera_sensor_helper.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 23335ed6..cd0a19bb 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -294,7 +294,7 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper public: CameraSensorHelperOv5670() { - analogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 256 }; + analogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 }; } }; REGISTER_CAMERA_SENSOR_HELPER("ov5670", CameraSensorHelperOv5670)