From patchwork Wed Jun 16 09:56:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 12608 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5BFA1C3218 for ; Wed, 16 Jun 2021 09:56:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8CAF468940; Wed, 16 Jun 2021 11:56:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lJzVB/FD"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B0D776050C for ; Wed, 16 Jun 2021 11:56:13 +0200 (CEST) Received: from Monstersaurus.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 26766F88; Wed, 16 Jun 2021 11:56:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1623837373; bh=7H3iK/ApdoWyRJ8O1Nuc4stYFx4S1ZLeFHHW7MogMY4=; h=From:To:Cc:Subject:Date:From; b=lJzVB/FDTmkmQLXH/Own4H/Y5+6O43vFCgmEhUpbLNGHxUzPzxWY4f8Ei8c6blhVI VtDBnD772r7Tvi6U6jL1kO8ikq9BH3JhQONSxjs6Fm3IS58KyrIxHjuQ0NirtVIUe3 nz1cCwGs0mZGIHbqWeVJKPROzDVsIPaVo0HzIWp0= From: Kieran Bingham To: libcamera devel Date: Wed, 16 Jun 2021 10:56:10 +0100 Message-Id: <20210616095610.3593281-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: pipeline: vimc: Fail without an IPA X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Registering a camera for VIMC without an IPA will fail later when attempting to configure. The IPA is required for VIMC so fail early if it can't be loaded. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/vimc/vimc.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index 9ebd723be171..8af0e92012e6 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -431,6 +431,7 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator) data->ipa_->init(IPASettings{ conf, data->sensor_->model() }); } else { LOG(VIMC, Warning) << "no matching IPA found"; + return false; } /* Create and register the camera. */