From patchwork Mon Jun 14 10:45:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 12591 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5D269BD78E for ; Mon, 14 Jun 2021 10:46:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B1BAC602A1; Mon, 14 Jun 2021 12:46:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="MF+1znDv"; dkim-atps=neutral Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B3BDB6029D for ; Mon, 14 Jun 2021 12:46:04 +0200 (CEST) Received: by mail-pf1-x42a.google.com with SMTP id x16so6044466pfa.13 for ; Mon, 14 Jun 2021 03:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AiHAs+ml7IWXYb179n3+tNAePt8bdUQ6p/7KDXuddNc=; b=MF+1znDvQsIKiyA1aO0LfhGNnOZik3xZrInTOKV0iZuN0y3k8dFn6zXlilRPrVNogU gNZJbKUGhmf1B2gamoFg1TITinaKUIAz5TtXx4Y9/dCPu0sD/DwEQ4mvEddEXxFRBzsp UEa+y4q3l+cw30gidaIgL63JHnEg+mLJw54pc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AiHAs+ml7IWXYb179n3+tNAePt8bdUQ6p/7KDXuddNc=; b=ZLCuQiPzKNsYxUnDamjBd9HH+1JKmaHPgwdSZ171LqA9I5kc8KRd733/fp7ZY73d14 U1TqCZKkTeT87EahhiS7/OBvENC6V+CCI81gAi42NFfh4pQ81O5PXwT8i7kr6UndSOYi dUJAuQ1Qla+2qZigsQlPstj+GVGeNFD0tnQYoIhcCEn/7ndRpUudz8W2DlpVQqITLcbt dXL6eoThk4t/uJZOhljC6TC3ElNCbJbuB0kkCmSk0xgzVLeSA1LgKrsQueRg0AhS/egS 8oIZ4gx54LhiXozTaDTVwRUQUqcKOcoR2tTt6jw5yh2d/526Y6XANnAxopQIGVyh5F4I O3Pw== X-Gm-Message-State: AOAM531CNhNSgX+cHq7sNkL/ZAiQuoi84n12T+uy3Mi0xwd9lxBeQbhC AF6drBXQaSNq5JNTy8D9iBgLqx3KHWEDbQ== X-Google-Smtp-Source: ABdhPJxTwHx6AsNCwI7JMFmuSnGazGvDVh0ttEEzEURuMfmyRX86e3HVoKcBaL6lOlfo5HL7yRs/FQ== X-Received: by 2002:a63:de02:: with SMTP id f2mr16588448pgg.32.1623667562812; Mon, 14 Jun 2021 03:46:02 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:203:dd3f:f6f0:e98e:863b]) by smtp.gmail.com with ESMTPSA id u38sm1818366pgm.14.2021.06.14.03.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 03:46:02 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Mon, 14 Jun 2021 19:45:53 +0900 Message-Id: <20210614104553.497626-1-hiroh@chromium.org> X-Mailer: git-send-email 2.32.0.272.g935e593368-goog MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH] android: camera_device: Drop HAL_PIXEL_FORMAT_RAW_OPAQUE support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" HAL_PIXEL_FORMAT_RAW_OPAQUE is requested only for Zero-Shutter-Lag (ZSL). ZSL requires RAW and YUV reprocessing. Since either of them is not supported by libcamera, supporting RAW_OPAQUE format doesn't make sense. Drop the format from the supported format list. Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- src/android/camera_device.cpp | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index fe332ec3..14022aed 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -120,17 +120,6 @@ const std::map camera3FormatsMap = { false, "RAW16" } - }, { - HAL_PIXEL_FORMAT_RAW_OPAQUE, { - { - formats::SBGGR10_IPU3, - formats::SGBRG10_IPU3, - formats::SGRBG10_IPU3, - formats::SRGGB10_IPU3 - }, - false, - "RAW_OPAQUE" - } }, };