From patchwork Mon May 31 22:53:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 12477 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 96D16C3206 for ; Mon, 31 May 2021 22:53:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E9A3768921; Tue, 1 Jun 2021 00:53:48 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bOrGFggD"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 933636891B for ; Tue, 1 Jun 2021 00:53:42 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DDA5F88C for ; Tue, 1 Jun 2021 00:53:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1622501622; bh=ZGfYDqD0FvfmqYoNoxuUbJdjHQU6C3uDogJD9k/4I3Y=; h=From:To:Subject:Date:From; b=bOrGFggD+tT2F7H1Q4doGxj8vVtcEkDqzD7vnAXs8n5owYemEUTtA1XLC3pgMIXyG xczYY9f3ykP7qVcSPj68KvDqGpN2J/O/jEd/4vJpaUI+4HInrxDTMar4T0pTXImzMP rgllzjAfZPLTcTh/4DVTxWfqd9qvrcx+tBuM7n3w= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 1 Jun 2021 01:53:28 +0300 Message-Id: <20210531225328.7595-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] android: Fix unused parameter warnings on Chrome OS X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The Chrome OS-specific code has multiple function parameters that are not used. This results in compilation warnings. Fix them with [[maybe_unused]]. Signed-off-by: Laurent Pinchart Change-Id: I4f05ace5c1781b2593e80532553b6a02e399fed6 Reviewed-by: Paul Elder Reviewed-by: Hirokazu Honda --- src/android/cros/camera3_hal.cpp | 2 +- src/android/mm/cros_camera_buffer.cpp | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/android/cros/camera3_hal.cpp b/src/android/cros/camera3_hal.cpp index d6fc1d0fca06..fb863b5f9aa9 100644 --- a/src/android/cros/camera3_hal.cpp +++ b/src/android/cros/camera3_hal.cpp @@ -9,7 +9,7 @@ #include "../camera_hal_manager.h" -static void set_up(cros::CameraMojoChannelManagerToken *token) +static void set_up([[maybe_unused]] cros::CameraMojoChannelManagerToken *token) { } diff --git a/src/android/mm/cros_camera_buffer.cpp b/src/android/mm/cros_camera_buffer.cpp index 1a4fd5d1dfe3..59e26d1b5972 100644 --- a/src/android/mm/cros_camera_buffer.cpp +++ b/src/android/mm/cros_camera_buffer.cpp @@ -48,7 +48,8 @@ private: }; CameraBuffer::Private::Private(CameraBuffer *cameraBuffer, - buffer_handle_t camera3Buffer, int flags) + buffer_handle_t camera3Buffer, + [[maybe_unused]] int flags) : Extensible::Private(cameraBuffer), handle_(camera3Buffer), numPlanes_(0), valid_(false), registered_(false) { @@ -128,7 +129,7 @@ Span CameraBuffer::Private::plane(unsigned int plane) bufferManager_->GetPlaneSize(handle_, plane) }; } -size_t CameraBuffer::Private::jpegBufferSize(size_t maxJpegBufferSize) const +size_t CameraBuffer::Private::jpegBufferSize([[maybe_unused]] size_t maxJpegBufferSize) const { return bufferManager_->GetPlaneSize(handle_, 0); }