From patchwork Mon May 10 05:42:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 12232 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 67BF1BF831 for ; Mon, 10 May 2021 05:42:58 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BA6FC6891B; Mon, 10 May 2021 07:42:57 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="H8G1lJun"; dkim-atps=neutral Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 64EC06153C for ; Mon, 10 May 2021 07:42:51 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id z18so4979498plg.8 for ; Sun, 09 May 2021 22:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SOVC04RqmEW8Jt8jENnJcmigrGgeZAEDRA3axwT9+IU=; b=H8G1lJuncMz5EpSsMkSnl5wLUmxXSxzIT2rgxP22B7tgzT4ngPyBZ02cTh47+ttbiC JIrty1fI+Fsp5HFSDempmtvKDnzf7EDYHWGwIIZIaCbShKq5IUCRNI26NJKNgeTsjPbC onqcYZCut1PzDmNNlplfVwvJraEz6Zq0ieVMA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SOVC04RqmEW8Jt8jENnJcmigrGgeZAEDRA3axwT9+IU=; b=ZIImh1UP4xh2j5turwfHYk7b5o6GT6sKJEzQa6v/yfIkIV9k2j5QXKOmA8aFB8UVrb DTQi7XB2H4ETQ2sVESHb75f7AYLootGpxXvu93H4QnkAgk1EvVmRiWoPtKNbLEWvSUnl B3XIXZhXCqseJ/lP4B4/xA6L3vonRjzZ+h2i7RZ65eOAFHNVLTDVYrXnK+fS9bXt9Pza R/ULH0587sgKwZl3Fy0uAviTlJ/XKX/cw38gtyF9VT6yyj9qzbjh1x6CzjX3ub15aZwI aM9HE9Og7R1mAvZSGmR8U38qH2hLjL4FfRrRogS7GhYD5pEQa95YQlzFasWD1qQYYe0x rI+Q== X-Gm-Message-State: AOAM531W713Sk57H/+UPd6b5mheIpnlWPA54sXOa3txibSGl2r/ipKCQ SnBkhUVTW5zk1fxXLz6q29IsqLwEy9R4OQ== X-Google-Smtp-Source: ABdhPJx+QtPMvuLoHIH0QJQ73w5btiFRvossq+DQUBIlqLvVgt0rzWsAvTjcIYT8nNL7l6brLLf3rg== X-Received: by 2002:a17:90a:fb97:: with SMTP id cp23mr38340669pjb.169.1620625369443; Sun, 09 May 2021 22:42:49 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:5c5a:ef4c:8b48:6a4a]) by smtp.gmail.com with ESMTPSA id r32sm10172723pgm.49.2021.05.09.22.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 May 2021 22:42:48 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Mon, 10 May 2021 14:42:41 +0900 Message-Id: <20210510054242.2735473-1-hiroh@chromium.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/2] libcamera: pipeline: Remove unnecessary v4l2_controls.h includes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" v4l2_controls.h is included in some places in pipeline codes. But V4l2Control classes are not used there. This removes the redundant v4l2_controls.h includes. Signed-off-by: Hirokazu Honda Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/ipu3/ipu3.cpp | 1 - src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 - src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 1 - src/libcamera/pipeline/vimc/vimc.cpp | 1 - 4 files changed, 4 deletions(-) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index ade8ffbd..411e70b7 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -28,7 +28,6 @@ #include "libcamera/internal/media_device.h" #include "libcamera/internal/pipeline_handler.h" #include "libcamera/internal/utils.h" -#include "libcamera/internal/v4l2_controls.h" #include "cio2.h" #include "frames.h" diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index b2256493..e485f25f 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -36,7 +36,6 @@ #include "libcamera/internal/media_device.h" #include "libcamera/internal/pipeline_handler.h" #include "libcamera/internal/utils.h" -#include "libcamera/internal/v4l2_controls.h" #include "libcamera/internal/v4l2_videodevice.h" #include "dma_heaps.h" diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index faa8d6b0..12a85b24 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -25,7 +25,6 @@ #include "libcamera/internal/pipeline_handler.h" #include "libcamera/internal/sysfs.h" #include "libcamera/internal/utils.h" -#include "libcamera/internal/v4l2_controls.h" #include "libcamera/internal/v4l2_videodevice.h" namespace libcamera { diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index ce83dcaa..d89ab33a 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -30,7 +30,6 @@ #include "libcamera/internal/media_device.h" #include "libcamera/internal/pipeline_handler.h" #include "libcamera/internal/utils.h" -#include "libcamera/internal/v4l2_controls.h" #include "libcamera/internal/v4l2_subdevice.h" #include "libcamera/internal/v4l2_videodevice.h"