From patchwork Fri May 7 02:17:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 12218 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B6987BF831 for ; Fri, 7 May 2021 02:17:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 750226891A; Fri, 7 May 2021 04:17:38 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="lFIc6C7a"; dkim-atps=neutral Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 22B6968909 for ; Fri, 7 May 2021 04:17:37 +0200 (CEST) Received: by mail-pl1-x635.google.com with SMTP id b21so4413683plz.0 for ; Thu, 06 May 2021 19:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GjwcuHreWEVj+JwWpK43mvf0wXjbSvA4zjcvd9RvIdA=; b=lFIc6C7a47M7e3UfZ7lyvXdtc5hvEg6BVCvuox2752LHjbnvS8l8UUbe4Zkfq+EDGk kwlKDXfFBwO3qqV2Vzs1B+a1INcpahnXjoZsMwLX6O3wlvtX7QSgrNROpS7pL3KVzZZh Rkh96I8xmyixAxrb4fkyl3f97jfUqsDLs5Svs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GjwcuHreWEVj+JwWpK43mvf0wXjbSvA4zjcvd9RvIdA=; b=MqnjceJG1LyxJt7jb5O6Vl8PHjARTqRJEK3ZypzafZuXUbQ1xszEEAMahbdHOOWfp9 z1Orxf3TqJQ549Ger/Y0fVm79w2+tBiXwIe0EoWJruS1VFFog6hGal+XaE5Lkj2hd7Kj M4mVEHNL0qTf5gu8XPJPu6kvHcylbEMCC82GloCOXpWlCTAyH4RwCaDeIS0JNeWk3P7R C8YsaIK470mIww0586p8eZ36w3LjNkg9KZ+XNDfwU4TR7KuTlCUCdbCgZy+nLYVRmocP Nt46WiSmS1cFgdiIW1mIBkOYYOrrMydRn00SwO4E5+VbH3x3uXp6HOOLdsEhk8mif8rw rcZg== X-Gm-Message-State: AOAM530xhh3/UHjx3m+Iy411L4m/lt6SprbX9RUB7ICTkOuFof/8k6g5 9FVIsiJhZObxcsVBHvBXXaof5GmE9rb9QQ== X-Google-Smtp-Source: ABdhPJw5VY0s7ZDY1QPSert6gwbBqR9/ZDIDQbgL3EtGIshueOk83cWwqPao1oimDoungTWBXMTPwg== X-Received: by 2002:a17:90a:684b:: with SMTP id e11mr8045881pjm.87.1620353854822; Thu, 06 May 2021 19:17:34 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:2f2e:9aad:9133:6283]) by smtp.gmail.com with ESMTPSA id a190sm3299542pfb.185.2021.05.06.19.17.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 19:17:34 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Fri, 7 May 2021 11:17:26 +0900 Message-Id: <20210507021727.1848611-2-hiroh@chromium.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog In-Reply-To: <20210507021727.1848611-1-hiroh@chromium.org> References: <20210507021727.1848611-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: Remove unnecessary v4l2_controls.h includes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" v4l2_controls.h is includes in some places in pipeline codes. But V4l2Control classes are not used there. This removes the redundant v4l2_controls.h includes. Signed-off-by: Hirokazu Honda Reviewed-by: Jacopo Mondi --- src/libcamera/pipeline/ipu3/ipu3.cpp | 1 - src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 - src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 1 - src/libcamera/pipeline/vimc/vimc.cpp | 1 - 4 files changed, 4 deletions(-) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 73306cea..e9fc41f4 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -28,7 +28,6 @@ #include "libcamera/internal/media_device.h" #include "libcamera/internal/pipeline_handler.h" #include "libcamera/internal/utils.h" -#include "libcamera/internal/v4l2_controls.h" #include "cio2.h" #include "frames.h" diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 2a917455..34d6044f 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -36,7 +36,6 @@ #include "libcamera/internal/media_device.h" #include "libcamera/internal/pipeline_handler.h" #include "libcamera/internal/utils.h" -#include "libcamera/internal/v4l2_controls.h" #include "libcamera/internal/v4l2_videodevice.h" #include "dma_heaps.h" diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index b6c6ade5..de1c36bf 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -25,7 +25,6 @@ #include "libcamera/internal/pipeline_handler.h" #include "libcamera/internal/sysfs.h" #include "libcamera/internal/utils.h" -#include "libcamera/internal/v4l2_controls.h" #include "libcamera/internal/v4l2_videodevice.h" namespace libcamera { diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index 8f5f4ba3..c242efa3 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -30,7 +30,6 @@ #include "libcamera/internal/media_device.h" #include "libcamera/internal/pipeline_handler.h" #include "libcamera/internal/utils.h" -#include "libcamera/internal/v4l2_controls.h" #include "libcamera/internal/v4l2_subdevice.h" #include "libcamera/internal/v4l2_videodevice.h"