From patchwork Thu Apr 29 12:22:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 12133 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EC51BBDE44 for ; Thu, 29 Apr 2021 12:23:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4E5DB68909; Thu, 29 Apr 2021 14:23:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pFtYwiSE"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 519D260511 for ; Thu, 29 Apr 2021 14:23:07 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.128]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B1866BC0; Thu, 29 Apr 2021 14:23:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1619698986; bh=PRg/uRstx0GjWBeiJUv7xzuVyvC4f7RXh+4xrxNO8WQ=; h=From:To:Cc:Subject:Date:From; b=pFtYwiSEJZEG5Dz8ju8WEV13luOOatFOuf5a6Ij5VjLdPqtfzeSvLYgRUk8+dXpww peCVLKK3RYe4HK6WwEMgVTOx/qdVxQrHvF6wHtiWScVd5TXUvFbXxjdoCujm2SNi06 Ri0pZa1PrNWeeaiGl2bcGTywID+31eEcZ+H3/kk0= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Thu, 29 Apr 2021 17:52:58 +0530 Message-Id: <20210429122258.68814-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2] src: android: Rectify internal header's #include path X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" libcamera internal headers are not installed system-wide. Hence, any inclusion of internal headers should be follow the #include directive form: #include "libcamera/internal/header.h" This was not the case for a few of the class in android HAL. Fix them Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Hirokazu Honda --- Changes in v2: - Also include other classes namely, generic_camera_buffer, post_processor as spotted by Niklas. --- src/android/camera_stream.h | 2 +- src/android/mm/generic_camera_buffer.cpp | 2 +- src/android/post_processor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h index f68fdd3a..34016722 100644 --- a/src/android/camera_stream.h +++ b/src/android/camera_stream.h @@ -19,7 +19,7 @@ #include #include -#include +#include "libcamera/internal/buffer.h" class CameraDevice; class CameraMetadata; diff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp index 929e078a..334498c1 100644 --- a/src/android/mm/generic_camera_buffer.cpp +++ b/src/android/mm/generic_camera_buffer.cpp @@ -7,7 +7,7 @@ #include "../camera_buffer.h" -#include +#include "libcamera/internal/buffer.h" #include "libcamera/internal/log.h" using namespace libcamera; diff --git a/src/android/post_processor.h b/src/android/post_processor.h index 4944078b..547fda37 100644 --- a/src/android/post_processor.h +++ b/src/android/post_processor.h @@ -10,7 +10,7 @@ #include #include -#include +#include "libcamera/internal/buffer.h" #include "camera_buffer.h"