From patchwork Tue Apr 13 21:51:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 11920 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 346B0BD224 for ; Tue, 13 Apr 2021 21:52:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AC3A3687D6; Tue, 13 Apr 2021 23:51:59 +0200 (CEST) Received: from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net [195.74.38.227]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ABBB602D1 for ; Tue, 13 Apr 2021 23:51:57 +0200 (CEST) X-Halon-ID: 75cc6956-9ca2-11eb-a9ab-0050569116f7 Authorized-sender: niklas.soderlund@fsdn.se Received: from bismarck.berto.se (p54ac5521.dip0.t-ipconnect.de [84.172.85.33]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA id 75cc6956-9ca2-11eb-a9ab-0050569116f7; Tue, 13 Apr 2021 23:51:56 +0200 (CEST) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org Date: Tue, 13 Apr 2021 23:51:44 +0200 Message-Id: <20210413215144.2733876-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] lc-compliance: Drop return value from SimpleCapture::stop() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The return value is never checked and serves to real usage, drop it. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- src/lc-compliance/simple_capture.cpp | 4 +--- src/lc-compliance/simple_capture.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp index 8f714d3b5e73e28e..811a6220009654be 100644 --- a/src/lc-compliance/simple_capture.cpp +++ b/src/lc-compliance/simple_capture.cpp @@ -50,7 +50,7 @@ Results::Result SimpleCapture::start() return { Results::Pass, "Started camera" }; } -Results::Result SimpleCapture::stop() +void SimpleCapture::stop() { Stream *stream = config_->at(0).stream(); @@ -59,8 +59,6 @@ Results::Result SimpleCapture::stop() camera_->requestCompleted.disconnect(this, &SimpleCapture::requestComplete); allocator_->free(stream); - - return { Results::Pass, "Stopped camera" }; } /* SimpleCaptureBalanced */ diff --git a/src/lc-compliance/simple_capture.h b/src/lc-compliance/simple_capture.h index 4693c13404cee7d2..d9de53fb63a3ea3f 100644 --- a/src/lc-compliance/simple_capture.h +++ b/src/lc-compliance/simple_capture.h @@ -24,7 +24,7 @@ protected: virtual ~SimpleCapture(); Results::Result start(); - Results::Result stop(); + void stop(); virtual void requestComplete(libcamera::Request *request) = 0;