From patchwork Mon Apr 12 22:58:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 11891 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0405ABD1F6 for ; Mon, 12 Apr 2021 22:59:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 66D92687FF; Tue, 13 Apr 2021 00:59:40 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="d7+mvldE"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EC56605AE for ; Tue, 13 Apr 2021 00:59:38 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2DC146F2 for ; Tue, 13 Apr 2021 00:59:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618268378; bh=J8iE2siTuwwnsC1qleTtvT++pI2rb3Z0aXt2vf5Jp5Y=; h=From:To:Subject:Date:From; b=d7+mvldEQlwlIcZaoGLfo5xSLRQ976Jbk4MnxlA+p+lK2bUa5fiRMJLNotOEq3ybX t38kQQT+cYDd7sidfc9JKF2CzIaapyAC1deB7Zc2zBQyqGSShOIPZzp3liSHAM86Bj LmQgGPQ+0Fye3tW0MjAfRwHKUJcXqkA6bmrsMaSg= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 13 Apr 2021 01:58:41 +0300 Message-Id: <20210412225841.13724-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.28.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: signal: Fix return value template type of BoundMethodMember X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The BoundMethodMember instance created in Signal::connect() for receivers inheriting from the Object class incorrectly sets the return type to void instead of R. This doesn't cause any functional issue as the return type is ignored anyway for signals, but should be fixed nonetheless. Signed-off-by: Laurent Pinchart --- include/libcamera/signal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h index 5bcd7a77c5f1..3233529a1275 100644 --- a/include/libcamera/signal.h +++ b/include/libcamera/signal.h @@ -49,7 +49,7 @@ public: ConnectionType type = ConnectionTypeAuto) { Object *object = static_cast(obj); - SignalBase::connect(new BoundMethodMember(obj, object, func, type)); + SignalBase::connect(new BoundMethodMember(obj, object, func, type)); } template::value> * = nullptr>