From patchwork Sun Mar 28 14:27:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Fricke X-Patchwork-Id: 11741 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C5654C32EA for ; Sun, 28 Mar 2021 14:27:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BF09D6877F; Sun, 28 Mar 2021 16:27:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=posteo.net header.i=@posteo.net header.b="cI0hdAsN"; dkim-atps=neutral Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 263B06084F for ; Sun, 28 Mar 2021 16:27:27 +0200 (CEST) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 5173A160061 for ; Sun, 28 Mar 2021 16:27:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1616941646; bh=8N6uYAo+2oRE3m/npdlaxMe+fMSetpglXti67CHZs2s=; h=From:To:Cc:Subject:Date:From; b=cI0hdAsN9n7B69jzPa/oczHpROoxeSsu1lxNhoG3+PJcE26fwn06R5/lFhLS83AQV 9GmFf48Icy4cdcBBOlzmLUmNpyIG/mR3FeQrBqmgtZBmONn8kYQDLKrGSJcOfb0Mer KTDtoBNagxUo4DOmehpTvo0rYlTKstJXext1UhBGhsC59AevEqBvYbxuh6jKBiHZqj j6CTQv0Pg9Z2gUP6cMux3c4RXtek/L27MA3B78BJXbCTxThwXxAVPq4IvONOcAxGxr vIMA1eJMCMR+kHSFbRvQXTEIZ8nOiohW44m4pcpPJJlzTCXvwVcjYNB77uhqvt+AQM +k+VdQ8+5rtrw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4F7dMd5pmdz6tmN; Sun, 28 Mar 2021 16:27:25 +0200 (CEST) From: Sebastian Fricke To: libcamera-devel@lists.libcamera.org Date: Sun, 28 Mar 2021 16:27:12 +0200 Message-Id: <20210328142711.29702-1-sebastian.fricke@posteo.net> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] pipeline: raspberrypi: Remove unused getFormat call X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The comment states, that we get the device format to pass it to the IPA, but the variable `sensorFormat` is not used again after it's assignment. Remove it, together with the comment. Signed-off-by: Sebastian Fricke Reviewed-by: Laurent Pinchart Reviewed-by: Naushir Patuck --- Tested on Raspberry Pi 4 with IMX219 without issues. --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 378a5227..f22e286e 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1238,9 +1238,6 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config) std::map entityControls; ipa::RPi::IPAConfig ipaConfig; - /* Get the device format to pass to the IPA. */ - V4L2DeviceFormat sensorFormat; - unicam_[Unicam::Image].dev()->getFormat(&sensorFormat); /* Inform IPA of stream configuration and sensor controls. */ unsigned int i = 0; for (auto const &stream : isp_) {