From patchwork Tue Mar 23 14:16:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 11665 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D14D3C32E4 for ; Tue, 23 Mar 2021 14:17:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 44D4468D63; Tue, 23 Mar 2021 15:17:18 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="bOk92P3v"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DAACE68D5E for ; Tue, 23 Mar 2021 15:17:16 +0100 (CET) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 31C5A885; Tue, 23 Mar 2021 15:17:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1616509036; bh=pbz35pOT5dyWAxJnH/T6IUEUlXEMiWUHY3oUiuEop5g=; h=From:To:Cc:Subject:Date:From; b=bOk92P3vAuDzQakvTYp2jKSeQWRcR9ZcEJu0E43qbdCo4PdpoDxEmRJpXlpNjE/pv z/kHA+KrewitMwsYNaGIth1s7OMmYwUTX86gHPCyIolOu//mAWYhkeZ4lngHdxTy6E +PcDrIkxdMasH9f6yK9CmKooHciDAXhYkimxIVrc= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 23 Mar 2021 16:16:31 +0200 Message-Id: <20210323141631.29827-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.28.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: camera_manager: Document the CameraManager destructor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The destructor stops the camera manager if it is running. This is at the moment an implementation detail, but makes sense to guarantee in the API. Document it. Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Fricke Reviewed-by: Umang Jain Reviewed-by: Hirokazu Honda Reviewed-by: Paul Elder --- src/libcamera/camera_manager.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index 67641a555e1e..9e4d9c391f09 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -269,6 +269,11 @@ CameraManager::CameraManager() self_ = this; } +/** + * \brief Destroy the camera manager + * + * Destroying the camera manager stops it if it is currently running. + */ CameraManager::~CameraManager() { stop();