From patchwork Wed Mar 17 19:28:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 11608 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B0D69BD80C for ; Wed, 17 Mar 2021 22:53:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3ED8D68D73; Wed, 17 Mar 2021 23:53:46 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 45BCA68D50 for ; Wed, 17 Mar 2021 20:29:11 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id 879391F45371 From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: libcamera-devel@lists.libcamera.org Date: Wed, 17 Mar 2021 16:28:27 -0300 Message-Id: <20210317192831.359014-2-nfraprado@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210317192831.359014-1-nfraprado@collabora.com> References: <20210317192831.359014-1-nfraprado@collabora.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 17 Mar 2021 23:53:43 +0100 Subject: [libcamera-devel] [PATCH 1/5] Documentation: Fix typos and wrong rST syntax for literals X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Chinchilla , Sebastian Fricke Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fix some typos and some literals using ` instead of ``. Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Sebastian Fricke Reviewed-by: Laurent Pinchart --- Documentation/environment_variables.rst | 21 ++++++++++---------- Documentation/guides/introduction.rst | 2 +- Documentation/guides/pipeline-handler.rst | 13 ++++++------ Documentation/sensor_driver_requirements.rst | 12 +++++------ README.rst | 6 +++--- 5 files changed, 27 insertions(+), 27 deletions(-) diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst index 01294d79b9a8..e482c98e5f30 100644 --- a/Documentation/environment_variables.rst +++ b/Documentation/environment_variables.rst @@ -35,10 +35,11 @@ Further details Notes about debugging ~~~~~~~~~~~~~~~~~~~~~ -The environment variables `LIBCAMERA_LOG_FILE` and `LIBCAMERA_LOG_LEVELS` are -used to modify the destination and verbosity of messages provided by libcamera. +The environment variables ``LIBCAMERA_LOG_FILE`` and ``LIBCAMERA_LOG_LEVELS`` +are used to modify the destination and verbosity of messages provided by +libcamera. -The `LIBCAMERA_LOG_LEVELS` variable accepts a comma-separated list of +The ``LIBCAMERA_LOG_LEVELS`` variable accepts a comma-separated list of 'category:level' pairs. The `level <#log-levels>`__ part is mandatory and can either be specified by @@ -61,8 +62,8 @@ within a local environment: LIBCAMERA_LOG_LEVELS=0 \ cam --list -Enable full debug output for the categories `Camera` and `V4L2` within a global -environment: +Enable full debug output for the categories ``Camera`` and ``V4L2`` within a +global environment: .. code:: bash @@ -100,10 +101,10 @@ There are two available macros used to assign a category name to a part of the libcamera codebase: LOG_DEFINE_CATEGORY - This macro is required, in order to use the `LOGC` macro for a particular + This macro is required, in order to use the ``LOGC`` macro for a particular category. It can only be used once for each category. If you want to create log messages within multiple compilation units for the same category utilize - the `LOG_DECLARE_CATEGORY` macro, in every file except the definition file. + the ``LOG_DECLARE_CATEGORY`` macro, in every file except the definition file. LOG_DECLARE_CATEGORY Used for sharing an already defined category between multiple separate compilation units. @@ -118,7 +119,7 @@ IPA modules use configuration files to store parameters. The format and contents of the configuration files is specific to the IPA module. They usually contain tuning parameters for the algorithms, in JSON format. -The `LIBCAMERA_IPA_CONFIG_PATH` variable can be used to specify custom +The ``LIBCAMERA_IPA_CONFIG_PATH`` variable can be used to specify custom storage locations to search for those configuration files. `Examples `__ @@ -130,5 +131,5 @@ In order to locate the correct IPA module for your hardware, libcamera gathers existing IPA modules from multiple locations. The default locations for this operation are the installed system path (for example on Debian: ``/usr/local/x86_64-pc-linux-gnu/libcamera``) and the build directory. -With the `LIBCAMERA_IPA_MODULE_PATH`, you can specify a non-default -location to search for IPA modules. +With the ``LIBCAMERA_IPA_MODULE_PATH``, you can specify a non-default location +to search for IPA modules. diff --git a/Documentation/guides/introduction.rst b/Documentation/guides/introduction.rst index f34d2cf7cbdc..d3a42a23fa8c 100644 --- a/Documentation/guides/introduction.rst +++ b/Documentation/guides/introduction.rst @@ -119,7 +119,7 @@ V4L2 Compatibility Layer V4L2 compatibility is achieved through a shared library that traps all accesses to camera devices and routes them to libcamera to emulate high-level V4L2 camera devices. It is injected in a process address space through - `LD_PRELOAD` and is completely transparent for applications. + ``LD_PRELOAD`` and is completely transparent for applications. The compatibility layer exposes camera device features on a best-effort basis, and aims for the level of features traditionally available from a UVC camera diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index f4a31d3c9588..43783ec32afa 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -177,7 +177,7 @@ configuring a build directory. .. _Meson build configuration: https://mesonbuild.com/Configuring-a-build-directory.html To add the new pipeline handler to this list of options, add its directory name -to the libcamera build options in the top level _meson_options.txt_. +to the libcamera build options in the top level ``meson_options.txt``. .. code-block:: none @@ -777,8 +777,7 @@ implementation. .. code-block:: cpp - std::map> v4l2Formats = - data->video_->formats(); + std::map> v4l2Formats = data->video_->formats(); std::map> deviceFormats; std::transform(v4l2Formats.begin(), v4l2Formats.end(), std::inserter(deviceFormats, deviceFormats.begin()), @@ -1027,7 +1026,7 @@ Initializing device controls ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Pipeline handlers can optionally initialize the video devices and camera sensor -controls at system configuration time, to make sure to make sure they are +controls at system configuration time, to make sure they are defaulted to sane values. Handling of device controls is again performed using the libcamera `controls framework`_. @@ -1240,7 +1239,7 @@ Replace the stubbed contents of ``queueRequestDevice`` with the following: << "Attempt to queue request with invalid stream"; return -ENOENT; - } + } int ret = data->video_->queueBuffer(buffer); if (ret < 0) @@ -1396,7 +1395,7 @@ delivered to applications in the same order as they have been submitted. .. _connecting: http://libcamera.org/api-html/classlibcamera_1_1Signal.html#aa04db72d5b3091ffbb4920565aeed382 Returning to the ``int VividCameraData::init()`` method, add the following above -the closing ``return 0;`` to connects the pipeline handler ``bufferReady`` +the closing ``return 0;`` to connect the pipeline handler ``bufferReady`` method to the V4L2 device buffer signal. .. code-block:: cpp @@ -1428,7 +1427,7 @@ code-base. Testing a pipeline handler ~~~~~~~~~~~~~~~~~~~~~~~~~~ -Once you've built the pipeline handler, we ca rebuild the code base, and test +Once you've built the pipeline handler, we can rebuild the code base, and test capture through the pipeline through both of the cam and qcam utilities. .. code-block:: shell diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst index 17841ddda5f5..3e800c8e9c13 100644 --- a/Documentation/sensor_driver_requirements.rst +++ b/Documentation/sensor_driver_requirements.rst @@ -34,13 +34,13 @@ For RAW sensors, the sensor driver shall support the following V4L2 controls: .. _V4L2_CID_PIXEL_RATE: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-process.html .. _V4L2_CID_VBLANK: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-source.html -While V4L2 doesn't specify a unit for the `EXPOSURE` control, libcamera requires -it to be expressed as a number of image lines. Camera sensor drivers that do not -comply with this requirement will need to be adapted or will produce incorrect -results. +While V4L2 doesn't specify a unit for the ``EXPOSURE`` control, libcamera +requires it to be expressed as a number of image lines. Camera sensor drivers +that do not comply with this requirement will need to be adapted or will produce +incorrect results. -The `HBLANK`, `PIXEL_RATE` and `VBLANK` controls are used to compute the sensor -output timings. +The ``HBLANK``, ``PIXEL_RATE`` and ``VBLANK`` controls are used to compute the +sensor output timings. Optional Requirements --------------------- diff --git a/README.rst b/README.rst index b48455ab4e67..427dbe9cd798 100644 --- a/README.rst +++ b/README.rst @@ -95,9 +95,9 @@ GStreamer can find it. export GST_PLUGIN_PATH=$(pwd)/build/src/gstreamer -The debugging tool `gst-launch-1.0` can be used to construct and pipeline and test -it. The following pipeline will stream from the camera named "Camera 1" onto the -default video display element on your system. +The debugging tool ``gst-launch-1.0`` can be used to construct and pipeline and +test it. The following pipeline will stream from the camera named "Camera 1" +onto the default video display element on your system. .. code:: From patchwork Wed Mar 17 19:28:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 11609 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C16A7BD80C for ; Wed, 17 Mar 2021 22:53:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DBB4168D6B; Wed, 17 Mar 2021 23:53:46 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 04DDD68D50 for ; Wed, 17 Mar 2021 20:29:15 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id BC4501F453D8 From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: libcamera-devel@lists.libcamera.org Date: Wed, 17 Mar 2021 16:28:28 -0300 Message-Id: <20210317192831.359014-3-nfraprado@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210317192831.359014-1-nfraprado@collabora.com> References: <20210317192831.359014-1-nfraprado@collabora.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 17 Mar 2021 23:53:43 +0100 Subject: [libcamera-devel] [PATCH 2/5] Documentation: environment-variables: Use standard rST link syntax X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Chinchilla , Sebastian Fricke Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The usage of # in embedded URIs for references to sections in reStructuredText is HTML specific. Use the standard rST reference to targets instead, to be compatible with other formats as well, should this documentation ever be exported to PDF, for example. See [1] for an equivalent commit in the Linux Kernel documentation. [1] https://lore.kernel.org/linux-doc/20201228144537.135353-1-nfraprado@protonmail.com/ Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Sebastian Fricke Reviewed-by: Laurent Pinchart --- Documentation/environment_variables.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst index e482c98e5f30..d392fd26b87a 100644 --- a/Documentation/environment_variables.rst +++ b/Documentation/environment_variables.rst @@ -15,17 +15,17 @@ LIBCAMERA_LOG_FILE Example value: ``/home/{user}/camera_log.log`` LIBCAMERA_LOG_LEVELS - Configure the verbosity of log messages for different categories (`more <#log-levels>`__). + Configure the verbosity of log messages for different categories (`more `__). Example value: ``*:DEBUG`` LIBCAMERA_IPA_CONFIG_PATH - Define custom search locations for IPA configurations (`more <#ipa-configuration>`__). + Define custom search locations for IPA configurations (`more `__). Example value: ``${HOME}/.libcamera/share/ipa:/opt/libcamera/vendor/share/ipa`` LIBCAMERA_IPA_MODULE_PATH - Define custom search locations for IPA modules (`more <#ipa-module>`__). + Define custom search locations for IPA modules (`more `__). Example value: ``${HOME}/.libcamera/lib:/opt/libcamera/vendor/lib`` @@ -42,10 +42,10 @@ libcamera. The ``LIBCAMERA_LOG_LEVELS`` variable accepts a comma-separated list of 'category:level' pairs. -The `level <#log-levels>`__ part is mandatory and can either be specified by +The `level `__ part is mandatory and can either be specified by name or by numerical index associated with each level. -The optional `category <#log-categories>`__ is a string matching the categories +The optional `category `__ is a string matching the categories defined by each file in the source base using the logging infrastructure. It can include a wildcard ('*') character at the end to match multiple categories. @@ -53,7 +53,7 @@ For more information refer to the `API documentation `__ +Enable full debug output to a separate file, for every `category `__ within a local environment: .. code:: bash From patchwork Wed Mar 17 19:28:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 11610 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 61AA5BD80C for ; Wed, 17 Mar 2021 22:53:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A8DE36084F; Wed, 17 Mar 2021 23:53:47 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C77868D60 for ; Wed, 17 Mar 2021 20:29:18 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id 8FCE61F45371 From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: libcamera-devel@lists.libcamera.org Date: Wed, 17 Mar 2021 16:28:29 -0300 Message-Id: <20210317192831.359014-4-nfraprado@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210317192831.359014-1-nfraprado@collabora.com> References: <20210317192831.359014-1-nfraprado@collabora.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 17 Mar 2021 23:53:43 +0100 Subject: [libcamera-devel] [PATCH 3/5] Documentation: sensor-driver: Fix links to V4L2 documentation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Chinchilla , Sebastian Fricke Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fix some links to the V4L2 documentation. The first one is indeed pointing to the wrong page. The second one has a highlight embedded, so not necessarily wrong, but not needed, so clean it up as well. Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Sebastian Fricke Reviewed-by: Laurent Pinchart --- Documentation/sensor_driver_requirements.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst index 3e800c8e9c13..b0854be3328a 100644 --- a/Documentation/sensor_driver_requirements.rst +++ b/Documentation/sensor_driver_requirements.rst @@ -51,7 +51,7 @@ The sensor driver should support the following V4L2 controls: * `V4L2_CID_CAMERA_SENSOR_ROTATION`_ .. _V4L2_CID_CAMERA_ORIENTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-camera.html -.. _V4L2_CID_CAMERA_SENSOR_ROTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-process.html +.. _V4L2_CID_CAMERA_SENSOR_ROTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-camera.html The controls are used to register the camera location and rotation. @@ -60,7 +60,7 @@ specifically it should implement support for the `VIDIOC_SUBDEV_G_SELECTION`_ ioctl with support for the following selection targets: -.. _VIDIOC_SUBDEV_G_SELECTION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/vidioc-subdev-g-selection.html?highlight=g_selection#c.V4L.VIDIOC_SUBDEV_G_SELECTION +.. _VIDIOC_SUBDEV_G_SELECTION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/vidioc-subdev-g-selection.html#c.V4L.VIDIOC_SUBDEV_G_SELECTION * `V4L2_SEL_TGT_CROP_BOUNDS`_ to report the readable pixel array area size * `V4L2_SEL_TGT_CROP_DEFAULT`_ to report the active pixel array area size From patchwork Wed Mar 17 19:28:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 11611 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E4A88BD80C for ; Wed, 17 Mar 2021 22:53:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5DFB568D51; Wed, 17 Mar 2021 23:53:48 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DB7B68D61 for ; Wed, 17 Mar 2021 20:29:21 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id D22BC1F453D8 From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: libcamera-devel@lists.libcamera.org Date: Wed, 17 Mar 2021 16:28:30 -0300 Message-Id: <20210317192831.359014-5-nfraprado@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210317192831.359014-1-nfraprado@collabora.com> References: <20210317192831.359014-1-nfraprado@collabora.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 17 Mar 2021 23:53:43 +0100 Subject: [libcamera-devel] [PATCH 4/5] Documentation: guides: pipeline-handler: Update code, commands and logs X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Chinchilla , Sebastian Fricke Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The pipeline-handler guide is a bit outdated: - ControlList* in start() is now const. - Registered pipeline handler log now comes from Camera log and the message is different. Update the pipeline-handler guide to reflect these changes. Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Sebastian Fricke Reviewed-by: Laurent Pinchart --- Documentation/guides/pipeline-handler.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index 43783ec32afa..bcce86793ccd 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -209,7 +209,7 @@ methods for the overridden class members. int exportFrameBuffers(Camera *camera, Stream *stream, std::vector> *buffers) override; - int start(Camera *camera, ControlList *controls) override; + int start(Camera *camera, const ControlList *controls) override; void stop(Camera *camera) override; int queueRequestDevice(Camera *camera, Request *request) override; @@ -239,7 +239,7 @@ methods for the overridden class members. return -1; } - int PipelineHandlerVivid::start(Camera *camera, ControlList *controls) + int PipelineHandlerVivid::start(Camera *camera, const ControlList *controls) { return -1; } @@ -303,13 +303,13 @@ new pipeline handler by running: .. code-block:: shell - LIBCAMERA_LOG_LEVELS=Pipeline:0 ./build/src/cam/cam -l + LIBCAMERA_LOG_LEVELS=Camera:0 ./build/src/cam/cam -l And you should see output like the below: .. code-block:: shell - DEBUG Pipeline pipeline_handler.cpp:680 Registered pipeline handler "PipelineHandlerVivid" + DEBUG Camera camera_manager.cpp:148 Found registered pipeline handler 'PipelineHandlerVivid' Matching devices ~~~~~~~~~~~~~~~~ From patchwork Wed Mar 17 19:28:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 11612 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 40D2CC32E2 for ; Wed, 17 Mar 2021 22:53:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 11ACC68D6C; Wed, 17 Mar 2021 23:53:49 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BFA6C68D62 for ; Wed, 17 Mar 2021 20:29:24 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id 14A7F1F45371 From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: libcamera-devel@lists.libcamera.org Date: Wed, 17 Mar 2021 16:28:31 -0300 Message-Id: <20210317192831.359014-6-nfraprado@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210317192831.359014-1-nfraprado@collabora.com> References: <20210317192831.359014-1-nfraprado@collabora.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 17 Mar 2021 23:53:43 +0100 Subject: [libcamera-devel] [PATCH 5/5] Documentation: guides: pipeline-handler: Fix capture flag usage X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Chinchilla , Sebastian Fricke Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The number of frames passed to the -C flag of cam should come right after it, without a space, otherwise the value is discarded. The log below already showed the correct usage, but the command in the code-block was wrong, so fix it. Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Sebastian Fricke Reviewed-by: Laurent Pinchart --- Documentation/guides/pipeline-handler.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index bcce86793ccd..8ef83fea9837 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -1433,7 +1433,7 @@ capture through the pipeline through both of the cam and qcam utilities. .. code-block:: shell ninja -C build - ./build/src/cam/cam -c vivid -C 5 + ./build/src/cam/cam -c vivid -C5 To test that the pipeline handler can detect a device, and capture input.