From patchwork Tue Mar 16 06:20:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 11579 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B108ABD80C for ; Tue, 16 Mar 2021 06:20:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 12CF368D45; Tue, 16 Mar 2021 07:20:14 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=uajain.com header.i=@uajain.com header.b="ZbvYkByK"; dkim-atps=neutral Received: from mail.uajain.com (static.126.159.217.95.clients.your-server.de [95.217.159.126]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CA1B602DB for ; Tue, 16 Mar 2021 07:20:12 +0100 (CET) From: Umang Jain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail; t=1615875611; bh=+YchGEuq3KvJV9ckHHBycwxz4lMQa7ZTYjAruAbJ+zE=; h=From:To:Cc:Subject; b=ZbvYkByK90SnEwgoMVNDDoBsGwzmMLgzlYkmNOtWqarF+uEZRM+j7LVInBJY8oxAY +DO8tV3FOgAjmkQImA+YSLdaqSNFG4mJkqolrMz4yHQoQLdzrky5zGVwUR0dj0Vwhs 3nvB4q8s/ghJksFpL6jJio6eUAC+2lk4s906TGECxUasHeYBiECZwE3gI6AM5bKjf3 eeULs4t/cPoCNk8Glx6eZR1shVE4LV9P49lSYG3z+S0vgIp7jxDms8QIsBaxsGw9wf SlkBsmrmDv/hcjktnyLCoVtO/2Sm2hQYnWR5F+BhuGE6Neax8GK6dyzjAIrVU0bBLo 9UKrAYlEcDkEQ== To: libcamera-devel@lists.libcamera.org Date: Tue, 16 Mar 2021 11:50:04 +0530 Message-Id: <20210316062004.59692-1-email@uajain.com> Mime-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: camera_manager: Remove \todo on hotplug/unplug of cameras X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fixes: e9b47217b44c ("libcamera: camera_manager: Introduce signals when a camera is added or removed") Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/libcamera/camera_manager.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index 67641a55..8682cbcd 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -251,10 +251,6 @@ void CameraManager::Private::removeCamera(Camera *camera) * action from the application. Once the application has released all the * references it held to cameras, the camera manager can be stopped with * stop(). - * - * \todo Add interface to register a notification callback to the user to be - * able to inform it new cameras have been hot-plugged or cameras have been - * removed due to hot-unplug. */ CameraManager *CameraManager::self_ = nullptr;