From patchwork Mon Mar 15 09:24:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11576 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 28FC4BD80E for ; Mon, 15 Mar 2021 09:25:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9182A68D40; Mon, 15 Mar 2021 10:25:10 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="auwZAxG6"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 237CE602ED for ; Mon, 15 Mar 2021 10:25:08 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D717556; Mon, 15 Mar 2021 10:25:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615800307; bh=Ny+qAk3bA5OBaThSSqybsPYh7IauoVbXbGwfMD8Zudo=; h=From:To:Cc:Subject:Date:From; b=auwZAxG6TVUpYkshTRODDF7FNO8ZB7kAJhwhZr8gnEMf9US0olES+qXXAgbmcaNzT SR3NO3V49AR1sA2ClQyA365CG/DP7R32OZWcAna57vc5ynh1k8Ga7o4P7LI3MbB29O H0WU+ygmoeAvBhF/z+0ATS5DRSp7GPb6d/j90kHU= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 15 Mar 2021 18:24:56 +0900 Message-Id: <20210315092456.13525-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to defend the forward-declaration X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Any struct that is defined in core.mojom with the skipHeader tag needs to be present in ipa_interface, either forward-declared or #included. Add an argument so that, in the future, people don't try to send patches removing the seemingly unused forward-declaration. Signed-off-by: Paul Elder Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- include/libcamera/ipa/ipa_interface.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h index 47f81d1d..5d99e2cf 100644 --- a/include/libcamera/ipa/ipa_interface.h +++ b/include/libcamera/ipa/ipa_interface.h @@ -20,6 +20,11 @@ namespace libcamera { +/* + * Structs that are defined in core.mojom and have the skipHeader tag must be + * forward-declared or #included here. + */ + struct CameraSensorInfo; class IPAInterface