From patchwork Tue Feb 9 14:52:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 11203 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5F187BD160 for ; Tue, 9 Feb 2021 14:52:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D272261628; Tue, 9 Feb 2021 15:52:47 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YCZIaTUq"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D7AB460D16 for ; Tue, 9 Feb 2021 15:52:46 +0100 (CET) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:169:7140:4d26:9423:a9d1:8c4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E1B2BC0; Tue, 9 Feb 2021 15:52:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1612882366; bh=L7wJeXkt0U5nDMPGriN6XMNPSLDV+n9zT/WG+OOye7w=; h=From:To:Cc:Subject:Date:From; b=YCZIaTUq0VGK0Ao4UTemCR6GaES+NPb9h7PX6oOWrVX00PG5m0+sJu565HAyJzedU 6a5DPECUl706X1t3uPwv0sQaaIUYnmMB8g4hBPg4qTkYK92O0uEhD1IrsMToxVglo9 24c2B4mMnLJlEL2gku8WrU/fOp21SoHbHbxsZWKg= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 9 Feb 2021 15:52:44 +0100 Message-Id: <20210209145244.25408-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: ipu3: set V4L2_CID_INTEL_IPU3_MODE X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In order to get the stats back, the imgu subdev needs to have the V4L2_CID_INTEL_IPU3_MODE control set. Set it to video mode by default to get the stats at each frame. Signed-off-by: Jean-Michel Hautbois Reviewed-by: Jacopo Mondi --- src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 61f7bf43..104cb532 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -552,8 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c) /* Apply the "pipe_mode" control to the ImgU subdevice. */ ControlList ctrls(imgu->imgu_->controls()); ctrls.set(V4L2_CID_IPU3_PIPE_MODE, - static_cast(vfCfg ? IPU3PipeModeVideo : - IPU3PipeModeStillCapture)); + static_cast(IPU3PipeModeVideo)); ret = imgu->imgu_->setControls(&ctrls); if (ret) { LOG(IPU3, Error) << "Unable to set pipe_mode control";