From patchwork Fri Oct 30 01:37:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10303 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B1B0FBDB1E for ; Fri, 30 Oct 2020 01:38:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 44E0E628A5; Fri, 30 Oct 2020 02:38:33 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KwriusK6"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A1F160353 for ; Fri, 30 Oct 2020 02:38:32 +0100 (CET) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 90C939B7 for ; Fri, 30 Oct 2020 02:38:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1604021911; bh=5Y6ejcLZt+YEHXjFc1QadM8uDXtql5wH6379Md3oVWE=; h=From:To:Subject:Date:From; b=KwriusK6Nqbk4jcWiArCnz4n4P4mw0xouuCZe56elKpK/9C23pPafhgGTlt+FsWFL UhDBC0Ez9ZuaqmbK+yg1k6kV6b9B1dRPLTnLXBVSfS7f75XW+dT4s7GgiPRE4urRqX qvddWJPddRQ9+vUQXXR7ADRGI6vfpamjts9XNY6U= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 30 Oct 2020 03:37:35 +0200 Message-Id: <20201030013735.15603-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] utils: hooks: pre-push: Reject commits with a Change-Id X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" We're not using gerrit, so let's prevent Change-Id tags creeping in unadvertently. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Niklas Söderlund --- utils/hooks/pre-push | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push index 2417d379db4c..d13e2c3b506c 100755 --- a/utils/hooks/pre-push +++ b/utils/hooks/pre-push @@ -63,6 +63,13 @@ do echo >&2 "No Reviewed-by or Acked-by in commit $commit" errors=$((errors+1)) fi + + # 4. The commit message shall not contain a Change-Id. + if echo "$msg" | grep -q '^Change-Id:' + then + echo >&2 "Found Change-Id in commit $commit" + errors=$((errors+1)) + fi done if [ $errors != 0 ]